feat(editor): wire tempo map command controls - #75
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds three Tempo Map shortcut commands, makes the EOF and Feedback key mappers mode-aware, wires the new handlers into command dispatch, changes anchor navigation source, and updates shortcut mapping tests. ChangesTempo Map shortcuts and anchor navigation
Estimated code review effort: 2 (Simple) | ~12 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant Dispatch as EOF/Feedback Dispatch
participant Mapper as CommandForKeyPure
participant Runner as _editorRunEofCommand
participant Handler as Tempo Map Handler
User->>Dispatch: press key (b, i, Delete, etc.)
Dispatch->>Mapper: resolve key with mode='tempoMap'
Mapper-->>Dispatch: tempoSetBpm / tempoInsertSync / tempoDeleteSync
Dispatch->>Runner: run command id
Runner->>Handler: invoke matching Tempo Map handler
Handler->>Handler: check S.tempoMapMode and S.tempoSel
Handler-->>Runner: update tempo sync point state
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.44.1)screen.jsast-grep timed out on this file Comment |
byrongamatos
force-pushed
the
feat/editor-tempo-sync-actions
branch
from
July 5, 2026 20:19
d71ce10 to
adc8c77
Compare
ChrisBeWithYou
marked this pull request as ready for review
July 5, 2026 21:44
prevAnchor/nextAnchor (Ctrl+Alt+Left/Right, and the Shortcuts panel buttons
this PR wires) threw ReferenceError: _anchorProjection is not defined — the
anchor list comes from _readAnchorSnapshot(arr).list ({time,...} items), not a
non-existent _anchorProjection returning {anchor:{time}}. Pre-existing on main;
fixed here since this PR surfaces the commands.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
byrongamatos
force-pushed
the
feat/editor-tempo-command-controls
branch
from
July 5, 2026 21:58
a758fb4 to
6992806
Compare
This was referenced Jul 6, 2026
This was referenced Jul 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Summary by CodeRabbit
New Features
Bug Fixes
Tests