feat(editor): add slide shortcut

[ChrisBeWithYou]

Summary

• add a note-mode S shortcut for the pitched slide editor
• keep Tempo Map S routed to the sync-point split/lock command while Tempo Map mode is active
• cover the new key labels and active-mode precedence in shortcut tests

Validation

• node --check screen.js
• node tests\eof_shortcuts.test.js
• node tests\tempo_map_timesig.test.js
• node tests\tempo_sync_inspector.test.js
• node tests\tempo_map_bpm.test.js
• node tests\tempo_map_guidance.test.js
• node tests\measure_readout.test.js
• git diff --cached --check
• staged public-term guardrail scan

Summary by CodeRabbit

• New Features
  • Added a new shortcut for editing a note’s slide from the editor.
  • The S key now opens the slide prompt for the currently selected note in both shortcut modes.
• Bug Fixes
  • Improved keyboard shortcut handling so the slide-edit action is available consistently across profiles.
  • If no note is selected, the app now prompts you to select one before continuing.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 70724148-2b54-4141-a066-1794b5194edd

📥 Commits

Reviewing files that changed from the base of the PR and between 636938b and 3c5c39e.

📒 Files selected for processing (2)

• screen.js
• tests/eof_shortcuts.test.js

---

📝 Walkthrough

Walkthrough

Adds a new slideEditor shortcut command bound to key S in the editor's shortcut registry, extends EOF and feedback key resolvers to map s to this command, implements a command runner case invoking promptSlide for the selected note, and adds corresponding test assertions.

Changes

slideEditor Shortcut

Layer / File(s)	Summary
Shortcut registration, resolution, and execution screen.js	Adds a slideEditor command (Notes group, key S) to the shortcut registry, extends EOF and feedback key resolvers to map s to slideEditor, and adds a command runner case that calls promptSlide for the selected note or prompts for selection if none exists.
Test coverage for slideEditor shortcut tests/eof_shortcuts.test.js	Adds assertions verifying slideEditor appears with key label 'S' in eof and feedback shortcut rows, and that 's' maps to slideEditor in feedback and Tempo Map active-mode tests.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant KeyResolver
  participant CommandRunner
  participant promptSlide

  User->>KeyResolver: press 's'
  KeyResolver->>KeyResolver: resolve to slideEditor command id
  KeyResolver->>CommandRunner: dispatch slideEditor
  alt note selected
    CommandRunner->>promptSlide: open slide prompt for selected note
  else no note selected
    CommandRunner->>CommandRunner: set status prompting selection
  end

Loading

Possibly related PRs

• got-feedBack/feedBack-plugin-editor#75: Both PRs extend the same EOF/feedback shortcut key-to-command resolver logic in screen.js to map additional keys to new command ids.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/editor-slide-shortcut

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.44.1)

screen.js

ast-grep timed out on this file

---

_{Comment @coderabbitai help to get the list of available commands.}