Repository navigation
Compose Git acquisition grants, shutdown and retained-source recovery - #227
Conversation
|
@codex review |
There was a problem hiding this comment.
🔵 Needs a closer look
Four unresolved moderate findings cover descriptor exactness, intake cleanup, resource cleanup, and valid path handling.
No open issues 🎉
What changed in this PR
This PR composes a private Linux Git acquisition factory with credential lifecycle management, containment checks, broker shutdown, archive recovery, and blob-based source restoration.
Changes:
- Adds mount, descriptor, ancestry, grant, and unit validation.
- Coordinates capture, restore, shutdown, credential release, and recovery.
- Expands lifecycle, recovery, boundary tests, and documentation.
Open findings:
- Exact inherited eventfd/epoll descriptors are not enforced.
- Failed acquisitions can leave receiving archive records.
- Constructor failures may leak transferred resources.
- Valid deployment paths can be rejected by the directory-length check.
| File | Reviewed change |
|---|---|
reviewer/snapshot_evidence.go |
Shared packet and anchor reconstruction |
reviewer/GIT-MOUNT-BOUNDARY.md |
Mount qualification documentation |
reviewer/GIT-FACTORY.md |
Factory lifecycle documentation |
reviewer/GIT-EXPORT-ARCHIVE.md |
Archive recovery documentation |
reviewer/GIT-DESCRIPTOR-BOUNDARY.md |
Descriptor qualification documentation |
reviewer/git_unit_grant_linux.go |
Grant asset and binding validation |
reviewer/git_source_factory_linux.go |
Source factory composition and lifecycle |
reviewer/git_source_factory_linux_test.go |
Factory startup and restoration tests |
reviewer/git_mount_boundary_linux.go |
Mount observation and validation |
reviewer/git_mount_boundary_linux_test.go |
Mount policy and fixture tests |
reviewer/git_factory_unit_linux.go |
Unit and ancestry checks |
reviewer/git_factory_unit_linux_test.go |
Unit validation tests |
reviewer/git_factory_run_linux.go |
Acquisition, grants, broker, and shutdown |
reviewer/git_factory_run_linux_test.go |
Run lifecycle and failure tests |
reviewer/git_factory_recovery_linux.go |
Startup and intake recovery |
reviewer/git_factory_recovery_linux_test.go |
Recovery behavior tests |
reviewer/git_factory_evidence_linux.go |
Materialization evidence reconstruction |
reviewer/git_factory_acquisition_linux.go |
Credential-bound acquisition orchestration |
reviewer/git_factory_acquisition_linux_test.go |
Publication and lease-ordering tests |
reviewer/git_export_archive_linux.go |
Discarded-intake and terminal close handling |
reviewer/git_descriptor_boundary_linux.go |
Inherited descriptor observation and validation |
reviewer/git_descriptor_boundary_linux_test.go |
Descriptor policy and observation tests |
Review effort: Lite
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c6cbec3ff0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Addressed all four passive review concerns in 820ff68.
Vet and the fresh full race suite pass on the corrected source, main package 159.907 seconds, with both actual namespace/descriptor opt-ins. Manager/cgroup and credential transports remain fake; the fixed systemd noswap tmpfs and sealed-inner-worker physical gates are still failed. Required current-head review remains a merge gate. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c6cbec3ff0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
820ff68 to
7383bc6
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 822440917e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
7dfe596 to
9123249
Compare
8224409 to
b8bf7ea
Compare
9123249 to
5af8476
Compare
b8bf7ea to
44e31ab
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44e31ab86d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
44e31ab to
2b2acc1
Compare
|
@codex review |
2b2acc1 to
b157c18
Compare
|
@codex review |
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Compose the private Git acquisition factory from the pinned runtime, credential generation, fixed grants, original process/mount/descriptor observations and bounded plain export archive. Source escapes only after broker/acquisition join, independent physical-stop proof, credential-generation acceptance and retained run disposal. Unknown outcomes retain ownership.
PollOptions.Sourceholds capture and restored-job evidence until consumers release them. Retention preserves pending captures, active consumers, retained SQLite jobs and uncertain workers. Eligible terminal attempts retire through fsynced intents and atomic directory moves, with startup completing interrupted cleanup. Idle polls collect expired source; polls skip the factory retention lock while a capture is active. Work roots must have different opened identities from both journal roots.Restore keeps the exact admitted packet and original unit/archive binding across release, helper and worker upgrades. The parent authenticates older unit receipts against their existing cached worker bytes; retirement uses that same original-image check. Missing or changed old bytes refuse, and old receipts cannot launch through the new image.
Related to #174 and #176. The lifecycle prerequisite #226 merged at
57f4cb6; this PR targets main. These broader issues remain open.Acceptance Criteria
Definition of Done
Validation
Head
b157c18e43c332c32d1d58f93a84ef28595a8337, parent57f4cb6d1f1151f23b0edc90726e020d3341d204.go -C reviewer vet ./...: pass.SFL_GIT_DESCRIPTOR_KERNEL=1 SFL_GIT_BOOTSTRAP_NAMESPACE=1 go -C reviewer test -race ./... -count=1: pass, main package 174.072 seconds. This run and vet executed at2b2acc1; the current whole repository tree is identical after replaying only the twelve owned commits onto the actual parent squash. Tree5ed9749299b1321fb5ba96399b73cf8581c9038fmatches exactly; no test rerun or new code change is claimed.Manager/cgroup observations and credential transports are fake. Pipes, pidfds, flock, sealed files, fsync, process kills and trusted Git fixtures are real. The namespace worker is an ordinary measured inert executable, not qualified sealed production execution. Synthetic upgraded worker bytes and the existing root-owned helper test asset are never executed.
Risks and deferred work
The fixed noswap systemd path still fails on mini with
226/NAMESPACE; sealed inner-worker execution fails withEACCES. The actual noexec filesystem fixture remains skipped. Inert subset passes do not waive these gates.Unit/archive roots must share a filesystem. At most 128 active exports retain about 4 GiB plus framing; recovery scans at most 128 intents and two fixed trash directories per intent. Small work directories remain recovery artifacts, and old worker copies remain until dependent records retire. Uncaptured active/exited manager metadata can remain after proof of original physical termination; coordinated manager cleanup belongs to complete host/resource qualification. No later source cleanup stops a unit name.
Trusted service/release/startup wiring, provider/account/subscription/public-target/auth and billing evidence, native controls and comparative evaluation, release promotion/rollback, final rendered GitHub evidence and explicit owner live authorization remain separate work. No credentials, App configuration, live inference, paid use, deployment, host policy or retired automation are activated.