Skip to content

Compose explicit reviewer service startup and retained shutdown - #228

Merged
HemSoft merged 1 commit into
mainfrom
feature/issue-176-service-startup
Oct 21, 2026
Merged

HemSoft merged 1 commit into
mainfrom
feature/issue-176-service-startup

Conversation

@HemSoft

@HemSoft HemSoft commented Oct 21, 2026 •

Copy link
Copy Markdown
Collaborator

The source factory and credential/controller libraries had no service owner to retain them together. This private Linux assembly recovers source before explicit credential qualification, polls the selected comment and automatic triggers, and joins the controller before releasing source or credential owners.

The native release catalog selects each durable job's original release and configured providers, with a separate bound reader and audited VM reviewer for each provider. Construction performs no signing, GitHub request, auth import or inference.

Acceptance criteria

  • Recovery precedes signing and polling. Unknown startup retains a nonnil service for explicit recovery or close; pre-transfer failure leaves caller inputs owned.
  • Reader and publisher use distinct roles of one credential owner. The selected trigger reader also supplies publication provenance.
  • Explicit refresh holds the source factory fence through qualification; generation shutdown can still drain. Run never refreshes and starts once.
  • Close cancels and joins work before disposing the controller, factory and credential owner in order. Unreturned callbacks or unknown stops retain later owners for retry.
  • A bounded copied native catalog binds exact release, provider, identity, job, packet, snapshot, config and round. Unknown or revoked releases and partial dual modes refuse without fallback.

Validation

The child-owned commit was rebased onto the actual PR #227 squash merge. Its entire tree 076359a188710b1cbf8716997cb36a841c7aab44 is identical to tested head 045a844df2566d9c9821c69e374ce15126e50b54; the local qualification below is retained for those unchanged bytes. New-head Codex review is still required.

Head 34c6f4422123d56d7a32a9eb43a0414849d6b1cf.

  • go -C reviewer vet ./...: PASS.
  • Focused go test -race -run 'TestGitReviewerService|TestGitServiceNative' -count=1 ./...: PASS, main package 1.958 seconds.
  • SFL_GIT_DESCRIPTOR_KERNEL=1 SFL_GIT_BOOTSTRAP_NAMESPACE=1 go -C reviewer test -race -count=1 ./...: PASS, main package 172.014 seconds.
  • Local TLS fixtures exercised both reader GET and publisher POST, plus an empty-scope model-free polling run. Lifecycle tests cover uncertain recovery, constructor ownership, cancellation during an unreturned signing callback, generation drain and both shutdown paths. Native closed-gate tests perform zero inference or auth reads.

Definition of done and limits

This is one source slice of #176, built on the acquisition factory merged in #227. It does not close the broader issue. The internal service has no public operator entry point or deployment packaging yet. Trusted release promotion/rollback, native control tasks and the durable evaluation runner remain source work. reviewer/GIT-SERVICE.md records ownership and lifecycle rules.

Complete host containment qualification, provider policy/account/quota evidence, final App/trigger rendering proof and explicit live owner authorization remain separate gates. Prior physical qualification failures remain failures. Actions is disabled by owner; no CI result or live activation is claimed.

Copilot AI lite review requested due to automatic review settings October 21, 2026 19:21
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T20:15:24.522198Z 34c6f44 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@HemSoft

HemSoft commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 045a844df2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Broad lifecycle and native runtime changes warrant final human review.

No open issues 🎉

What changed in this PR

Adds a private Linux reviewer service with explicit credential qualification, native runtime selection, polling, and ordered shutdown ownership.

Changes:

  • Adds service startup, recovery, refresh, run, and close lifecycle handling.
  • Adds bounded native release/provider catalog composition.
  • Documents ownership and lifecycle guarantees with focused tests.
File Description
reviewer/​GIT-SERVICE.md Documents service ownership and lifecycle rules.
reviewer/​git_service_runtime_linux.go Builds validated native runtimes.
reviewer/​git_service_runtime_linux_test.go Tests catalog binding and runtime isolation.
reviewer/​git_service_linux.go Implements service orchestration and shutdown.
reviewer/​git_service_linux_test.go Tests lifecycle and ownership behavior.

Review effort: Lite

@HemSoft
HemSoft changed the base branch from feature/issue-176-acquisition-boundary to main October 21, 2026 20:09
@HemSoft
HemSoft force-pushed the feature/issue-176-service-startup branch from 045a844 to 34c6f44 Compare October 21, 2026 20:11
@HemSoft

HemSoft commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 34c6f44221

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@HemSoft
HemSoft merged commit 617b9e1 into main Oct 21, 2026
@HemSoft
HemSoft deleted the feature/issue-176-service-startup branch October 21, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants