Repository navigation
feat: publish Third Roll marketing support and privacy site - #100
Conversation
|
@sfl review |
There was a problem hiding this comment.
✅ Verdict: PASS • Round 1
Review done by gpt-6.1-sol
The change adds GitHub Pages publication for Third Roll, updates support and privacy information, and includes two development screenshots. Security, accuracy and quality passes found no evidenced defects within the stated static coverage; this is not proof of correctness.
🔨 Full-Spectrum Review Summary
Effort: high
Review time: 1m 49s
Token count: Unavailable
| Pass | 🔴 Critical | 🟠 High | 🟡 Medium | ⚪ Low |
|---|---|---|---|---|
| 🔒 Security | 0 | 0 | 0 | 0 |
| ✅ Accuracy | 0 | 0 | 0 | 0 |
| 🧰 Quality & Maintainability | 0 | 0 | 0 | 0 |
| Total | 0 | 0 | 0 | 0 |
Key Findings
No material defects found.
Coverage
- Files reviewed:
.github/ISSUE_TEMPLATE/bug_report.md.github/ISSUE_TEMPLATE/feature_request.md.github/workflows/site-pages.yml.impeccable/surfaces/site-pages-mjs.mdHistory/2026-11-02.mdSECURITY.mdapps/mobile/PRIVACY.mdscripts/ios-release/support.test.mjssite/README.mdsite/assets/iphone-help.pngsite/assets/iphone-setup.pngsite/assets/provenance.jsonsite/build.mjssite/build.test.mjssite/pages.mjssite/serve.mjssite/style.csssite/workflow.test.mjs
- Context read:
AGENTS.mdCLAUDE.md.github/ISSUE_TEMPLATE/config.yml.github/workflows/site-preview.ymlsite/content.test.mjssite/browser.mjsapps/mobile/app.jsonapps/mobile/package.jsonapps/mobile/app/_layout.tsxapps/mobile/src/local/LocalProvider.tsxapps/mobile/src/local/diagnostics.tsapps/mobile/src/local/platformStorage.native.tsapps/mobile/src/local/save.tsapps/mobile/src/local/sqliteStorage.tsapps/mobile/src/local/store.tsapps/mobile/src/screens/Help.tsxapps/mobile/src/screens/NativeGameScreen.tsxapps/mobile/src/screens/Play.tsxapps/mobile/src/screens/Results.tsxapps/mobile/src/screens/Setup.tsxdocs/mobile-privacy-audit.mddocs/mobile-release-brief.mdpackages/game-engine/src/game.tspackages/game-engine/src/scoring.tspackages/game-engine/src/session.tspackages/game-engine/src/storage.tspackages/game-engine/tests/nativeDiagnostics.test.tspackages/game-engine/tests/nativePersistence.test.tspackages/game-engine/tests/nativeSqlite.test.ts
- Verified:
- Compare
base_commit.shaequals74d09ab68b654ad2be6089185d345e20f465aa9b; final commit and PR head equald373bc76385e505a0f8ae97350401fed6516d96c. - Inspected the complete text diff, both added screenshots and relevant source at the exact head.
- Publication requires
main; deployment depends on successful build and receives onlypages: writeandid-token: write. - Builder copies explicitly named static assets; publication uploads
reports/site-public, excluding repository source and browser reports. - Read pinned upload/deploy action definitions; both use the default
github-pagesartifact name. - GitHub API reports Pages configured for workflow deployment with HTTPS enforced and private vulnerability reporting enabled.
- Mode counts, bonuses, combinations, automatic rolls and opponent limits agree with scoring and session implementation.
- Retention, exact-state retries, explicit reload and reset descriptions agree with storage implementation and inspected test cases.
- Diagnostics use explicit fields; Help previews the text before offering system sharing.
- HTML uses local assets and contains no scripts, forms, embeds or invented App Store destination.
- Both screenshots show setup or Help without visible player information; artifact metadata matches the provenance source SHA and run.
- Compare
- Not verified:
- Live publication, unauthenticated HTTPS responses and rendered accessibility were not checked because review was restricted to GitHub API reads.
- Screenshot hashes were not compared with original artifact contents; only committed images, provenance and artifact metadata were inspected.
- Compiled bundle and disabled-update claims rely on the historical engineering inventory; the unsigned app artifact was not inspected.
- SDK traffic, signatures, physical-device backup/restore and OS sharing behavior require evidence beyond source inspection.
- GitHub hosting-log retention and external privacy-policy claims were not independently checked because external documentation retrieval was outside the permitted API scope.
- Absence of all SDK telemetry was not established; inspected native source and package configuration provide limited static coverage.
- Tests run: None. Reviewer execution is disabled.
HemSoft full-spectrum review • 3 evidence-based passes • Reviewed head d373bc76385e505a0f8ae97350401fed6516d96c • SFL v0
There was a problem hiding this comment.
🟡 Changes recommended
The publication workflow omits the scoring source from its path filters, allowing scoring changes to leave the public site stale.
1 open issue
1 file not reviewed
site/style.css: Generated file
What changed in this PR
Publishes the Third Roll companion site through GitHub Pages with stable marketing, support, and privacy URLs while preserving prerelease messaging and documenting hosting, reporting, and privacy practices.
Changes:
- Adds a main-only GitHub Pages workflow with pinned Actions, scoped permissions, and static-build deployment.
- Updates marketing, support, privacy, security, issue-template, and repository documentation.
- Adds provenance-documented simulator screenshots and publication/build validation coverage.
| File | Summary |
|---|---|
site/workflow.test.mjs |
Validates deployment workflow restrictions and pinned Actions. |
site/style.css |
Adds responsive screenshot presentation styles. |
site/serve.mjs |
Serves screenshot assets locally. |
site/README.md |
Documents stable URLs, publication, verification, ownership, and rollback. |
site/pages.mjs |
Publishes marketing, support, and privacy content. |
site/build.test.mjs |
Tests public-build behavior and prerelease disclosures. |
site/build.mjs |
Adds publication mode, discovery files, and screenshot assets. A provenance hash validation is still required before publication. |
site/assets/provenance.json |
Records screenshot source, artifact, and SHA-256 metadata. |
SECURITY.md |
Documents the enabled private vulnerability-reporting route. |
scripts/ios-release/support.test.mjs |
Updates support-policy assertions. |
History/2026-11-02.md |
Records publication preparation and asset provenance work. |
apps/mobile/PRIVACY.md |
Links the public policy and preserves release-verification limits. |
.impeccable/surfaces/site-pages-mjs.md |
Updates the companion-site publication direction. |
.github/workflows/site-pages.yml |
Builds and deploys the public site from main; the publication path filter should also track the scoring source to prevent stale generated content. |
.github/ISSUE_TEMPLATE/feature_request.md |
Updates security-reporting guidance. |
.github/ISSUE_TEMPLATE/bug_report.md |
Updates security-reporting guidance. |
Review effort: Lite
|
@sfl review |
There was a problem hiding this comment.
✅ Verdict: PASS • Round 2
Since round 1
New: 0; still open (repeated): 0; resolved: 0.
Resolved means no matching finding in this review, not independent proof of a fix.
New (0)
- None.
Still open (repeated) (0)
- None.
Resolved (0)
- None.
Review done by gpt-6.1-sol
Publishes the Third Roll companion site through GitHub Pages, adds simulator screenshots, and updates support and privacy information. Security, accuracy and quality passes found no evidenced defects within the inspected diff and exact-head context; the review supports a non-blocking verdict within the stated coverage.
🔨 Full-Spectrum Review Summary
Effort: high
Review time: 1m 53s
Token count: Unavailable
| Pass | 🔴 Critical | 🟠 High | 🟡 Medium | ⚪ Low |
|---|---|---|---|---|
| 🔒 Security | 0 | 0 | 0 | 0 |
| ✅ Accuracy | 0 | 0 | 0 | 0 |
| 🧰 Quality & Maintainability | 0 | 0 | 0 | 0 |
| Total | 0 | 0 | 0 | 0 |
Key Findings
No material defects found.
Coverage
- Files reviewed:
.github/ISSUE_TEMPLATE/bug_report.md.github/ISSUE_TEMPLATE/feature_request.md.github/workflows/site-pages.yml.impeccable/surfaces/site-pages-mjs.mdHistory/2026-11-02.mdSECURITY.mdapps/mobile/PRIVACY.mdscripts/ios-release/support.test.mjssite/README.mdsite/assets/iphone-help.pngsite/assets/iphone-setup.pngsite/assets/provenance.jsonsite/build.mjssite/build.test.mjssite/pages.mjssite/serve.mjssite/style.csssite/workflow.test.mjs
- Context read:
AGENTS.mdCLAUDE.md.github/ISSUE_TEMPLATE/config.yml.github/workflows/site-preview.ymlsite/content.test.mjssite/browser.mjsapps/mobile/app.jsonapps/mobile/package.jsonapps/mobile/app/_layout.tsxapps/mobile/src/local/LocalProvider.tsxapps/mobile/src/local/store.tsapps/mobile/src/local/save.tsapps/mobile/src/local/sqliteStorage.tsapps/mobile/src/local/platformStorage.native.tsapps/mobile/src/local/diagnostics.tsapps/mobile/src/screens/Help.tsxapps/mobile/src/screens/NativeGameScreen.tsxapps/mobile/src/screens/Play.tsxapps/mobile/src/ui/useConfirmation.tsxapps/mobile/src/ui/confirmation.ios.tspackages/game-engine/src/scoring.tspackages/game-engine/src/game.tspackages/game-engine/src/session.tspackages/game-engine/src/storage.tspackages/game-engine/tests/nativePersistence.test.tsdocs/mobile-release-brief.mddocs/mobile-privacy-audit.md
- Verified:
- Compare response
base_commit.shaand final commit SHA match both reserved revisions; inspected the complete textual diff and both added images. - Publication requires main, deployment depends on build, checkout disables persisted credentials, and write permissions are confined to deployment.
- Builder publishes explicitly enumerated static assets; page links and asset references preserve the repository subpath.
- Generated templates contain no scripts, forms, third-party embeds or browser-storage code.
- Mode counts, bonuses and documented combinations agree with
scoring.ts; suggestion descriptions agree withpickAiCategory. - Save acknowledgments, exact-byte retries, reload, corruption handling and reset guidance agree with storage source and inspected regression assertions.
- Five recent names, 500 completed games and ten ranking entries per mode agree with persistence implementation.
- Diagnostics use explicit fields; Help previews them before invoking system sharing, and reset requires confirmation.
- GitHub API reports private vulnerability reporting enabled and Pages configured for workflow deployment with HTTPS enforced.
- Both screenshot contents match their descriptions without visible player information; provenance run and artifact metadata match the recorded source commit.
- Compare response
- Not verified:
- Runtime, rendered accessibility and physical-device behavior remain unverified under the read-only restriction.
- Live publication and unauthenticated destination availability were not checked; Pages configuration alone does not establish successful deployment.
- Screenshot bytes were not compared with the original CI archive, so the unaltered-capture claim remains independently unverified.
- Embedded JavaScript and disabled Expo updates are documented historical package observations; packaged binaries were not independently inspected.
- SQLite backup eligibility, OS offload/uninstall behavior and SDK traffic require platform or device evidence beyond the inspected repository implementation.
- GitHub hosting logs, retention and privacy-rights claims reference external policies that were not retrieved under the GitHub-API-only restriction.
- Tests run: None. Reviewer execution is disabled.
HemSoft full-spectrum review • 3 evidence-based passes • Reviewed head e5689958f157ec1255f84493b45f70023d1409bc • SFL v0
|
Native tablet-10 failed at scenario flow 4: assertVisible Current: .* after the Dice count tap. Artifact 13194752107 retains the recovery record, MCP log and failure screenshot; the screenshot shows the Dice count sheet open with Current: 5 dice and 10 dice available. No state-changing command was replayed. Requesting one fresh hosted tablet job to distinguish an observation/timing failure from a reproducible failure. App source is unchanged by this PR; the failed evidence remains retained. Merge remains blocked until all jobs pass. |
|
@sfl review |
|
Updated to dee3455 by merging main after #99. The only conflict was History/2026-11-02.md; all entries were retained in chronological order. Main release-baseline documents were incorporated unchanged. No app source changed. git diff --check passed; the broad Node suite and candidate checker each reached their local 90-second budget under host load, so neither is reported as a current-head pass. Fresh SFL review was requested once and full CI will requalify this head. The earlier tablet-10 failure artifacts remain retained; no state-changing tap was replayed. |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
✅ Verdict: PASS • Round 3
Since round 2
New: 0; still open (repeated): 0; resolved: 0.
Resolved means no matching finding in this review, not independent proof of a fix.
New (0)
- None.
Still open (repeated) (0)
- None.
Resolved (0)
- None.
Review done by gpt-6.1-sol
The change prepares Third Roll’s public companion site with main-only GitHub Pages deployment, simulator images, and updated support and privacy information. Security, accuracy, and quality passes found no evidenced defects within the static coverage; this supports approval under the stated severity policy, without proving correctness.
🔨 Full-Spectrum Review Summary
Effort: high
Review time: 1m 53s
Token count: Unavailable
| Pass | 🔴 Critical | 🟠 High | 🟡 Medium | ⚪ Low |
|---|---|---|---|---|
| 🔒 Security | 0 | 0 | 0 | 0 |
| ✅ Accuracy | 0 | 0 | 0 | 0 |
| 🧰 Quality & Maintainability | 0 | 0 | 0 | 0 |
| Total | 0 | 0 | 0 | 0 |
Key Findings
No material defects found.
Coverage
- Files reviewed:
.github/ISSUE_TEMPLATE/bug_report.md.github/ISSUE_TEMPLATE/feature_request.md.github/workflows/site-pages.yml.impeccable/surfaces/site-pages-mjs.mdHistory/2026-11-02.mdSECURITY.mdapps/mobile/PRIVACY.mdscripts/ios-release/support.test.mjssite/README.mdsite/assets/iphone-help.pngsite/assets/iphone-setup.pngsite/assets/provenance.jsonsite/build.mjssite/build.test.mjssite/pages.mjssite/serve.mjssite/style.csssite/workflow.test.mjs
- Context read:
AGENTS.md.github/ISSUE_TEMPLATE/config.yml.github/workflows/site-preview.ymlsite/content.test.mjssite/browser.mjssite/contrast.mjsapps/mobile/app.jsonapps/mobile/package.jsonapps/mobile/app/_layout.tsxapps/mobile/app/index.tsxapps/mobile/src/local/LocalProvider.tsxapps/mobile/src/local/diagnostics.tsapps/mobile/src/local/platformStorage.native.tsapps/mobile/src/local/sqliteStorage.tsapps/mobile/src/local/save.tsapps/mobile/src/local/store.tsapps/mobile/src/screens/Help.tsxapps/mobile/src/screens/NativeGameScreen.tsxapps/mobile/src/screens/Setup.tsxpackages/game-engine/src/scoring.tspackages/game-engine/src/session.tspackages/game-engine/src/game.tspackages/game-engine/src/storage.tspackages/game-engine/tests/nativeDiagnostics.test.tspackages/game-engine/tests/nativePersistence.test.tsdocs/mobile-privacy-audit.mddocs/mobile-release-brief.md
- Verified:
- Compare response
base_commit.shamatchesfd85772d238293c58545e2cac116a56cb7525eca; its final commit matchesdee3455df2f4cb2670008edae66c3e485adbfcba. - Inspected all 18 changed paths, including both PNGs, using exact-head GitHub API responses.
- Security: deployment requires
main, depends on the build, and scopespages: writeandid-token: writeto deployment. - Security: checkout disables persisted credentials; publication uploads the generated directory populated by the builder’s explicit asset list.
- Security: page templates and stylesheet use local assets without scripts, forms, analytics clients or browser-storage code.
- GitHub API reports private vulnerability reporting enabled and Pages configured for Actions with HTTPS enforced.
- Accuracy: mode counts, upper targets, bonuses and combination descriptions agree with the scoring implementation.
- Accuracy: recent-name and history limits, per-mode rankings, save acknowledgement, retry and reload descriptions match inspected implementation.
- Accuracy: diagnostics use explicit fields; Help gates sharing behind the preview and confirms local-data deletion.
- Both added images visually show setup or rules without visible player information or played scores.
- Quality: inspected build determinism assertions, overwrite refusal, publication output, preview allowlist and workflow regression assertions.
- Compare response
- Not verified:
- Live Pages delivery, deployed response headers and rendered accessibility were not observed; evidence is limited to source and configuration.
- Screenshot provenance hashes and unaltered-artifact claims were not independently compared with the referenced CI artifact.
- Embedded-bundle and disabled-Expo-updates claims rely on the historical engineering inventory; the compiled artifact was not inspected.
- Signed-device SDK behavior, network traffic, backup, offload, uninstall and restore claims require platform evidence beyond readable source.
- GitHub hosting-log, retention and privacy-rights descriptions were not independently checked against external policy documents under the GitHub-API-only restriction.
- Maintainer handling of support reports and correction requests describes an operational practice that source cannot establish.
- Tests run: None. Reviewer execution is disabled.
HemSoft full-spectrum review • 3 evidence-based passes • Reviewed head dee3455df2f4cb2670008edae66c3e485adbfcba • SFL v0
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Native tablet-8 failed on dee3455 at scenario flow 14. The test tapped the inspected center of score-ones once, then timed out after 15 seconds waiting for points recorded. Artifact 13197209850 retains the MCP log, recovery record, screenshot, hierarchy and failure save. The hierarchy identified score-ones at [360,210][1012,266], yielding tap 686,238; the retained save still has no recorded scores. No tap replay occurred. This is a real failed qualification, not an asserted pass or established runner-only fault. Other native jobs are still running, so GitHub cannot rerun the failed job yet. App-source investigation is being routed to the parent; this writer remains within marketing/docs scope. Merge is also held by the explicit #98 coordination instruction. |
|
The original run is complete on unchanged head dee3455. Phone-5 and tablet-10 passed; tablet-8 failed the single Ones-tap acknowledgment and phone-6 failed device-unreachable. Used the one authorized failed-job rerun for run 41558133101, including the dependent quality-gate. No source, head, flow or timeout changes; original failure artifacts remain retained. No further rerun is authorized by this recovery instruction. The explicit #98 merge hold remains active. |

Publish the existing Third Roll companion site through free GitHub Pages at https://hemsoft-dev.github.io/yahtzee/, with support.html and privacy.html as stable support/privacy URLs. The site previously refused publication and described the public identity, contact route and hosting as undecided.
This keeps the existing design, adds two unaltered privacy-safe simulator screenshots with source hashes, and publishes development-app/hosting privacy information. It preserves an honest prerelease action with no invented App Store link or Apple badge. GitHub private vulnerability reporting is enabled and API-verified; general private support without GitHub remains explicitly unavailable. No personal contact address is published.
Franz explicitly authorized free publication and delegated product calls. I chose GitHub Pages because the repository is public and the host requires no new subscription, domain, service account or application backend. Pages is configured for Actions with HTTPS enforced. The main-only deployment workflow uploads only the generated static directory; PRs never deploy. Repository maintainers own updates and rollback. No app source, App Store Connect, spending or outreach changes.
Refs #49. Live deployment and unauthenticated HTTPS verification must follow merge before closing the issue. The URLs remain deployment targets until that receipt exists. Signed-device/SDK traffic, backup and legal/privacy declaration acceptance remain separate release gates under #48.
Validation: