Skip to content

docs(mobile): establish native release baseline and Xcode profiles - #99

Merged
HemSoft merged 3 commits into
mainfrom
t3/mobile-release-baseline
Nov 3, 2026
Merged

HemSoft merged 3 commits into
mainfrom
t3/mobile-release-baseline

Conversation

@HemSoft

@HemSoft HemSoft commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Change

Refs #40. Record the accepted Third Roll base, Expo native-generation policy, mobile-only version numbering and three local Xcode profiles: Debug development, unsigned Release simulator qualification and unsigned Release device-archive preparation. Link the guide from the existing native qualification instructions and replace the stale identity wording.

Product decision

Use local Xcode and the existing public macOS CI rather than introduce an EAS account or service. The repository already pins the toolchain, deploys the reviewed CocoaPods lock and tests a source-bound simulator artifact. Existing original MIT icon/launch artwork and deterministic capture tooling stay in place. No parallel writer's support, marketing, release records or metadata files change.

Validation

  • Passed: frozen Bun install; all-workspace/backend/tool typecheck; lint; 226 engine/backend tests; 174 Node release/assets/native/capture/workflow tests; five capture-fixture tests; draft release check; security audit; web and desktop production builds; Android and iOS Hermes exports; Expo public configuration resolution; git diff --check.
  • Passed: mutation sensitivity control (strong 100%, deliberately weakened 75%, rejected at the unchanged 95% threshold). The local full mutation run reached its ten-minute limit without a final score and is not passing evidence; its generated sandbox also interfered with a concurrent lint rerun. Source lint passed with that temporary sandbox excluded. Client/function-risk qualification passed separately: all 10 journeys passed; 73 production files, 452 functions, highest CRAP 20.0000, zero gate failures, 185.5 seconds. Required CI will rerun the entire gate.
  • Baseline native run: https://github.com/hemsoft-dev/yahtzee/actions/runs/41523939067 built the simulator app and passed phone-six/tablet-ten; phone-five failed with a Maestro JSON-RPC error and tablet-eight did not acknowledge Start Game. This PR does not claim those failures are resolved. No red check will be bypassed.
  • Documentation-only change: no UI capture required. The Debug and unsigned device-archive commands need their own macOS execution evidence; simulator generation/build has the baseline CI evidence above.

Remaining scope

Native archive automation/inspection belongs to #46. Signing credentials, provisioning, App Store Connect, TestFlight and submission remain outside this preparation. This PR does not close #40 until the documented profile evidence is complete.

@HemSoft HemSoft added the model:gpt-6.1-sol PR authored by gpt-6.1-sol label Nov 2, 2026
Copilot AI lite review requested due to automatic review settings November 2, 2026 23:20
@HemSoft

HemSoft commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator Author

@sfl review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The release documentation still permits archives to use the workstation’s default Xcode instead of the pinned Xcode 26.6, leaving builds non-reproducible.

1 open issue
What changed in this PR

Documents the accepted Third Roll mobile release baseline, native-generation policy, mobile versioning, and local Xcode build profiles.

Changes:

  • Records pinned native tooling, identity, versioning, and generation policies.
  • Adds Debug, unsigned simulator Release, and unsigned device-archive workflows.
  • Links the baseline from native simulator guidance and updates stale identity wording.
  • Review notes request adding the timezone to the history entry and pinning DEVELOPER_DIR for the production-profile command.

This pull request requires changes.

File Description
History/​2026-11-02.md Records the mobile release baseline documentation update.
docs/​native-simulator.md Links the baseline guide and updates Third Roll identity and version wording.
docs/​mobile-release-baseline.md Defines native generation, versioning, identity, Xcode profiles, evidence, and remaining release scope.

Review effort: Lite

Comment thread docs/mobile-release-baseline.md Resolved
@hemsoft-sfl-reviewer

Copy link
Copy Markdown

SFL review stopped: head moved; post a fresh request.

@HemSoft

HemSoft commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator Author

@sfl review

@hemsoft-sfl-reviewer hemsoft-sfl-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Verdict: PASS • Round 1

Review done by claude-opus-5-5 (adversarial to codex)

Documentation-only change that adds a Third Roll native release baseline with three local Xcode profiles, links it from the native qualification guide, and updates that guide's stale identity wording. No defects were evidenced: the checked claims match exact-SHA configuration, runner code, workflow and the cited CI run, so there are no blocking findings.

🔨 Full-Spectrum Review Summary

Effort: high
Review time: 3m 0s
Token count: Unavailable

Pass 🔴 Critical 🟠 High 🟡 Medium ⚪ Low
🔒 Security 0 0 0 0
✅ Accuracy 0 0 0 0
🧰 Quality & Maintainability 0 0 0 0
Total 0 0 0 0

Key Findings

No material defects found.

Coverage

  • Files reviewed:
    • History/2026-11-02.md
    • docs/mobile-release-baseline.md
    • docs/native-simulator.md
  • Context read:
    • AGENTS.md
    • CLAUDE.md
    • package.json
    • .gitignore
    • .github/workflows/quality.yml
    • apps/mobile/app.json
    • apps/mobile/package.json
    • apps/mobile/.gitignore
    • apps/mobile/native/README.md
    • apps/mobile/native/Podfile.lock
    • apps/mobile/release/candidate.json
    • apps/mobile/assets/README.md
    • apps/mobile/assets/provenance.json
    • apps/mobile/APP-STORE.md
    • apps/mobile/CHANGELOG.md
    • docs/mobile-privacy-audit.md
    • docs/mobile-offline.md
    • scripts/ios-native/run.mjs
    • scripts/ios-native/build.mjs
    • scripts/ios-release/check.mjs
    • scripts/ios-release/check.test.mjs
    • scripts/ios-release/tracker.test.mjs
    • History/2026-09-27.md
  • Verified:
    • Compare response returned base_commit.sha 0b01666a84152bfca16dfe3f9e5f80a9bbf32ffe and last commit cd5624972f50e1113fcb763c6975604d78478f0b; status ahead by 2 commits, 3 files.
    • Base commit message is the Third Roll rename (#96), matching the accepted-revision claim.
    • app.json matches the documented name, com.hemsoft.thirdroll, version 1.0.0, build 1, iOS 17.0, tablet support, requireFullScreen: false, automatic appearance, default orientation and thirdroll scheme, and sets no entitlement keys.
    • apps/mobile/package.json pins Expo 57.0.31, React Native 0.86.3 and React 19.2.3, and sets buildFromSource for expo-file-system.
    • run.mjs sets DEVELOPER_DIR to Xcode_26.6 and asserts Xcode 26.6 (17F113), SDK 26.5, Node 24.12.0, Bun 1.4.2 and CocoaPods 1.17.0, which supports the claim that CI pins and verifies tools.
    • build.mjs matches the documented runner sequence: prebuild, lock copy, pod install --deployment, unsigned Release build, identity and main.jsbundle checks, and a retained artifact.
    • The manual profile blocks use the same prebuild, lock copy and pod install --deployment steps as build.mjs; reports/ and apps/mobile/ios/ are git-ignored, and relative output paths resolve to the root reports/.
    • Build job log for run 41523939067 shows ThirdRoll.xcworkspace and scheme ThirdRoll, matching the documented xcodebuild arguments.
    • Run 41523939067 has headSha equal to the base; simulator build, Linux/Windows validation, mutation, phone-6 and tablet-10 succeeded; phone-5, tablet-8 and quality-gate failed, as documented.
    • quality.yml feeds one build artifact into four test groups, and quality-gate requires every job, matching the documented gate.
    • Numbering policy is consistent with APP-STORE.md and check.mjs: candidate records are prepared separately and mismatches fail closed in release mode.
    • Identity wording matches CHANGELOG.md (decided in #39) and publicIdentityApproved in provenance.json; candidate.json keeps bundleIdentifier null.
    • Tree contains no .swift files or eas.json, and contains icon-source.svg, the icon variants and launch-mark.png claimed for #45.
    • tracker.test.mjs assertions on docs/native-simulator.md still match: the Together, the four groups sentence remains and no former-owner URL was added.
    • Relative links in the new guide resolve to paths in the head tree; dev:mobile exists in root package.json.
  • Not verified:
    • Debug and unsigned device-archive commands were not executed; the PR also says they lack macOS evidence, so whether they succeed is unconfirmed, including the Debug build's generic simulator destination without the runner's ARCHS restriction.
    • Generated entitlements from prebuild were not inspected, because apps/mobile/ios is not in the repository; the no-entitlement claim was checked only against app.json.
    • no uncommitted redesign to import cannot be checked for local checkouts through the API; only the committed tree was read.
    • Root causes of the phone-5 and tablet-8 failures were not analyzed; only job conclusions were checked.
    • External pages, including Expo's CNG documentation, were not fetched.
    • PR-body validation claims about local gates and mutation runs were not checked, since they are not repository content.
  • Tests run: None. Reviewer execution is disabled.

HemSoft full-spectrum review • 3 evidence-based passes • Reviewed head cd5624972f50e1113fcb763c6975604d78478f0b • SFL v0

@HemSoft

HemSoft commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator Author

@sfl review

@hemsoft-sfl-reviewer hemsoft-sfl-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Verdict: PASS • Round 2

Since round 1

New: 0; still open (repeated): 0; resolved: 0.
Resolved means no matching finding in this review, not independent proof of a fix.

New (0)

  • None.

Still open (repeated) (0)

  • None.

Resolved (0)

  • None.

Review done by claude-opus-5-5 (adversarial to codex)

This documentation-only change adds a native release baseline with three local Xcode profiles, links it from the simulator guide, updates the identity wording and adds a History entry. The verdict is clean: the static claims checked match exact-ref config, the runner and CI job results, the round 1 DEVELOPER_DIR gap is fixed at this head, and no evidenced defect was found within the stated coverage.

🔨 Full-Spectrum Review Summary

Effort: high
Review time: 2m 3s
Token count: Unavailable

Pass 🔴 Critical 🟠 High 🟡 Medium ⚪ Low
🔒 Security 0 0 0 0
✅ Accuracy 0 0 0 0
🧰 Quality & Maintainability 0 0 0 0
Total 0 0 0 0

Key Findings

No material defects found.

Coverage

  • Files reviewed:
    • History/2026-11-02.md
    • docs/mobile-release-baseline.md
    • docs/native-simulator.md
  • Context read:
    • AGENTS.md
    • CLAUDE.md
    • package.json
    • apps/mobile/app.json
    • apps/mobile/package.json
    • apps/mobile/.gitignore
    • apps/mobile/native/README.md
    • apps/mobile/assets/README.md
    • apps/mobile/assets/provenance.json
    • apps/mobile/release/candidate.json
    • apps/mobile/APP-STORE.md
    • scripts/ios-native/build.mjs
    • scripts/ios-native/run.mjs
    • scripts/ios-release/check.mjs
    • scripts/ios-release/tracker.test.mjs
    • .github/workflows/quality.yml
    • .gitignore
    • convex/lib/rules.ts
    • docs/mobile-offline.md
    • docs/mobile-privacy-audit.md
    • docs/mobile-release-brief.md
  • Verified:
    • Compare base_commit.sha is 74d09ab68b654ad2be6089185d345e20f465aa9b; the last compare commit is 41ef6759d3968e0a7d0fc5accdcf97b06108cf15; ahead 3, behind 0
    • 0b01666a84152bfca16dfe3f9e5f80a9bbf32ffe is the #96 rename commit, and the only commit between it and the reviewed base changes docs and History
    • Run 41523939067 has head 0b01666; build, validation, mutation, phone-6 and tablet-10 succeeded; phone-5, tablet-8 and quality-gate failed, as documented
    • Expo, React Native and React versions, exact native pins and expo-file-system buildFromSource match apps/mobile/package.json
    • Name, bundle ID, scheme, version, build, orientation, appearance, tablet and full-screen settings match apps/mobile/app.json; expo-build-properties sets deployment target 17.0, and build.mjs asserts it in the built app
    • Node, Bun, CocoaPods, Xcode build and SDK pins match the assertions in run.mjs; its env sets the same DEVELOPER_DIR, so the simulator block needs no export
    • Debug and archive prebuild, lock copy and pod install --deployment steps match build.mjs; relative output paths resolve to the ignored root reports/ directory
    • Development and production blocks both export the pinned DEVELOPER_DIR before prebuild, pod install and xcodebuild, resolving the round 1 review comment
    • --build-only compiles Release with CODE_SIGNING_ALLOWED=NO, checks identity and main.jsbundle, and CI reuses that run's artifact across four groups
    • bun run dev:mobile resolves to the mobile package's expo start; apps/mobile/.gitignore ignores generated ios/
    • check.mjs compares candidate version and build with app.json; candidate.json keeps bundleIdentifier null, and the doc says configuration is not store evidence
    • tracker.test.mjs assertions on docs/native-simulator.md target unchanged text: canonical links and the Together, the four groups sentence
    • Icon and launch files plus icon-source.svg exist at the head, and asset docs state original authorship under MIT
    • All new relative doc links point to paths present in the exact-ref tree; issues #45 and #46 exist and are open
  • Not verified:
    • Debug and unsigned device-archive commands were not executed; the document itself says they still need macOS execution evidence
    • Hard-coded ThirdRoll.xcworkspace and scheme name: generated output is not in the repository, so the name is inferred, while build.mjs discovers it dynamically
    • No push, iCloud, Game Center or associated-domain entitlement: checked against app.json and its plugin list only, because generated entitlements are not readable
    • no second rules implementation: only a partial tree listing and the head of convex/lib/rules.ts were inspected; scripts/ios-native/scoring.mjs was not read
    • no uncommitted redesign to import: working-tree state on any workstation cannot be checked through the GitHub API
    • Expo CNG documentation link and upstream Expo behavior were not fetched; only repository sources and GitHub API data were read
    • Current-head CI was still in progress when read and is not used as evidence; the cited baseline run's failure causes were not diagnosed
  • Tests run: None. Reviewer execution is disabled.

HemSoft full-spectrum review • 3 evidence-based passes • Reviewed head 41ef6759d3968e0a7d0fc5accdcf97b06108cf15 • SFL v0

@HemSoft
HemSoft merged commit fd85772 into main Nov 3, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model:gpt-6.1-sol PR authored by gpt-6.1-sol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS 1.0] Establish the mobile release baseline and reproducible native iOS configuration

2 participants