Skip to content

Sync upstream 2fbd4318fc (stage 2: React Compiler rollout) - #202

Merged
henrychu04 merged 324 commits into
coder-onlyfrom
t3code/sync-upstream-2fbd4318fc
Oct 17, 2026
Merged

henrychu04 merged 324 commits into
coder-onlyfrom
t3code/sync-upstream-2fbd4318fc

Conversation

@henrychu04

Copy link
Copy Markdown
Owner

Stage 2 of catching up to upstream 4b1024d: merges upstream through 2fbd431 (322 commits after 33aa461).

Upstream brought

Fork adaptations

  • Files upstream rewrote for the compiler were rebuilt from upstream with the fork's delta replayed. Fork-heavy files keep the fork's version plus the upstream hunks that applied whole; upstream's changes to them were compiler-only.
  • WorkspaceFileSystem keeps the revision-checked edits and create-only files, and adds upstream's KnownWorkspaces check and git-folder refusal to both write paths. Upstream's write-target tests are ported.
  • GitLab: the numeric MR selector's --repo now goes before upstream's --.
  • useFileSaveCoordinator uses upstream's structure, with the fork's revision tracking written so the compiler accepts it.
  • The browser test project is carried and run, as you decided. reactCompilerCoverage skips four fork-only files the compiler bails on.
  • Cut: the desktop update, WSL/SSH/local-backend, preview, usage, OpenCode, and Antigravity pieces upstream touched, plus upstream's credential-migration test.

Verification

  • Passed: every pnpm test:coder suite, including about 6,250 web tests across the unit and browser projects, except the known serverSettings symlink-watcher flake (it passes when run alone).
  • Passed: all typechecks, knip, pnpm build, and vp fmt --check on the changed files.
  • Section 5 checks: no Claude transport or SDK changes and no new RPCs; contract changes are upstream's own.
  • Section 6 checks: fork-delta and upstream-addition lists reviewed; every remaining difference is a listed cut or a memoization restructure.
  • No live Coder smoke run.

🤖 Generated with Claude Code

juliusmarminge and others added 30 commits October 16, 2026 19:09
…otgg#20528)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…otgg#20640)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…identical (pingdotgg#20730)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…pushes (pingdotgg#20731)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…oization (pingdotgg#20723)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…t manual memoization (pingdotgg#20719)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tion (pingdotgg#20716)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…on (pingdotgg#20713)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…oization (pingdotgg#20712)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ation (pingdotgg#20710)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…tion (pingdotgg#20705)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…otgg#20703)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ation (pingdotgg#20701)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ion (pingdotgg#20697)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…g#20696)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge and others added 28 commits October 16, 2026 23:29
…emo" hooks (pingdotgg#20782)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…use memo" hooks (pingdotgg#20781)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…o" (pingdotgg#20769)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…mo" hooks (pingdotgg#20788)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…0791)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ion parsing before names (pingdotgg#20440)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Pixel Perfect <me@pixp.cc>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
…e keyboard (pingdotgg#20803)

Co-authored-by: Pixel Perfect <me@pixp.cc>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
…o" (pingdotgg#20811)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…mo" (pingdotgg#20794)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…memo" (pingdotgg#20820)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…o" (pingdotgg#20799)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…emo" (pingdotgg#20816)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…otgg#20818)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…o" (pingdotgg#20822)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…use memo" (pingdotgg#20824)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…without "use memo" (pingdotgg#20827)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Stage 2 of the 33aa461..4b1024d catch-up: upstream through pingdotgg#20843
(322 commits), the React Compiler rollout across the web app and the
removal of "use memo" directives.

Upstream brought: every web file compiles under the React Compiler with no
manual memoization; web DOM tests move to a headless-Chromium `browser`
Vitest project; KnownWorkspaces and write-target hardening (no writes into
git folders, unknown cwds rejected) (pingdotgg#20449); pull request diff file reads
are limited to files in the change request; `--` ends option parsing for
glab/gh arguments (pingdotgg#20440); background subagents keep T3 tools after the
parent turn (pingdotgg#19751); restart-cut subagent work wakes its thread (pingdotgg#19750);
sidebar crash, settings search, and agents pill fixes.

Resolution:
- Files that upstream rewrote for the compiler were rebuilt from upstream's
  side with the fork's delta replayed hunk by hunk; files that are mostly
  fork code (ChatMarkdown, FilePreviewPanel, MediaActions, HtmlRenderFrame,
  AttachmentFilePreview, assetUrls, useOpenLink) keep the fork's version with
  upstream's whole hunks applied. Their upstream changes are compiler-only.
- WorkspaceFileSystem keeps the fork's revision-checked edits and create-only
  files and adds upstream's KnownWorkspaces check, `path.resolve` root, and
  git-folder refusal to both; upstream's write-target tests are ported.
- GitLabCli's numeric MR selector now puts `--repo` before upstream's `--`.
- useFileSaveCoordinator follows upstream's session-in-state structure with
  the fork's revision tracking held in a closure the compiler accepts.
- The browser test project and @vitest/browser-playwright are carried and
  run (owner's decision); reactCompilerCoverage skips four fork-only files.
- Cut: desktop update, WSL/SSH/local-backend, preview, usage, OpenCode and
  Antigravity pieces upstream touched, and the credential-migration test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants