Skip to content

Merge upstream/main 13aa882c22 into coder-only (stage 3) - #203

Merged
henrychu04 merged 40 commits into
coder-onlyfrom
t3code/sync-upstream-13aa882c22
Oct 17, 2026
Merged

henrychu04 merged 40 commits into
coder-onlyfrom
t3code/sync-upstream-13aa882c22

Conversation

@henrychu04

Copy link
Copy Markdown
Owner

Stage 3 of the upstream catch-up: merges upstream/main 13aa882 (38 commits through pingdotgg#20948) into coder-only. Stages 1 and 2 were #201 and #202.

Upstream brought

Fork decisions

  • V1 screenshots cut (owner decision). Migration 063 is taken verbatim. The fork's LegacyScreenshotArtifacts lookup, workspace.listLegacyScreenshotArtifacts and its timeline row are removed, so imported v1 threads no longer show their saved screenshots, as on upstream.
    • Code that only served that row is also removed: ScreenshotArtifactsRow, CapturedMarkdownImage, ArtifactNavigation, ScreenshotArtifactPreview, and the "artifact" source of workspace.readScreenshotArtifact. That RPC now reads submitted attachments only.
    • Settings → Storage retention can still delete the old copies in $HOME/.t3-coder/artifacts.
  • DatabaseMaintenance.ts removed. It is upstream's t3 doctor backend, which feat(server): t3 doctor can delete the database from before 0.1.0 pingdotgg/t3code#20948 extends, and the fork has no t3 doctor.
  • RightPanelTabs keeps the fork's version; upstream's per-tab memo (perf(web): right panel tabs no longer all re-render on unrelated chat updates pingdotgg/t3code#20853) is not carried.
  • Cut surfaces upstream touched: device setup, load balancing, auth grants, update states, preview-URL action fields, webhook triggers and ACP URL auth.
  • Tests: browser tests for cut surfaces are dropped or trimmed. Fork unit tests that upstream deleted stay, under jsdom.

Verification

  • Tests:
    • Node: gateway, helper and coder-cli tests pass (119).
    • Packages: effect-codex, contracts, providers, source-control, client-runtime, shared:coder and knip-schemas pass.
    • test:web:coder: 393 files / 6201 tests pass, browser project included.
    • test:server: 270/271 files pass. The one failure is the known serverSettings symlink-watcher flake, which differs from run to run; the file passes alone (56/56).
  • Static checks: every typecheck in AGENTS.md, knip:check, pnpm build, and vp fmt --check on the changed files all pass.
  • Sync checklist (section 6):
    • Coder: marker counts: the only drop is MessagesTimeline 7 → 6, the cut legacy row.
    • Upstream-added lines missing from the result are all in cut surfaces, the RightPanelTabs memo, or ChatMarkdown fields the fork lacks.
    • Fork-lost lines were reviewed.
  • Not done: no live Coder smoke run.

🤖 Generated with Claude Code

juliusmarminge and others added 30 commits October 17, 2026 02:00
…hanges (pingdotgg#20819)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ngs row (pingdotgg#20830)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ry result row (pingdotgg#20817)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…g the filter (pingdotgg#20840)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ing (pingdotgg#20838)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…r one port (pingdotgg#20875)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…fig pushes (pingdotgg#20852)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…row (pingdotgg#20854)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…rs identical (pingdotgg#20855)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… changed (pingdotgg#20848)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… updates (pingdotgg#20853)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ole page (pingdotgg#20859)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ome (pingdotgg#20842)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… it (pingdotgg#20891)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…otgg#20892)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… and thread panels (pingdotgg#20823)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…presentation consumers (pingdotgg#20821)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… card and model row (pingdotgg#20851)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…g#20902)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
juliusmarminge and others added 10 commits October 17, 2026 05:55
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…er (pingdotgg#20914)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…y streaming tick (pingdotgg#20860)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Stage 3 of the 33aa461..13aa882 catch-up: upstream through pingdotgg#20948
(38 commits), mostly re-render performance work and the move of every
React test to the headless-Chromium browser project.

Upstream brought: provider status, reconnect, router, settings, and
streaming pushes re-render only the consumers whose values changed
(pingdotgg#20821, pingdotgg#20823, pingdotgg#20848, pingdotgg#20850-pingdotgg#20855, pingdotgg#20860 and others); ChatView's
overlays move to ChatOverlayHosts; a project action's error belongs to the
request that opened it (pingdotgg#20891); migration 063 drops the v1 projections
nothing reads after the v2 upgrade (pingdotgg#20947).

Resolution:
- ChatView, useSettings, ChatMarkdown, SettingsScopeContext, and
  ProviderSettingsPanel were rebuilt from upstream's side with the fork's
  delta replayed; ChatOverlayHosts drops the device setup dialog.
- RightPanelTabs keeps the fork's version; upstream's per-tab memo (pingdotgg#20853)
  is not carried.
- Migration 063 is taken verbatim, so the fork's v1 screenshot lookup
  (LegacyScreenshotArtifacts, `workspace.listLegacyScreenshotArtifacts`,
  and its timeline row) is cut by owner decision. With it go the web
  ScreenshotArtifactsRow, CapturedMarkdownImage, ArtifactNavigation, and
  ScreenshotArtifactPreview, and the "artifact" source of
  `workspace.readScreenshotArtifact`, which now reads submitted attachments
  only.
- DatabaseMaintenance.ts, upstream's `t3 doctor` backend that pingdotgg#20948
  extends, is removed; the fork carries no `t3 doctor`.
- Upstream's moved browser tests are carried; tests for cut surfaces are
  dropped or trimmed, and fork unit tests that upstream deleted stay
  (jsdom and react-test-renderer remain fork devDependencies).
- Cut: device setup, load balancing, auth grants, update states, preview
  URL action fields, webhook triggers, and ACP URL authentication pieces
  upstream touched.
- Coder marker drop: MessagesTimeline (7 -> 6), the cut legacy row.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants