Skip to content

Merge upstream/main e85539ab59 into coder-only - #217

Merged
henrychu04 merged 22 commits into
coder-onlyfrom
t3code/sync-upstream-e85539ab59
Oct 20, 2026
Merged

henrychu04 merged 22 commits into
coder-onlyfrom
t3code/sync-upstream-e85539ab59

Conversation

@henrychu04

Copy link
Copy Markdown
Owner

Stage 3 of 3: merges upstream main at e85539ab59 (20 commits since fb990765a4). This also brings in the fixes from a Fable review of all three stages.

Brings:

Resolution (details in the merge commit):

  • Functions the fork replaced keep their fork bodies under upstream's wrapper.
  • Files touched only by the refactor take upstream's file with the fork's changes replayed.
  • Metrics and the hosted-app, relay, and mobile changes stay cut.

Review fixes:

Verification:

  • Every AGENTS.md typecheck, pnpm knip:check, pnpm build, and vp fmt --check pass.
  • The full test:coder run was green except two known flakes that pass alone: the serverSettings symlink watcher and the localApi hook timeout. The files changed by the review fixes were rerun on their own.
  • No live Coder smoke test was run.

Left for a follow-up (older fork gaps the review found, not caused by this sync):

  • Terminal attach replay can append a new shell session's output to an older cached buffer.
  • Changed-file links resolve repository-relative paths against a subfolder project's root.

🤖 Generated with Claude Code

juliusmarminge and others added 22 commits October 19, 2026 18:30
…#19680)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
)

Co-authored-by: Wout Stiens <71498452+StiensWout@users.noreply.github.com>
…story (pingdotgg#9221)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…15636)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…tgg#11943)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…#13859)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…tgg#12513)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Brings upstream's 20 commits since fb99076: the traced Effect.fn refactor (pingdotgg#21989-pingdotgg#22000),
helper processes no longer outliving the backend (pingdotgg#12513), terminal modes a dead shell leaves
in history reset (pingdotgg#9221), atomic synchronized terminal paint (pingdotgg#9867), and new threads choosing
each repository checkout (pingdotgg#15636).

Resolution:
- Cut: hosted-app empty state (pingdotgg#19680), relay tracing opt-out (pingdotgg#14413), mobile changes, the
  prefer-effect-fn lint rule, and the mobile-only react-native-image-viewing patch.
- Functions the fork replaced keep their fork bodies under upstream's Effect.fn wrapper: the
  Kilo Code, Codex, and Claude driver `create`, ACP registry inspect/resolve, and the ws.ts
  handlers the helper serves. Refactor-only files take upstream's file with the fork delta
  replayed (patch -l), so they match upstream's shape.
- Metrics stay cut where upstream re-wrapped them (OrchestratorMcpService, ScheduledTaskService,
  terminal restarts).

Review fixes (Fable review of the three-stage sync):
- Remove BranchToolbar.tsx.orig, a patch backup committed in the fb99076 merge.
- Carry upstream's webhook span-attribute test, which needs no cut surface.
- server.refreshProviders with refreshModels drops cached latest versions per instance
  (upstream pingdotgg#19580) without the model-manifest refresh the bundled catalog has no use for;
  ws.projects.test stubs the new ProviderLatestVersions dependency.
- Carry upstream's filesystem-root clone test on a GitLab URL.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The seams doc names server.ts's automatic fetch interval layer, and the sync checklist adds
the replay technique for mechanical refactors and a check for stray patch backups.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants