Skip to content
This repository was archived by the owner on Nov 21, 2026. It is now read-only.
This repository was archived by the owner on Nov 21, 2026. It is now read-only.

Turn the #10448 tripwires into plain tests now that main carries the fix #444

Closed

Description

@tae898

The upstream sync (main 77a5777) brought the fix for ArcadeData#10448 (fixed by ArcadeData#10457, closed 2026-10-20, in 26.11.1): SQL = and <> on a list or a map now compare the elements numerically, IN and CONTAINS with a list or map value follow the same rule, and a BY ITEM index is no longer used to answer a whole-list = (the query scans).

The three strict xfail tripwires in bindings/python/tests/test_collection_equality_known_issues.py therefore XPASS and fail the suite, as designed, on a wheel built from synced main: test_a_sql_list_literal_matches_lists_written_from_python, test_a_sql_map_literal_matches_maps_written_from_python and test_a_named_sql_parameter_matches_through_a_by_item_index (3 failed, 1258 passed).

To do: turn the tripwires into plain tests of the fixed behavior, keep the workaround tests passing, and rewrite the Known Engine Issues entry and the other docs that describe the old behavior (fixed in 26.11.1, not released yet). CI builds its wheel from upstream's 26.11.1-SNAPSHOT image, which was last published on 2026-10-19, before the fix, and carries the same version string as the fixed engine, so the plain tests have to tell the two engines apart by behavior.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions