This repository was archived by the owner on Nov 21, 2026. It is now read-only.
Repository navigation
tests: the #10448 tripwires are plain tests now that main carries the fix - #445
Merged
Merged
Conversation
…arries the fix (#444) SQL = and <> on a list or map compare elements numerically on upstream main (ArcadeData#10457, in 26.11.1), so the three strict xfail tripwires pass. They are plain tests of the fixed answer. CI's snapshot image can still hold the engine from before the fix under the same version string, so the file probes the behavior and asserts the old answer on such an engine. The Known Engine Issues entry and the testing page say what changed and which release carries it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
tae898
added a commit
that referenced
this pull request
Oct 24, 2026
…arries the fix (#445) SQL = and <> on a list or map compare elements numerically on upstream main (ArcadeData#10457, in 26.11.1), so the three strict xfail tripwires pass. They are plain tests of the fixed answer. CI's snapshot image can still hold the engine from before the fix under the same version string, so the file probes the behavior and asserts the old answer on such an engine. The Known Engine Issues entry and the testing page say what changed and which release carries it. Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #444
The three strict
xfailtripwires intest_collection_equality_known_issues.pybecome plain tests of the fixed behavior (ArcadeData#10448, fixed by ArcadeData#10457, in 26.11.1): the SQL list literal, the SQL map literal, and the named parameter through aBY ITEMindex. I added two plain tests for the same fix,<>on a list and the list literal through aBY ITEMindex. The two workaround tests (openCypher=, named parameter) are unchanged and pass on every engine.CI builds its wheel from upstream's
26.11.1-SNAPSHOTDocker image, which was last published on 2026-10-19, before the fix (upstream'smvn-deployruns have failed since), and has the same version string as the fixed engine, with no build number in the jar. So a version gate cannot work. The file probes the one behavior that changed (SELECT ([1, 2] = :p)) and asserts the old answer on an engine without the fix, astest_vector_sql.pydoes forwhere. The probe and the old-answer branches go when 26.11.1 is released and the wheel is built from it.Docs: the Known Engine Issues entry now says fixed in 26.11.1 (not released yet), what changed (including that a
BY ITEMindex no longer answers a whole-list=), and keeps the workarounds for 26.10.2 and earlier. The testing page row is updated, and the warning box on three guide pages no longer says "Open ArcadeDB bugs", since the only open entries are in JPype.Tested with
taskset -c 12-15: the file passes (8 passed) on the wheel built from synced main 7f65a6e with the full distribution lib, and on the same wheel with the engine jar swapped for the one inarcadedata/arcadedb:26.11.1-SNAPSHOT(pre-fix).mkdocs build --strictas indocs-build.ymlpasses, andpre-commit run --filespasses on the changed files.🤖 Generated with Claude Code