Skip to content
This repository was archived by the owner on Nov 21, 2026. It is now read-only.

tests: the #10448 tripwires are plain tests now that main carries the fix - #445

Merged
tae898 merged 1 commit into
mainfrom
tests-10448-fixed
Oct 22, 2026
Merged

tae898 merged 1 commit into
mainfrom
tests-10448-fixed

Conversation

@tae898

@tae898 tae898 commented Oct 21, 2026

Copy link
Copy Markdown

Closes #444

The three strict xfail tripwires in test_collection_equality_known_issues.py become plain tests of the fixed behavior (ArcadeData#10448, fixed by ArcadeData#10457, in 26.11.1): the SQL list literal, the SQL map literal, and the named parameter through a BY ITEM index. I added two plain tests for the same fix, <> on a list and the list literal through a BY ITEM index. The two workaround tests (openCypher =, named parameter) are unchanged and pass on every engine.

CI builds its wheel from upstream's 26.11.1-SNAPSHOT Docker image, which was last published on 2026-10-19, before the fix (upstream's mvn-deploy runs have failed since), and has the same version string as the fixed engine, with no build number in the jar. So a version gate cannot work. The file probes the one behavior that changed (SELECT ([1, 2] = :p)) and asserts the old answer on an engine without the fix, as test_vector_sql.py does for where. The probe and the old-answer branches go when 26.11.1 is released and the wheel is built from it.

Docs: the Known Engine Issues entry now says fixed in 26.11.1 (not released yet), what changed (including that a BY ITEM index no longer answers a whole-list =), and keeps the workarounds for 26.10.2 and earlier. The testing page row is updated, and the warning box on three guide pages no longer says "Open ArcadeDB bugs", since the only open entries are in JPype.

Tested with taskset -c 12-15: the file passes (8 passed) on the wheel built from synced main 7f65a6e with the full distribution lib, and on the same wheel with the engine jar swapped for the one in arcadedata/arcadedb:26.11.1-SNAPSHOT (pre-fix). mkdocs build --strict as in docs-build.yml passes, and pre-commit run --files passes on the changed files.

🤖 Generated with Claude Code

…arries the fix (#444)

SQL = and <> on a list or map compare elements numerically on upstream main (ArcadeData#10457, in 26.11.1), so the three strict xfail tripwires pass. They are plain tests of the fixed answer. CI's snapshot image can still hold the engine from before the fix under the same version string, so the file probes the behavior and asserts the old answer on such an engine. The Known Engine Issues entry and the testing page say what changed and which release carries it.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@tae898
tae898 merged commit 5aa2ba1 into main Oct 22, 2026
42 of 44 checks passed
@tae898
tae898 deleted the tests-10448-fixed branch October 22, 2026 00:40
tae898 added a commit that referenced this pull request Oct 24, 2026
…arries the fix (#445)

SQL = and <> on a list or map compare elements numerically on upstream main (ArcadeData#10457, in 26.11.1), so the three strict xfail tripwires pass. They are plain tests of the fixed answer. CI's snapshot image can still hold the engine from before the fix under the same version string, so the file probes the behavior and asserts the old answer on such an engine. The Known Engine Issues entry and the testing page say what changed and which release carries it.

Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Turn the #10448 tripwires into plain tests now that main carries the fix

1 participant