Repository navigation
refactor: use common channel registry - #77
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #77 +/- ##
============================================
- Coverage 59.38% 59.17% -0.21%
+ Complexity 236 230 -6
============================================
Files 80 80
Lines 1199 1188 -11
Branches 34 34
============================================
- Hits 712 703 -9
Misses 460 460
+ Partials 27 25 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
tim-mwangi
approved these changes
Sep 3, 2021
tim-mwangi
reviewed
Sep 3, 2021
| private final Map<String, ManagedChannel> channelMap = new ConcurrentHashMap<>(); | ||
| private volatile boolean isShutdown = false; | ||
|
|
||
| private final org.hypertrace.core.grpcutils.client.GrpcChannelRegistry delegate = |
Contributor
There was a problem hiding this comment.
missed this in the review
Contributor
Author
There was a problem hiding this comment.
what specifically about the style (this was formatted by spotless)? the FQN?
Contributor
There was a problem hiding this comment.
yes. never mind. i see it now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The grpc channel registry was lifted from graphql and made common, and has since been improved to properly wait for shutdown to complete, which is a change we want to propagate back. Using a delegate model to leave the existing shutdown integration and save from changing all consumers.
Testing
Left existing UTs in place