Skip to content

refactor: use common channel registry #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaron-steinfeld merged 1 commit into from
Sep 3, 2021
Merged

refactor: use common channel registry #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 5 additions & 26 deletions ...tils/src/main/java/org/hypertrace/core/graphql/utils/grpc/DefaultGrpcChannelRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,44 +1,23 @@
package org.hypertrace.core.graphql.utils.grpc;

import io.grpc.ManagedChannel;
import io.grpc.ManagedChannelBuilder;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import javax.inject.Inject;
import javax.inject.Singleton;
import org.hypertrace.core.graphql.spi.lifecycle.GraphQlServiceLifecycle;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

@Singleton
class DefaultGrpcChannelRegistry implements GrpcChannelRegistry {
private static final Logger LOG = LoggerFactory.getLogger(DefaultGrpcChannelRegistry.class);
private final Map<String, ManagedChannel> channelMap = new ConcurrentHashMap<>();
private volatile boolean isShutdown = false;

private final org.hypertrace.core.grpcutils.client.GrpcChannelRegistry delegate =

@tim-mwangi tim-mwangi Sep 3, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: style

@tim-mwangi tim-mwangi Sep 3, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed this in the review

@aaron-steinfeld aaron-steinfeld Sep 3, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what specifically about the style (this was formatted by spotless)? the FQN?

@tim-mwangi tim-mwangi Sep 3, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. never mind. i see it now.

new org.hypertrace.core.grpcutils.client.GrpcChannelRegistry();

@Inject
DefaultGrpcChannelRegistry(GraphQlServiceLifecycle serviceLifecycle) {
serviceLifecycle.shutdownCompletion().thenRun(this::shutdown);
serviceLifecycle.shutdownCompletion().thenRun(this.delegate::shutdown);
}

@Override
public ManagedChannel forAddress(String host, int port) {
assert !this.isShutdown;
String channelId = this.getChannelId(host, port);
return this.channelMap.computeIfAbsent(channelId, unused -> this.buildNewChannel(host, port));
}

private ManagedChannel buildNewChannel(String host, int port) {
LOG.info("Creating new channel for {}:{}", host, port);
return ManagedChannelBuilder.forAddress(host, port).usePlaintext().build();
}

private String getChannelId(String host, int port) {
return host + ":" + port;
}

private void shutdown() {
channelMap.values().forEach(ManagedChannel::shutdown);
this.isShutdown = true;
return this.delegate.forPlaintextAddress(host, port);
}
}