Repository navigation
test(lib): support independently enabled optional features - #1513
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (12)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe workflow adds locked test runs for selected feature configurations. Test assertions and compile gates now account for those configurations. Six runner configuration files also reformat trigger arrays without changing their values. ChangesFeature-specific test matrix
Runner trigger formatting
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The changes improve coverage of selected feature configurations without changing runtime behavior or runner triggers; no concrete merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes. Shadow comparisonParsing
|
<!-- entire-trail-link-start --> https://entire.io/gh/jdx/usage/trails/58 <!-- entire-trail-link-end --> ### ⚡ Performance - reduce development debug info by [@jdx](https://github.com/jdx) in [#1525](#1525) ### 🧪 Testing - **(lib)** support independently enabled optional features by [@jdx](https://github.com/jdx) in [#1513](#1513) ### 🛡️ Security - restrict AI replies on Discussions and Issues and note the instant ban by [@jdx](https://github.com/jdx) in [#1522](#1522) ### 🔍 Other Changes - **(entire)** store checkpoints in a private repository by [@jdx](https://github.com/jdx) in [190ff3e](190ff3e) - **(entire)** commit codex session hooks by [@jdx](https://github.com/jdx) in [abee1b8](abee1b8) - **(entire)** commit claude session hooks by [@jdx](https://github.com/jdx) in [364d74e](364d74e) - **(entire)** restore lower-cost trail findings by [@jdx](https://github.com/jdx) in [2f2f991](2f2f991) - limit each contributor to one open draft PR by [@jdx](https://github.com/jdx) in [#1519](#1519) - add hk pre-commit hook by [@jdx](https://github.com/jdx) in [#1523](#1523) - update pr-closer policy by [@jdx](https://github.com/jdx) in [a2608b7](a2608b7) ### 📦️ Dependency Updates - update ubuntu:26.04 docker digest to da6fc2b by [@renovate[bot]](https://github.com/renovate[bot]) in [#1514](#1514) - update jdx/renovate-config action to v1.0.1 by [@renovate[bot]](https://github.com/renovate[bot]) in [#1515](#1515) - update mise tools to latest by [@renovate[bot]](https://github.com/renovate[bot]) in [#1516](#1516) - update dependency communique to latest by [@renovate[bot]](https://github.com/renovate[bot]) in [#1518](#1518) - update dependency aube to latest by [@renovate[bot]](https://github.com/renovate[bot]) in [#1520](#1520) - run go mod tidy on Renovate branches by [@jdx](https://github.com/jdx) in [#1521](#1521) - update module github.com/urfave/cli/v3 to v3.13.0 by [@renovate[bot]](https://github.com/renovate[bot]) in [#1517](#1517) - lock file maintenance by [@renovate[bot]](https://github.com/renovate[bot]) in [#1524](#1524) - update dependency golangci-lint to v2.14.0 by [@renovate[bot]](https://github.com/renovate[bot]) in [#1526](#1526) - update jdx/mise-action action to v5 by [@renovate[bot]](https://github.com/renovate[bot]) in [#1527](#1527)
https://entire.io/gh/jdx/usage/trails/59
Downstream packagers test each optional feature independently. Four configurations failed even though the workspace's all-features tests passed:
usage-argvwith onlycomplete,diagnostics, orspec, andusage-rswith onlytest.Make diagnostics assertions match the enabled renderer, gate advanced-help and completion tests on the features they exercise, and account for
usage-testenabling advanced help transitively. Add separate CI invocations for all four configurations so workspace feature unification cannot mask these failures. Runtime behavior and public APIs are unchanged.This upstreams the two test patches in Debian packaging MR !1447. Debian can remove them when packaging a release containing this change.
Also normalize existing trail-runner JSON formatting to keep the CI formatting step from leaving a dirty checkout; parsed JSON values are unchanged.
Validation: all four affected feature configurations passed, as did both crates with all features and the existing trimmed
static_endpointtests (including both expected-panic tests). Rust formatting, Prettier, actionlint, and diff whitespace checks passed.Note
Low Risk
Changes are limited to tests and CI; runtime behavior and public APIs are unchanged per the PR intent.
Overview
Downstream packagers build optional features in isolation, but workspace
--all-featuresCI was masking failures forusage-argv(complete,diagnostics,spec) andusage-rs(test). This PR adds a dedicated “test library features independently” workflow step and adjusts tests so assertions match whichever renderer/API is actually enabled.Test updates branch on
cfgfeatures: error-message checks expect user-facing diagnostics whendiagnosticsis on andDebug-style text when it is off; advanced-help and completion coverage is limited tohelp-advanced/complete;static_endpointpanic guards treat thetestfeature likehelp-advancedbecauseusage-testenables it transitively..entire/runners/*.jsononly reformatstrigger_typesarrays (no behavior change).Reviewed by Cursor Bugbot for commit 3bfba22. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit