Skip to content

chore(deps): run go mod tidy on Renovate branches - #1521

Merged
jdx merged 1 commit into
mainfrom
fix-renovate-go-mod-tidy
Oct 1, 2026
Merged

jdx merged 1 commit into
mainfrom
fix-renovate-go-mod-tidy

Conversation

@jdx

@jdx jdx commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

https://entire.io/gh/jdx/usage/trails/67

Renovate's Go dependency updates were failing CI on the go-mod-tidy lint step. For example, jdx/usage#1517 (urfave/cli/v3 v3.12.0 → v3.13.0) added the v3.13.0 hashes to benches/go/go.sum but left the v3.12.0 lines behind, so go mod tidy -diff failed and someone had to tidy the branch by hand.

This adds go mod tidy for each Go module (go, benches/go, integrations/cobra, integrations/cobra/example) to the renovate:post-update mise task. mise-lock.yml already runs that task on every Renovate push and commits the result with the generated files, so a Renovate Go bump now gets its tidy go.sum in the same follow-up commit it already receives for aube-lock.yaml and the generators.

There is no change for contributors or for users of the published crates and CLI. I ran the four go -C <module> mod tidy commands on main and they leave the tree unchanged. I have not exercised the workflow on a live Renovate branch, so the next Go bump is the real test.

🤖 Generated with Claude Code


Note

Cursor Bugbot is generating a summary for commit 9d4d3d7. Configure here.

Summary by CodeRabbit

  • Chores
    • Updated the dependency maintenance workflow to refresh Go module metadata before regenerating related project files across the Go components. This keeps dependency update processing consistent and helps ensure generated outputs reflect the refreshed module information. No changes to end-user features or behavior are included.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 2ca16de3-846a-4d5e-a8e5-90c2b1cdc1fa

📥 Commits

Reviewing files that changed from the base of the PR and between c329f5f and 9d4d3d7.

📒 Files selected for processing (1)
  • mise.toml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The renovate:post-update task now runs go mod tidy in four Go modules before running render, gen-shadow, and gen-go sequentially. The task comments describe the tidy step and generator order.

Changes

Renovate post-update task

Layer / File(s) Summary
Tidy Go modules before generation
mise.toml
The task tidies the go, benches/go, integrations/cobra, and integrations/cobra/example modules before running the existing generation commands sequentially. Comments describe Renovate’s go.sum entries and the generator order.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: sahidvelji

Merge Risk: ⚪ Minimal · up to 9d4d3

The added tidying runs in the Renovate update workflow before generation; no concrete merge-blocking risk is evident.

Architecture Summary

Architecture risk: 🔵 Low · up to 9d4d3

The change affects 1 system.

Changed systems: mise.toml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — mise.toml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in mise.toml: The task comments now document tidying each Go module before generation, Renovate’s stale go.sum entries, the generator order, and the conflict from running gen-shadow and gen-go concurrently.
  • observed — Modified behavior in mise.toml: renovate:post-update adds go mod tidy for four Go modules before the existing sequential render, gen-shadow, and gen-go commands.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding go mod tidy to Renovate branch updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adds Go module cleanup to the Renovate automation workflow.

The PR appears safe to merge based on the reviewed changes.

Summary

The PR adds go mod tidy for all four Go modules before the existing Renovate post-update generators, aiming to commit tidy module files with Renovate’s generated-file updates.

Reviews (1) · Last reviewed commit: "chore(deps): tidy go modules on renovate..."

@jdx
jdx enabled auto-merge (squash) October 1, 2026 01:04
@jdx
jdx merged commit aaa991e into main Oct 1, 2026
13 checks passed
@jdx
jdx deleted the fix-renovate-go-mod-tidy branch October 1, 2026 01:08
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Instruction counts

benchmark trend instructions Δ wall (min) Δ
markdown ▃▂▁▃█▆▇▇▆▇▇▇▇▇ 286,027,659 → 286,056,080 +0.01% 49.88 → 50.33ms +0.89%
startup ▆▆███▆▆▆▆▆▆▆▁▇ 1,053,908 → 1,060,731 +0.65% 1.33 → 1.38ms +3.40%

No instruction-count regression above 1%.

Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run.

Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.

Shadow comparison

Parsing mise use -g node@20 against a shadow of mise's committed spec.
Reported, not gated: the shadow grows as the derive learns to express more, so
what to watch is the ratio rather than either column.

framework stripped binary, bytes
usage 1261952
bpaf 2494656
clap 3100904
framework instructions, cold parse vs usage
usage 8530 —
clap 6314977 740x
bpaf 21909298 2568x
                                              min       p01       p10    median
usage-rs: argv -> struct                      768       771       777       812  ns
clap: build tree + parse -> struct        1236981   1241089   1252361   1270005  ns
bpaf: build parser + parse -> struct      3385742   3385742   3487775   3507469  ns

usage: argv -> struct                             763 ns      0.76 µs
clap: build tree + parse -> struct            1259117 ns   1259.12 µs
clap: parse -> struct, tree reused              49405 ns     49.41 µs
clap: build tree only                          746702 ns    746.70 µs

9d4d3d7e7ce3 vs c329f5fad997 · measured on the runner, not pushed to the history.

mise-en-dev added a commit that referenced this pull request Oct 6, 2026
<!-- entire-trail-link-start -->
https://entire.io/gh/jdx/usage/trails/58
<!-- entire-trail-link-end -->

### ⚡ Performance

- reduce development debug info by [@jdx](https://github.com/jdx) in
[#1525](#1525)

### 🧪 Testing

- **(lib)** support independently enabled optional features by
[@jdx](https://github.com/jdx) in
[#1513](#1513)

### 🛡️ Security

- restrict AI replies on Discussions and Issues and note the instant ban
by [@jdx](https://github.com/jdx) in
[#1522](#1522)

### 🔍 Other Changes

- **(entire)** store checkpoints in a private repository by
[@jdx](https://github.com/jdx) in
[190ff3e](190ff3e)
- **(entire)** commit codex session hooks by
[@jdx](https://github.com/jdx) in
[abee1b8](abee1b8)
- **(entire)** commit claude session hooks by
[@jdx](https://github.com/jdx) in
[364d74e](364d74e)
- **(entire)** restore lower-cost trail findings by
[@jdx](https://github.com/jdx) in
[2f2f991](2f2f991)
- limit each contributor to one open draft PR by
[@jdx](https://github.com/jdx) in
[#1519](#1519)
- add hk pre-commit hook by [@jdx](https://github.com/jdx) in
[#1523](#1523)
- update pr-closer policy by [@jdx](https://github.com/jdx) in
[a2608b7](a2608b7)

### 📦️ Dependency Updates

- update ubuntu:26.04 docker digest to da6fc2b by
[@renovate[bot]](https://github.com/renovate[bot]) in
[#1514](#1514)
- update jdx/renovate-config action to v1.0.1 by
[@renovate[bot]](https://github.com/renovate[bot]) in
[#1515](#1515)
- update mise tools to latest by
[@renovate[bot]](https://github.com/renovate[bot]) in
[#1516](#1516)
- update dependency communique to latest by
[@renovate[bot]](https://github.com/renovate[bot]) in
[#1518](#1518)
- update dependency aube to latest by
[@renovate[bot]](https://github.com/renovate[bot]) in
[#1520](#1520)
- run go mod tidy on Renovate branches by [@jdx](https://github.com/jdx)
in [#1521](#1521)
- update module github.com/urfave/cli/v3 to v3.13.0 by
[@renovate[bot]](https://github.com/renovate[bot]) in
[#1517](#1517)
- lock file maintenance by
[@renovate[bot]](https://github.com/renovate[bot]) in
[#1524](#1524)
- update dependency golangci-lint to v2.14.0 by
[@renovate[bot]](https://github.com/renovate[bot]) in
[#1526](#1526)
- update jdx/mise-action action to v5 by
[@renovate[bot]](https://github.com/renovate[bot]) in
[#1527](#1527)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant