Fail-closed timestamps, concat, and Anthropic base_url - #78
Merged
Conversation
Track remaining silent-success bugs after #77: glob-driven timing.json wipes, soft concat, Anthropic base_url, and CLI/wizard no-ops. Co-authored-by: jmjava <jmjava@gmail.com>
Walk segments.all for timing instead of globbing every mp3, raise when listed audio is missing, and stop concat on unknown targets or missing recordings. Anthropic chat honors DOCGEN_AI_BASE_URL / ai.base_url. Manim, compose CLI, and wizard manim/compose/validate/path checks no longer report success on skipped work. Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 7, 2026 17:16
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milestone
timestamps-fail-closed — next iteration after #77.
Timing, concat, Manim, compose CLI, and wizard steps must not report success while dropping stems, muxing a partial concat, or ignoring
ai.base_urlfor Anthropic.Changes
extract_allwalkssegments.allviafind_segment_asset(no*.mp3glob). Missing audio for a listed segment raises; existingtiming.jsonis not rewritten. Orphan01.mp3does not satisfy stem01-intro.ConcatError(CLI Click error). Empty concat map remains a no-op.{DOCGEN_AI_BASE_URL or ai.base_url}/v1/messages.renderraises whenscenes.pyor the manim binary is missing.repo_rootescapes; manim/compose/validate fail closed.Tests
ruff check src/ tests/green.pytest tests/— 501 passed, 1 skipped.No clock /
_TimedScene/ compile changes;docgen benchmarknot required for this PR.