Fail closed when timing.json is corrupt at compile and validate - #89
Merged
Conversation
Load the bundle timing file in one place: missing is empty, garbage JSON or a non-object root is an error. Scene-compile, validate, and wizard timestamps no longer treat a broken file as empty words. Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
September 7, 2026 19:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Wizard timestamps already refuse to overwrite a corrupt
timing.json. Scene-compile and validate still swallowed decode errors and treated the file as missing words. Paced compile then said “run timestamps”;pace: nonespecs compiled as if there were no timing file.Change
load_bundle_timingis the single loader:{}TimestampError/SceneGenerationErrorUsed by scene-compile, validate (
timing_sync/story_end/av_sync),scene_asset_validate, and wizard timestamps.Milestone:
milestones/timing-json-parse.mdOut of scope
segments.allstill leavestiming.jsonunchanged (Fail-closed timestamps, concat, and Anthropic base_url #78)timing.jsonstill means empty words (paced compile already fails)Testing
Local:
ruff check src/ tests/— cleanpytest tests/— 566 passed, 1 skippeddocgen benchmark— meetssrc/docgen/benchmark_data/baseline.json(no clock change)CI on this branch is the merge gate.