✨ Introduce v1alpha2 version with APIResourceSchema object and conversion CLI tool#248
Merged
mjudeikis merged 8 commits intoMay 6, 2025
Merged
Conversation
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
cnvergence
force-pushed
the
introduce-api-resource-schema
branch
from
March 28, 2025 15:50
f5f3c48 to
b5a883c
Compare
cnvergence
changed the title
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
cnvergence
marked this pull request as ready for review
April 22, 2025 13:33
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com> On-behalf-of: @SAP karol.szwaj@sap.com
Member
Author
|
ptal @mjudeikis and let me know wdyt |
Contributor
|
This is on my review list for weekend! I'm pto today :) |
Member
Author
|
@mjudeikis I know! No worries |
mjudeikis
requested changes
Apr 27, 2025
mjudeikis
left a comment
mjudeikis
left a comment
Contributor
There was a problem hiding this comment.
Main issue - tool writing back to cluster. We should make it optional at least.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new v1alpha2 API version that defines the APIResourceSchema object and implements a conversion CLI tool (crd2apiresourceschema) to convert CRDs to APIResourceSchemas. Key changes include:
- Adding the v1alpha2 client-side implementations (including fake clients and scheme registrations).
- Creating the new API types and CRD definitions for APIResourceSchema.
- Implementing the conversion CLI tool along with supporting command and plugin logic.
Reviewed Changes
Copilot reviewed 41 out of 41 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/client/clientset/versioned/... | Adds v1alpha2 client implementations and registers the new API types. |
| sdk/apis/kubebind/v1alpha2/... | Introduces the new API types, deep copy functions, and registration for the APIResourceSchema. |
| deploy/crd/... | Provides CRD manifests for APIResourceSchema and APIConversion. |
| cli/pkg/crd2apiresourceschema/plugin/... | Implements the conversion logic and in-cluster creation for APIResourceSchemas. |
| cli/cmd/crd2apiresourceschema/... | Adds CLI command definitions and wiring for the new conversion tool. |
Contributor
|
In general, it looks good. Let's give a day or so if @sttts wants to pitch in. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mjudeikis
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Starting on v1alpha2 API version, introducing APIResourceSchema object.
Including
crd2apiresourceschematool that will convert CRDs from the cluster to APIResourceSchemas.Related issue(s)
Fixes #245
Release Notes