Skip to content

add context flag to backend and konnector#480

Merged
mjudeikis merged 1 commit into
kbind-dev:mainfrom
olamilekan000:add-context-flag
Feb 25, 2026
Merged

add context flag to backend and konnector#480
mjudeikis merged 1 commit into
kbind-dev:mainfrom
olamilekan000:add-context-flag

Conversation

@olamilekan000

Copy link
Copy Markdown
Contributor

Summary

change adds context flag to backend and konnector

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes 479

Release Notes

Added context flag to backend and konnector

@olamilekan000
olamilekan000 requested a review from a team as a code owner February 24, 2026 23:44

@mjudeikis-bot mjudeikis-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean, correct implementation.

The nil-guard on overrides is fine — passing nil vs &clientcmd.ConfigOverrides{CurrentContext: ""} are both equivalent (no context override), but the explicit nil check makes intent clearer.

Passing &clientcmd.ConfigOverrides{CurrentContext: options.Context} unconditionally would also work and simplify the code slightly, but this is a nit — the current approach is readable.

Flag name --context matches kubectl convention. ✅
Change is symmetric between backend and konnector. ✅

@mjudeikis
mjudeikis merged commit d2211f6 into kbind-dev:main Feb 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add --context flag to backend and konnector

3 participants