Repository navigation
Fix Windows ROCm builds failing to find mt.exe + stop one ROCm version cancelling the others - #37
Merged
Merged
Conversation
…d stop one ROCm version cancelling the others
… check that it starts
This was referenced Nov 3, 2026
superm1
approved these changes
Nov 3, 2026
superm1
left a comment
Member
There was a problem hiding this comment.
I don't have concerns with this direction of changes but I would suggest straight cherry picks from upstream.
Collaborator
Author
Thanks @superm1! Agreed that cherry-picking from upstream is the better default. There's nothing upstream to pick for this one though.
Both changes only make sense in this fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Windows ROCm builds have failed on every run since b12013 (Oct 30), and because of that no ROCm build has been released since, Linux included.
.exe(ggml-org/llama.cpp#31329). To do that, ROCm's linker needs Microsoft'smt.exe.mt.exeis installed on the runner (it comes with the Windows SDK), but ourwindows-rocmjob never puts it onPATH, so every.exefails to link withlld-link: error: unable to find mt.exe in PATH.ggml-hipDLL, never an.exe.b12013tob12062have no ROCm archives.Fix
windows-rocmBuild step: find the newest Windows SDK folder that hasmt.exeand add it to the end ofPATHfor that step only, then runmt.exe /?so a brokenmt.exefails with a clear message instead of a link error.windows-rocmandubuntu-24-rocm: addfail-fast: false.release.ymlalready does this.Notes
mt.exefix is the same as Put mt.exe on PATH for Windows ROCm builds #36's first commit (87440cb7f), which passed all three Windows ROCm builds and every Tier 0 / Tier 1 check in run 41535886862. Credit to @sawansri for the diagnosis and for finding thatmt.execan't be copied out on its own (it needs the rest of its SDK folder).PATH, which is more than this fix needs..exes).windows-rocmjobs should be green, and Tier 0 / Tier 1 should pass on the Windows archives.ubuntu-22-openvinostill fails for an unrelated reason (upstream's OpenVINO backend vs our pinned OpenVINO 2026.0), tracked in (fix): OpenVINO nightly build, verify sm_121, CMake-options check #33.