Repository navigation
Qualification feed v2: rows for failed builds, correct version_qualified, no dead release links - #38
Merged
Conversation
…lified, and link only attached files in release notes
Collaborator
Author
|
@ramkrishna2910, merging this PR since I own the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the ROCm qualification feed so it matches what actually ships, and stops the release notes from linking files that don't exist.
Right now the feed looks green while nothing ROCm ships. Since
b12013the Windows ROCm builds have failed every night, which drops each ROCm version, Linux included. But failed builds get no row, andversion_qualifiedignores missing archives, so the feed shows three passing Linux rows per run.Changes
aggregate.pyversion_qualifiedisfalsewhen the other half of the pair is missing.overall: "fail".release.ymlROCM_VERSIONSlist for the expected archives.release.ymlrelease.ymlactions: read), and builds the records itself if the release job stopped before writing them.publish_qualification.py: every expected archive gets a row; a failed build gets a placeholder row that says so. New fields:published: did this run ship the archive;build_result: how its build job ended;tier0/tier1: each tier's result;not_applicable: for checks that were never going to run, somissingnow only means "should have run and didn't".publish_qualification.py: runs are ordered byrun_id, andrun_attemptis the attempt that published the rows. A re-run of an old run no longer jumps to the top of the feed or overwriteslatest/.FEED.mdandREADME.md: updated to match, with real pass and fail examples and a section on how this feed differs from lemonade-sdk/llamacpp-rocm's.Notes
schema_version: 2. The first publish after merge starts a freshindex.json,reports/andlatest/; the old v1 data stays in the branch's git history.