Repository navigation
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: lidge-jun/opencodex/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe Claude quota parser now sanitizes model display names and accepts only recognized model families. New provider tests verify unsafe labels are omitted and recognized labels produce sanitized quota windows. Test-layout configuration registers the new test file. ChangesClaude quota label sanitization
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The change prevents terminal-control residue from appearing in Claude quota labels while preserving recognized model labels. The supplied coverage shows no remaining merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
리뷰 · 우선순위 62 / 80Anthropic 사용량 응답의 모델 이름( src/providers/quota/vendor-probes-oauth.ts tests/providers/provider-quota-label-sanitize.test.ts - 위 찌꺼기 문자열을 성공 조건으로 고정합니다. 나중에 모르는 이름을 버리거나 안전한 이름으로 바꿔도, 이 테스트가 지금의 찌꺼기를 정답으로 붙잡습니다. 메인테이너의 판단이 필요한 지점 너의 추천 이 댓글은 grok-bot이 작성했습니다 |
Per review on lidge-jun#5463: stripping terminal control characters still left attacker-chosen residue on the quota line. parseClaudeLimit now returns null unless the name reduces to a recognized model (Fable, Opus, Sonnet); the test asserts the residue is not emitted and adds a recognized-name positive case.
|
Review feedback applied on
Tests: |
|
Consolidated into #5538 as a single related-function aggregate. Source head: Both unique source commits, including the review follow-up, match carried commits by stable Git patch ID. All affected runtime and test files match the source head exactly at the replacement head; merge-only source commits have no additional combined diff. The combined changed-file run passed 85 tests / 376 assertions; typecheck, structure, privacy and standalone size-ratchet checks passed. Full suite, hosted cross-platform CI and independent review remain pending. Closing this duplicate standalone review entry at the author's request after verifying migration. This is not a merge or release claim; remaining integration checks and reviews are tracked on the draft replacement. Original branches are retained. |
…c and config output (#5573) * fix(lab): combine host-redaction hardening for socket markers and connect-to failures Combines three fork PRs into one change on current dev: bare destinations after resolver/socket markers are redacted only where grammar proves the position (sole argument or after 'lookup'), connect-to failures redact the bare target when a failure term follows, and rewrites splice at the tail offset so a marker word that repeats the destination cannot take the [host] itself. bun test tests/lab/lab-evidence-sanitization.test.ts: 31 pass (cherry picked from commit 69990d9) Source: #5538 commit b90139f Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(lab): redact socket destinations carrying a sentence-final period Classify the token without its trailing period and leave the period outside the mask: ECONNREFUSED redis. -> ECONNREFUSED [host]. Previously the punctuation defeated host classification and leaked the destination. (cherry picked from commit a74038c) Source: #5538 commit d8042a5 Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(config): avoid logging operator-supplied credential/group identifiers in credentialGroups diagnostics (cherry picked from commit 0354bd9) Source: #5538 commit fc57a55 Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(config): align comments with indexed messages and cover every issue shape (cherry picked from commit f8a67b3) Source: #5538 commit 038c0fa Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(cli): redact proxy credentials in config output (cherry picked from commit 73946f3) Source: #5538 commit b31732a Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(cli): keep non-secret proxy values readable in config output Mask only credential-bearing proxy URLs (userinfo stripped via redactUrlForLog, host/port kept); direct and credential-less values print unchanged. Clarify that config export stays raw for restore. (cherry picked from commit acdbb1c) Source: #5538 commit dc4d273 Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(quota): sanitize Anthropic quota labels (cherry picked from commit ee716bf) Source: #5538 commit 4a04458 Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(quota): drop unrecognized Anthropic display_name from quota labels Per review on #5463: stripping terminal control characters still left attacker-chosen residue on the quota line. parseClaudeLimit now returns null unless the name reduces to a recognized model (Fable, Opus, Sonnet); the test asserts the residue is not emitted and adds a recognized-name positive case. (cherry picked from commit a9a6bac) Source: #5538 commit aaffe75 Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * docs(providers): state canonical quota label boundary Source: #5538 commit 62c677c Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(diagnostics): preserve redaction across path aliases and resolver prose Use normalized config keys for get and mutation output. Preserve direct resolver destinations when explanatory text follows, while retaining socket prose exclusions. Add focused regressions and align output contracts. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * docs(structure): keep runtime doc within its line budget --------- Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> Co-authored-by: Epinephrine <luvs01@hanmail.net>
Motivation
Description
Testing
Summary by CodeRabbit
Bug Fixes
Tests