Repository navigation
Conversation
…nect-to failures Combines three fork PRs into one change on current dev: bare destinations after resolver/socket markers are redacted only where grammar proves the position (sole argument or after 'lookup'), connect-to failures redact the bare target when a failure term follows, and rewrites splice at the tail offset so a marker word that repeats the destination cannot take the [host] itself. bun test tests/lab/lab-evidence-sanitization.test.ts: 31 pass (cherry picked from commit 69990d9)
Classify the token without its trailing period and leave the period outside the mask: ECONNREFUSED redis. -> ECONNREFUSED [host]. Previously the punctuation defeated host classification and leaked the destination. (cherry picked from commit a74038c)
…iers in credentialGroups diagnostics (cherry picked from commit 0354bd9)
…ue shape (cherry picked from commit f8a67b3)
(cherry picked from commit 73946f3)
Mask only credential-bearing proxy URLs (userinfo stripped via redactUrlForLog, host/port kept); direct and credential-less values print unchanged. Clarify that config export stays raw for restore. (cherry picked from commit acdbb1c)
(cherry picked from commit ee716bf)
Per review on #5463: stripping terminal control characters still left attacker-chosen residue on the quota line. parseClaudeLimit now returns null unless the name reduces to a recognized model (Fable, Opus, Sonnet); the test asserts the residue is not emitted and adds a recognized-name positive case. (cherry picked from commit a9a6bac)
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
리뷰 · 우선순위 46 / 80이 PR은 진단·설정 출력에 남을 수 있는 민감 정보를 네 갈래로 한꺼번에 줄입니다. Lab 증거 문장에서는 소켓·해석 오류 뒤의 호스트만 src/providers/quota/vendor-probes-oauth.ts:parseClaudeLimit - 모델 이름은 src/cli/config-command.ts:redact(proxy) - 인증 있는 프록시는 src/routing/identity-domains.ts:credentialGroupIssues - 경고가 src/lab/artifacts/sanitize.ts - 메인테이너의 판단이 필요한 지점 너의 추천 이 댓글은 grok-bot이 작성했습니다 |
|
✅ Deterministic PR hygiene checks passed. |
…c and config output (#5573) * fix(lab): combine host-redaction hardening for socket markers and connect-to failures Combines three fork PRs into one change on current dev: bare destinations after resolver/socket markers are redacted only where grammar proves the position (sole argument or after 'lookup'), connect-to failures redact the bare target when a failure term follows, and rewrites splice at the tail offset so a marker word that repeats the destination cannot take the [host] itself. bun test tests/lab/lab-evidence-sanitization.test.ts: 31 pass (cherry picked from commit 69990d9) Source: #5538 commit b90139f Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(lab): redact socket destinations carrying a sentence-final period Classify the token without its trailing period and leave the period outside the mask: ECONNREFUSED redis. -> ECONNREFUSED [host]. Previously the punctuation defeated host classification and leaked the destination. (cherry picked from commit a74038c) Source: #5538 commit d8042a5 Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(config): avoid logging operator-supplied credential/group identifiers in credentialGroups diagnostics (cherry picked from commit 0354bd9) Source: #5538 commit fc57a55 Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(config): align comments with indexed messages and cover every issue shape (cherry picked from commit f8a67b3) Source: #5538 commit 038c0fa Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(cli): redact proxy credentials in config output (cherry picked from commit 73946f3) Source: #5538 commit b31732a Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(cli): keep non-secret proxy values readable in config output Mask only credential-bearing proxy URLs (userinfo stripped via redactUrlForLog, host/port kept); direct and credential-less values print unchanged. Clarify that config export stays raw for restore. (cherry picked from commit acdbb1c) Source: #5538 commit dc4d273 Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(quota): sanitize Anthropic quota labels (cherry picked from commit ee716bf) Source: #5538 commit 4a04458 Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(quota): drop unrecognized Anthropic display_name from quota labels Per review on #5463: stripping terminal control characters still left attacker-chosen residue on the quota line. parseClaudeLimit now returns null unless the name reduces to a recognized model (Fable, Opus, Sonnet); the test asserts the residue is not emitted and adds a recognized-name positive case. (cherry picked from commit a9a6bac) Source: #5538 commit aaffe75 Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * docs(providers): state canonical quota label boundary Source: #5538 commit 62c677c Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * fix(diagnostics): preserve redaction across path aliases and resolver prose Use normalized config keys for get and mutation output. Preserve direct resolver destinations when explanatory text follows, while retaining socket prose exclusions. Add focused regressions and align output contracts. Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> * docs(structure): keep runtime doc within its line budget --------- Co-authored-by: luvs01 <27862058+luvs01@users.noreply.github.com> Co-authored-by: Epinephrine <luvs01@hanmail.net>
|
Landed in #5573 (squash d30d120), thank you @luvs01. Every commit from this PR was carried onto current The carry also adds two small repairs found in review: |
Summary
Consolidate #5475, #5427, #5414, and #5463 into one diagnostic-output privacy change, preserving all eight original contribution and review-follow-up commits.
Update the corresponding runtime contracts. This changes diagnostic rendering and validation messages; it does not broaden authentication or alter routing decisions. No GUI change.
Verification
a5e8047b5e2b6248b1e85a08dfcc5b1c414c6236. Final head:62c677c05d880a5c231bb4efd35b7f8bb637d16f.bun scripts/test.ts --changed=a5e8047b5e2b6248b1e85a08dfcc5b1c414c6236with explicit identity-domain, Lab sanitizer, degraded-config, CLI config, and quota-label test files: 85 passed, 0 failed, 376 assertions. The existing GUI dependencies were checked before invoking the wrapper; no dependency installation occurred.bun scripts/file-size-ratchet.tscompleted successfully with no offenders. No source timeout, file-size limit, or baseline was changed.bun run typecheck,bun run structure:check,bun run privacy:scan, andgit diff --checkpassed. The final documentation-only follow-up passed structure and whitespace checks again.Checklist