Repository navigation
perf(chat): avoid rescanning fragmented SSE carry - #7497
Platinum-Scripts wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
…#7497, #7498) (#7541) * perf(chat): avoid rescanning fragmented SSE carry Co-authored-by: Platinum-Scripts <133908028+Platinum-Scripts@users.noreply.github.com> * perf(chat): retain carry fast path within file-size cap Co-authored-by: Platinum-Scripts <133908028+Platinum-Scripts@users.noreply.github.com> * perf(sse): avoid flattening fragmented block carry Co-authored-by: Platinum-Scripts <133908028+Platinum-Scripts@users.noreply.github.com> * fix(sse): keep block-buffer boundary state in step with the carry Record the cached final code unit and scan eligibility as soon as the fragment joins the buffer, before the budget commit, so a throwing commit cannot leave them describing an older carry. Co-authored-by: Platinum-Scripts <133908028+Platinum-Scripts@users.noreply.github.com> --------- Co-authored-by: StreamClash Dev <dev@streamclash.local> Co-authored-by: Platinum-Scripts <133908028+Platinum-Scripts@users.noreply.github.com>
|
Triage note (2026-10-24, against Superseded: already integrated through #7541 / Still needed on dev: no. Carried by #7541 / Exact-head CI at triage time: A maintainer will decide on closing this; no action needed from you. |
|
Closing as superseded: this change landed on |
Summary
Verification
79fa3506628da65bcd599a2890f13d1cbb4a2f20. Baseline and patched adapter files each match the measured versions byte for byte.bun run typecheck,bun run structure:check,bun run privacy:scan, andgit diff --checkpassed.bun scripts/test.tsfinished with exit 1: parallel lane 50,612 pass / 129 skip / 2 fail; serial lanes completed. One failure was the adapter file-size cap, corrected without raising the cap. The other,connected Desktop uses hub IDs across a cold restart (stored profile=false), reproduces in isolation on untouched upstream dev at the same base. Final focused run: 49 pass / 1 baseline failure across adapter, ratchet, and Desktop files; typecheck passed. Final import-connected graph passed:bun scripts/test.ts --changed=79fa3506628da65bcd599a2890f13d1cbb4a2f20, 21,514 pass / 34 skip / zero failures across 914 files. This draft does not attest to a passing full suite.Checklist
Review readiness
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.