Repository navigation
fix(meta): preserve destinations when refreshing saved model rosters - #7735
Conversation
Integrate the original Meta Model API seed migration with current dev while retaining the Moonshot K3.1 roster and regression coverage. Restrict the Meta refresh to its Model API destination and document saved-configuration preservation. Source-only preparation: runtime tests, typecheck, scanners, and documentation build have not been run. Co-authored-by: Epinephrine <luvs01@hanmail.net>
Join existing paragraph lines without changing words or policy. The provider structure document remains within its 600-line budget.
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Roster repair and validation src/providers/stale-model-roster-migration.ts, tests/providers/model-roster-seed-repair.test.ts, docs-site/src/content/docs/guides/providers.md, structure/providers-and-adapters.md |
The migration replaces the untouched two-Spark roster with the current API roster for eligible destinations. Tests cover edited rosters, custom destinations, preserved metadata, and repeat startup repair. The provider guide and preset notes describe the migration rules. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Possibly related PRs
- lidge-jun/opencodex#7695: Adds a Moonshot saved-roster migration using the same migration mechanism and test file.
Merge Risk: 
Minimal · up to 965e4
-
The reviewed migration has no identified issue that needs resolution before merging.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (2 skipped: 2 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
✅ Deterministic PR hygiene checks passed. |
|
Maintainer dev integration record (release 2.93 dev-merge loop), per the MAINTAINERS.md maintainer-integration exception for dev. This is maintainer integration, not an approving review.
|
Summary
Existing Meta Model API profiles can retain the older two-Spark model list after the catalog adds Muse Wonder. Refresh an untouched saved seed during startup so those profiles receive the current roster.
Apply the migration only to the registry's Model API destination. Preserve custom gateways, user-edited model lists, existing context-window values and output limits; repeated startup remains idempotent. The integration retains the current Moonshot/Kimi migration and its regression coverage, and documents the saved-profile behavior.
Verification
model-roster-seed-repair.test.tspassed 28 tests / 190 assertions, and focused startup-persistence/idempotence coverage passed 28 tests / 84 assertions.--noEmit, privacy, file-size and diff checks passed. The structure document was rewrapped without changing its text to retain the existing 600-line budget, and the final structure check passed.Exact-head CI 40246765762 passed, including fresh documentation dependencies and the documentation-site build. The full local suite was not repeated because concurrent Windows worktrees share the validation host. Focused checks cover roster migration and its startup persistence callers; the hosted Ubuntu checks provide the broader coverage. The full hosted Windows/macOS matrix was not run for this configuration migration.
No live configuration, provider request or installed service was changed.
Checklist
Summary by CodeRabbit