Skip to content

fix(meta): preserve destinations when refreshing saved model rosters - #7735

Merged
lidge-jun merged 3 commits into
lidge-jun:devfrom
luvs01:fix/meta-roster-destination-20261026
Oct 26, 2026
Merged

lidge-jun merged 3 commits into
lidge-jun:devfrom
luvs01:fix/meta-roster-destination-20261026

Conversation

@luvs01

@luvs01 luvs01 commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Existing Meta Model API profiles can retain the older two-Spark model list after the catalog adds Muse Wonder. Refresh an untouched saved seed during startup so those profiles receive the current roster.

Apply the migration only to the registry's Model API destination. Preserve custom gateways, user-edited model lists, existing context-window values and output limits; repeated startup remains idempotent. The integration retains the current Moonshot/Kimi migration and its regression coverage, and documents the saved-profile behavior.

Verification

  • Independent source review confirmed the two-parent integration and found no concrete regression in destination matching, metadata preservation or repeated application.
  • Official Windows Bun 1.4.4: model-roster-seed-repair.test.ts passed 28 tests / 190 assertions, and focused startup-persistence/idempotence coverage passed 28 tests / 84 assertions.
  • A separate actual-module counterfactual passed 1 test / 13 assertions: removing only the destination guard in memory changes a Custom row's model roster; restoring the guard preserves the row. The URL string remains unchanged in both cases. This is not a verbatim execution of the original branch.
  • TypeScript --noEmit, privacy, file-size and diff checks passed. The structure document was rewrapped without changing its text to retain the existing 600-line budget, and the final structure check passed.
  • Runtime code and test inputs are unchanged between the tested integration commit and its documentation-only follow-up. Real repository preload/home protection, terminal exits, both output streams, child cleanup and isolated fixture cleanup were verified. The original nonzero structure result is retained separately.

Exact-head CI 40246765762 passed, including fresh documentation dependencies and the documentation-site build. The full local suite was not repeated because concurrent Windows worktrees share the validation host. Focused checks cover roster migration and its startup persistence callers; the hosted Ubuntu checks provide the broader coverage. The full hosted Windows/macOS matrix was not run for this configuration migration.

No live configuration, provider request or installed service was changed.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Summary by CodeRabbit

  • Bug Fixes
    • Untouched Meta model lists using the standard endpoint now include Muse Wonder after startup. Existing custom endpoints, edited model lists, saved context-window values, and output limits are preserved.
  • Documentation
    • Updated provider guidance to describe when the Meta model list is refreshed and how existing settings are handled.

Integrate the original Meta Model API seed migration with current dev while retaining the Moonshot K3.1 roster and regression coverage. Restrict the Meta refresh to its Model API destination and document saved-configuration preservation.

Source-only preparation: runtime tests, typecheck, scanners, and documentation build have not been run.

Co-authored-by: Epinephrine <luvs01@hanmail.net>
Join existing paragraph lines without changing words or policy. The provider structure document remains within its 600-line budget.
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 8ebe46b and 965e4d9.

Files selected for processing: 4
  • docs-site/src/content/docs/guides/providers.md
  • src/providers/stale-model-roster-migration.ts
  • structure/providers-and-adapters.md
  • tests/providers/model-roster-seed-repair.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The startup migration now refreshes an untouched saved meta-model roster for the registry default or canonical Meta API endpoint. It adds Muse Wonder’s context window when a context-window map exists and preserves saved customizations.

Changes: Meta roster migration

Layer / File(s) Summary
Roster repair and validation
src/providers/stale-model-roster-migration.ts, tests/providers/model-roster-seed-repair.test.ts, docs-site/src/content/docs/guides/providers.md, structure/providers-and-adapters.md
The migration replaces the untouched two-Spark roster with the current API roster for eligible destinations. Tests cover edited rosters, custom destinations, preserved metadata, and repeat startup repair. The provider guide and preset notes describe the migration rules.

Priority: Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

Merge Risk: Minimal · up to 965e4

The reviewed migration has no identified issue that needs resolution before merging.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (2 skipped: 2 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately describes the main change: the migration refreshes saved Meta model rosters while preserving custom destinations and edited configurations. It is concise and specific.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (2 skipped: 2 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Oct 25, 2026
@luvs01
luvs01 marked this pull request as ready for review October 26, 2026 00:48
@lidge-jun

Copy link
Copy Markdown
Owner

Maintainer dev integration record (release 2.93 dev-merge loop), per the MAINTAINERS.md maintainer-integration exception for dev. This is maintainer integration, not an approving review.

  • Exact head: 965e4d9; no change requests; 0 unresolved review threads.
  • Required CI on the exact head: CI run 40246765762 (ci, gates, test 1/4–4/4: success), enforce-target 40251289005: success, hygiene 40251289050: success.
  • Independent technical review (separate agent, read-only) of this head merged onto origin/dev ea48448: verdict MERGE, 0 blocking findings. Destination matching, edited-roster preservation, metadata overrides and startup idempotence checked. Combined tree: typecheck, structure:check, ratchet, privacy:scan, docs-site build pass; bun test --isolate roster seed repair, rename migration, startup reconcile resilience, layout guards and route registry: 135 pass / 1 skip (hosted-CI-only) / 0 fail.

@lidge-jun
lidge-jun merged commit 14fa422 into lidge-jun:dev Oct 26, 2026
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants