Skip to content

fix(azure): omit unsupported Responses encrypted output include - #7953

Closed
x3M3x wants to merge 1 commit into
lidge-jun:devfrom
x3M3x:codex/azure-responses-encrypted-include
Closed

x3M3x wants to merge 1 commit into
lidge-jun:devfrom
x3M3x:codex/azure-responses-encrypted-include

Conversation

@x3M3x

@x3M3x x3M3x commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Fix Azure Responses HTTP 400 invalid_value errors caused by Codex App requesting output.encrypted_content in include.
  • Reuse the existing exact-entry normalization for Azure adapters and Azure OpenAI resource hosts configured through openai-responses. Preserve reasoning.encrypted_content, other include entries, caller-owned requests, and unrelated destinations.
  • Add regression coverage and update adapter documentation and the transport contract.

Closes #7952

Verification

  • Before the fix, the new regression group produced 3 failures and 1 pass, reproducing the missing Azure normalization.
  • Focused Azure and xAI tests: 30 passed, 0 failed.
  • bun run typecheck: passed.
  • bun run structure:check: passed.
  • bun run privacy:scan: passed.
  • Documentation dependency installation with the frozen lockfile and documentation build: passed; 625 pages built.
  • git diff --check: passed.
  • bun run test:changed was started; its final result is pending and is not claimed as passing.
  • Full suite has not been run. This PR remains draft pending broader validation and review.
  • No live Azure inference replay was performed. The installed proxy and user configuration were not changed.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults. No authentication, credential destination, or dependency changes are included.

Review readiness

  • Required local validation passed with its scope documented.
  • Branch is on the latest dev commit.
  • All correct Codex and CodeRabbit findings are resolved.
  • Ready-for-review confirmation.

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

  • Required local validation passed; commands, results, and any full-suite exception are documented.

  • I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).

  • I resolved all correct Codex and CodeRabbit findings.

  • My PR is ready for review.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⏳ DRAFT

  • review readiness checklist open (0/4 boxes ticked).

What to do

  • Tick all four boxes in the PR description once you're done (currently 0/4).

Review readiness checklist

  • ⬜ Required local validation passed; commands, results, and any full-suite exception are documented.
  • ⬜ I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
  • ⬜ I resolved all correct Codex and CodeRabbit findings.
  • ⬜ My PR is ready for review.

0/4 boxes ticked.

This PR stays in draft until every box above is ticked.

@lidge-jun

Copy link
Copy Markdown
Owner

Thanks @x3M3x — this is landing through a maintainer carry in #7988, which cherry-picks your commit unchanged onto current dev and credits you with a Co-authored-by trailer, since this draft's readiness checklist was not ticked. I'll close this PR (and #7952) once #7988 merges.

lidge-jun added a commit that referenced this pull request Oct 30, 2026
Carries #7953. Closes #7952.

Co-authored-by: x3M3x <98298256+x3M3x@users.noreply.github.com>
@lidge-jun

Copy link
Copy Markdown
Owner

Landed on dev through the maintainer carry #7988 (squash merge d389699), which kept your change and credits you with a Co-authored-by trailer. Thank you @x3M3x!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants