Repository navigation
fix(azure): omit unsupported Responses encrypted output include - #7988
Merged
Merged
Conversation
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 of 11 tasks
Contributor
|
✅ Deterministic PR hygiene checks passed. |
3 tasks done
…re include carry Co-authored-by: x3M3x <98298256+x3M3x@users.noreply.github.com>
Owner
Author
|
Maintainer integration into
|
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Carries #7953 by @x3M3x (their commit is cherry-picked unchanged onto current
dev; credit in the trailer below). #7953 is a draft whose readiness checklist is unticked, so it lands from a maintainer branch.Codex App requests
output.encrypted_contentininclude, which Azure Responses rejects with HTTP 400invalid_value(#7952). The existing exact-entry include normalization now also applies to Azure adapters and to Azure OpenAI resource hosts configured throughopenai-responses.reasoning.encrypted_content, other include entries, caller-owned request objects and unrelated destinations are preserved. Adapter docs and the transport contract are updated.Closes #7952
Verification
Bun 1.4.4; focused because the shared host is under load (AGENTS.md resource exception; breadth left to PR CI).
src/change reverted,bun test tests/providers/azure-adapter.test.ts→ 15 pass / 3 fail (the three new Azure include cases); with it, all pass.bun test tests/providers/azure-adapter.test.ts tests/providers/xai/xai-responses-adjacency.test.ts→ 38 pass / 0 fail (the xAI include path that shares the strip stays green).bun run typecheck(2,247 files, 0 errors) andbun run structure:checkpass.bun run test:changedand the full suite (host at critical load); PR CI covers them.Checklist
Co-authored-by: x3M3x 98298256+x3M3x@users.noreply.github.com