Skip to content

fix(azure): omit unsupported Responses encrypted output include - #7988

Merged
lidge-jun merged 2 commits into
devfrom
carry/pr7953-azure-include
Oct 30, 2026
Merged

lidge-jun merged 2 commits into
devfrom
carry/pr7953-azure-include

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

Carries #7953 by @x3M3x (their commit is cherry-picked unchanged onto current dev; credit in the trailer below). #7953 is a draft whose readiness checklist is unticked, so it lands from a maintainer branch.

Codex App requests output.encrypted_content in include, which Azure Responses rejects with HTTP 400 invalid_value (#7952). The existing exact-entry include normalization now also applies to Azure adapters and to Azure OpenAI resource hosts configured through openai-responses. reasoning.encrypted_content, other include entries, caller-owned request objects and unrelated destinations are preserved. Adapter docs and the transport contract are updated.

Closes #7952

Verification

Bun 1.4.4; focused because the shared host is under load (AGENTS.md resource exception; breadth left to PR CI).

  • Red→green: with the src/ change reverted, bun test tests/providers/azure-adapter.test.ts → 15 pass / 3 fail (the three new Azure include cases); with it, all pass.
  • bun test tests/providers/azure-adapter.test.ts tests/providers/xai/xai-responses-adjacency.test.ts → 38 pass / 0 fail (the xAI include path that shares the strip stays green).
  • bun run typecheck (2,247 files, 0 errors) and bun run structure:check pass.
  • NOT RUN locally: bun run test:changed and the full suite (host at critical load); PR CI covers them.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults (request shaping only; destination and credentials unchanged).

Co-authored-by: x3M3x 98298256+x3M3x@users.noreply.github.com

@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner October 30, 2026 11:33
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 1e1620f and 25bdf8f.

Files selected for processing: 5
  • docs-site/src/content/docs/reference/adapters.md
  • src/adapters/openai-responses/passthrough.ts
  • src/adapters/openai-responses/request-strips.ts
  • structure/transports/responses-wire-shapes.md
  • tests/providers/azure-adapter.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Oct 30, 2026
…re include carry

Co-authored-by: x3M3x <98298256+x3M3x@users.noreply.github.com>
@lidge-jun

Copy link
Copy Markdown
Owner Author

Maintainer integration into dev (MAINTAINERS.md maintainer-integration exception; not a self-approval or independent review). Carries #7953 by @x3M3x (Co-authored-by trailer in the description and merge commit). Closes #7952.

  • Exact head: 25bdf8ff95e30eff7f0c200884f7be19e45780c3
  • Exact-head CI: Cross-platform CI run 41050275887 — gates, test changed, structure gate, docs site build and the ci aggregate success; hygiene, labeler, enforce-target success. No failing or pending check on this head.
  • The head merges origin/dev after fix(responses): normalize Codex tool catalogs and include for Meta Muse #7985 (Meta include normalization) landed; the conflict in request-strips.ts, passthrough.ts and the wire-shapes contract was resolved to keep all three destination predicates (xAI, exact api.meta.ai, Azure adapters and *.openai.azure.com) on the shared exact-entry stripUnsupportedOutputInclude.
  • Independent review: a fresh reviewer PASSed the original carry, and a second fresh reviewer PASSed this post-merge head (predicates intact, nothing from dev dropped, Azure tests exercise the real request path, lookalike hosts excluded).
  • Local (Bun 1.4.4, focused under the shared-host load exception): Azure include cases red with the fix reverted (3 fail) / green with it; after the merge, bun test tests/providers/azure-adapter.test.ts tests/providers/xai/xai-responses-adjacency.test.ts tests/responses/responses-muse-tool-choice.test.ts tests/providers/muse-spark-web-search-compat.test.ts 84 pass / 0 fail; typecheck and structure:check pass.
  • Union check vs current origin/dev d42b9b1b23: clean merge; passthrough.ts 710 lines, request-strips.ts 423; existing test files only.

@lidge-jun
lidge-jun merged commit d389699 into dev Oct 30, 2026
27 checks passed
@lidge-jun
lidge-jun deleted the carry/pr7953-azure-include branch October 30, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants