[lidge-jun]

Summary

Carries #7969 by @nobrainer-tech (their commits are kept on this branch; credit in the trailer below), with a maintainer fix for the review blocker. Pushing that fix to the contributor branch would reset the author's readiness checklist and return the PR to draft, so it lands from a maintainer branch.

Codex Desktop continuations sent to Meta/Muse failed before inference because the client requests output.encrypted_content and carries private additional_tools input items. For the exact api.meta.ai destination the request now omits only the unsupported include, keeps reasoning.encrypted_content, and moves current tool declarations into the public tools array before history rewrites. The projection keeps the replay boundary, historical custom-call conversion, current declaration schemas over search discoveries, explicit bare-tool precedence, namespace/name restoration and tool_choice: none handling, normalizes nested function definitions, and rejects malformed or unrepresentable current catalogs before upstream dispatch. Other Responses destinations are unchanged; xAI keeps its exact-entry include normalization.

Maintainer fix (f7cfb01ed2): the catalog check validated every additional_tools wrapper before computing the replay boundary, so a malformed historical wrapper — which is removed and cannot authorize a current tool — still produced a local HTTP 400. The boundary is now computed first and only current declarations are validated; historical custom-call replay context is kept. Current origin/dev is merged in with an ordinary merge commit.

Known limit, left for follow-up: a current catalog that only Meta cannot represent still maps to the same 400 as malformed client input, so a combo does not fall through to another target for that case. #7982 handles the related mandatory tool_choice preflight separately; this PR does not touch combo selection.

Verification

Bun 1.4.4; focused because the shared host is under load (AGENTS.md resource exception; breadth left to PR CI).

• New regression bun test tests/responses/responses-muse-tool-choice.test.ts -t 'ignores malformed historical catalogs while normalizing current declarations': before the fix 0 pass / 1 fail (MuseToolCatalogCompatibilityError: Malformed tool catalog for Meta Responses.); after 1 pass / 0 fail.
• bun test tests/responses/responses-muse-tool-choice.test.ts tests/providers/muse-spark-web-search-compat.test.ts tests/responses/responses-muse-tool-name-alias.test.ts tests/providers/muse-tool-name-alias.test.ts tests/responses/responses-undeclared-tool-guard.test.ts tests/responses/responses-undeclared-tool-guard-inbound.test.ts tests/responses/custom-tool-compat.test.ts tests/responses/responses-custom-tool-historical-replay.test.ts tests/responses/namespace-tool-compat.test.ts: 271 pass / 0 fail.
• bun run typecheck (2,244 files, 0 errors), bun run structure:check, bun run privacy:scan, git diff --check origin/dev...HEAD pass; all 12 changed files are within their file-size limits.
• fix(responses): normalize Codex tool catalogs and include for Meta Muse #7969's own validation is recorded on that PR.
• NOT RUN locally: bun run test:changed, the full suite and the docs-site build (host at critical load); PR CI covers them. Live Meta session execution remains unverified, as on fix(responses): normalize Codex tool catalogs and include for Meta Muse #7969.

Checklist

• Scope stays focused and avoids unrelated cleanup.
• Docs or release notes were updated when needed.
• Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults (request shaping only; destination and credentials unchanged).

Co-authored-by: nobrainer-tech 445466+nobrainer-tech@users.noreply.github.com

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 39 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: lidge-jun/opencodex
• Branch: carry/pr7969-muse-tool-catalog
• File: .coderabbit.yaml
• Commit: f7cfb01
• Layers: Repository YAML
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 4f77bd2b-0951-4752-835d-4337abf3f392

Commits

Reviewing files that changed from the base of the PR and between 0cc5a59 and f7cfb01.

Files selected for processing: 12

• docs-site/src/content/docs/reference/adapters.md
• src/adapters/openai-responses/muse-tool-catalog.ts
• src/adapters/openai-responses/passthrough.ts
• src/adapters/openai-responses/request-strips.ts
• src/server/responses/passthrough-dispatch.ts
• structure/providers/opengateway.md
• structure/providers/xai-grok.md
• structure/transports/response-citations.md
• structure/transports/responses-citations.md
• structure/transports/responses-wire-shapes.md
• tests/providers/muse-spark-web-search-compat.test.ts
• tests/responses/responses-muse-tool-choice.test.ts

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

✅ Deterministic PR hygiene checks passed.

[lidge-jun]

Maintainer integration into dev (MAINTAINERS.md maintainer-integration exception; not a self-approval or independent review). Carries #7969 by @nobrainer-tech (Co-authored-by trailer in the description and commits).

• Exact head: f7cfb01ed2c2802373a34022365361b9fcd333ae
• Exact-head CI: Cross-platform CI run 41048711816 — gates, test changed, structure gate, docs site build and the ci aggregate success; hygiene, labeler, enforce-target success. No failing or pending check on this head.
• Independent review: round 1 on fix(responses): normalize Codex tool catalogs and include for Meta Muse #7969 found the historical-catalog blocker; a fresh reviewer of this exact head returned PASS. Accepted residual, documented in the description: a current catalog only Meta cannot represent still maps to the same 400 as malformed input, so combos do not fall through for that case (follow-up; fix(combo): skip Meta Muse targets for mandatory tool_choice #7982 covers mandatory tool_choice separately).
• Local (Bun 1.4.4, focused under the shared-host load exception): new regression red (MuseToolCatalogCompatibilityError) before / green after; 271 pass / 0 fail across nine Muse, custom-tool, namespace and undeclared-tool-guard files; typecheck, structure:check, privacy:scan pass.
• Union check vs current origin/dev d82d7ee739: clean merge; merged src/server/responses/passthrough-dispatch.ts 1,998 lines (2,000 default), passthrough.ts 707, adapters reference 863; existing test files only, no union or count change. fix(azure): omit unsupported Responses encrypted output include #7988 (Azure include) touches the same include code and will be updated onto dev and re-verified before it lands.