Repository navigation
automation: repo-governance - Add governance automation and validation - #346
Merged
Merged
Conversation
…test installed, pnpm removed, Node.js 24 pinned) - T008: Jest ESM configuration verified (588 tests passing, 11 suites) - T009: Added vitest@1.6.1 to devDependencies with matching test discovery config - T010: Updated AGENTS.md with current test baseline (Jest 588/588, Vitest ready, Speckit 103/104) - T011: Removed all pnpm artefacts (pnpm-workspace.yaml, pnpm-lock.yaml, pnpm.overrides) - T012: Verified Node.js 24 LTS pinning complete (.nvmrc, engines field, netlify.toml, README) Updated files: - package.json: Added vitest, removed pnpm.overrides - src/app/netlify.toml: Updated build command to 'npm run build', Node 24, npm 11 - AGENTS.md: Updated tech stack, package manager status, Node.js runtime, test baseline - Verified package-lock.json regenerated with npm-only dependencies All Phase 2 foundational tasks now complete. Ready for T013-T015 (Tailwind audit and removal). Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M19XUm4o2NcBPgWmgM9xWE
- Verified no tailwindcss or @tailwindcss packages in dependencies - Verified no Tailwind config files (tailwind.config.*, .postcssrc) - Verified postcss.config.mjs is empty (no Tailwind plugins) - Confirmed BEM CSS fully in place with proper folder structure - Updated AGENTS.md tech stack to reflect BEM-only styling No changes to source files needed - Tailwind removal was already complete. All Phase 2 foundational tasks (T008-T015) now verified complete. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M19XUm4o2NcBPgWmgM9xWE
…t inventory, Anthropic platforms, protected files) T016-T017: Test Discovery & Branch Name Validation - Verified Jest discovers 588 tests across 11 suites - Verified branch validation suite has 189 tests covering all patterns - Confirmed test discovery patterns in jest.config.js and vitest.config.ts - Both Jest and Vitest configured for consistent test discovery T017a: Agent Inventory (.claude/agents/INVENTORY.md) - Created comprehensive inventory of 20 agents in repository - Organized by functional category (strategy, design, dev, testing, project mgmt, analytics, release) - Documented agent names, purposes, and file references - Added budget controls and maintenance guidance T017b: Anthropic Platforms Applicability Assessment (docs/ANTHROPIC_PLATFORMS.md) - Mapped 7 Anthropic platforms against governance requirements (R7.1-R7.4) - Evaluated: Claude API, Tool Use, Managed Agents, Prompt Caching, MCP, Artifact API, Claude Docs - Created platform selection matrix for governance tasks - Documented gaps and mitigation strategies - Provided recommendations for immediate and future phases T017c: Protected Files Guard Workflow (.github/workflows/protected-files-guard.yml) - Implemented workflow to detect changes to protected files - Protected categories: CHANGELOG.md, ATTRIBUTIONS.md, Figma components, Supabase utils, workflows, tasks - Adds comment to PR with required action steps for modification requests - Fails check if protected files are modified without approval All Phase 2 foundational tasks now complete (T008-T017c). Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M19XUm4o2NcBPgWmgM9xWE
Ignore auto-generated branch-cleanup-*.md files in .github/reports/branches/ These are generated by automation scripts and should not be tracked. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M19XUm4o2NcBPgWmgM9xWE
These files are now ignored via .gitignore pattern. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M19XUm4o2NcBPgWmgM9xWE
- T008-T009: Jest ESM and Vitest configuration - T010-T017: Testing baseline, package manager, Node.js, Tailwind removal, test discovery - T017a-T017c: Agent inventory, Anthropic assessment, protected files guard All infrastructure prerequisites now in place for workstream execution. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M19XUm4o2NcBPgWmgM9xWE
- Create .github/PULL_REQUEST_TEMPLATE/ directory - Add type-specific templates: feat, fix, docs, design, test, refactor, chore, default - Each template tailored to branch type requirements and checklist items - Supports Automated Routing (Option B) for template content application - Workflow (pr-template-routing.yml) routes templates based on branch prefix Templates preserve contributor content while providing structured guidance for different PR types. Workflow ready for template body injection phase. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M19XUm4o2NcBPgWmgM9xWE
…, T039) - Create .github/CODEOWNERS for code area ownership enforcement - Maps critical files (.github/, scripts/, AGENTS.md) to @ashley - Supports future branch protection rules and CODEOWNERS review requirements - T037: CODEOWNERS file created - T039: Branch name validation workflow already implemented and tested Governance infrastructure now includes: ✅ Protected files guard (T017c) ✅ PR template routing (T035) ✅ CODEOWNERS file (T037) ✅ Branch validation (T039) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M19XUm4o2NcBPgWmgM9xWE
✅ Deploy Preview for thisonetimeonacid ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Important Review skippedWe couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 Walkthrough
Merge Risk: 🟡 Moderate · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly describes the main changes: repository governance automation and validation. It is concise and relevant to the pull request. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (4 skipped: 4 unsupported.)
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
This was referenced Oct 18, 2026
Drift Detection ✅✅ No drift detected. Configuration is canonical. Canonical governance files are correctly centralized in lightspeedwp/.github. |
|
✅ Workflow Syntax Validation All workflows in Result: All workflows passed validation |
The merged package-lock.json had integrity hashes stripped, causing npm ci to fail in CI/CD. Restored correct version from develop branch which includes all required integrity fields and matches package.json. This fixes: - Validate configs (read-only) check - Claude guard contract tests - Specification Validation - Jest tests - Package installation in CI pipeline Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M19XUm4o2NcBPgWmgM9xWE
Resolved merge conflicts in CHANGELOG.md and package.json: - Kept develop's CHANGELOG.md (newer entries about about page content) - Kept our package.json (with peerDependencies section) - Both branches made compatible changes; conflicts resolved by keeping newer content Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M19XUm4o2NcBPgWmgM9xWE
Drift Detection ✅✅ No drift detected. Configuration is canonical. Canonical governance files are correctly centralized in lightspeedwp/.github. |
|
This pull request modifies one or more protected files that require explicit owner review and approval. Protected files detected:
Protected file categories:
Required action:
See AGENTS.md § Protected and locked files for details. |
|
✅ Workflow Syntax Validation All workflows in Result: All workflows passed validation |
Contributor
|
👤 Human-authored PR — awaiting review and approval. Checklist before merge:
|
15 tasks
Convergence assessment identified 4 unchecked tasks and 1 partial gap: - T060: PR template routing verification (feature/fix/docs branches) - T061: Branch protection configuration (manual GitHub Settings step) - T062: GitHub Discussions enablement (categories and templates) - T063: Styling documentation audit (BEM conventions completeness) - T064: Protected-file approval recording (@ashley sign-off) - T065: Handoff documentation (COMPLETION.md and CATALOG.md update) Phase 9 tasks appended to tasks.md following SpecKit convergence protocol. All prior phases (1-8) complete; 55/59 tasks marked [x]; ready for final validation. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M19XUm4o2NcBPgWmgM9xWE
Drift Detection ✅✅ No drift detected. Configuration is canonical. Canonical governance files are correctly centralized in lightspeedwp/.github. |
|
This pull request modifies one or more protected files that require explicit owner review and approval. Protected files detected:
Protected file categories:
Required action:
See AGENTS.md § Protected and locked files for details. |
|
✅ Workflow Syntax Validation All workflows in Result: All workflows passed validation |
This was referenced Oct 22, 2026
Member
Author
This was referenced Oct 23, 2026
This was referenced Oct 24, 2026
This was referenced Oct 24, 2026
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔐 Change Request
Relates to: #428 [TEMPLATE-UPDATE-REQUEST] — Governance Infrastructure Phase 2-5 Implementation
This PR requires approval of the protected file modifications documented in issue #428.
Summary
Implementation of spec-001 (Repository Governance Infrastructure) Phase 2 foundational infrastructure and Phase 5 GitHub governance configuration, completing core governance automation foundation.
Motivation
Specification requires comprehensive governance infrastructure across 5 parallel workstreams. This PR delivers:
Changes
Phase 2: Foundational Infrastructure (T008-T017c)
Phase 1: Setup (Partial) (T001-T007)
Phase 3: Spec Kit (T018-T024)
Phase 5: GitHub Governance (WS-261, T031-T039)
Testing
All infrastructure validated:
Shared PR-template selection and contributor instructions remain unverified; the clarification above does not claim repository-file changes or additional validation.
Checklist
Related Issues
These are partial contributions, not completed child outcomes.
No issue closure is claimed. Outstanding validation and approval
gates remain applicable.
🤖 Generated with Claude Code