Skip to content

governance: Address CodeRabbit feedback and remove locked-files-guard - #435

Merged
ashleyshaw merged 2 commits into
developfrom
build/netlify-hashed-asset-headers
Oct 22, 2026
Merged

ashleyshaw merged 2 commits into
developfrom
build/netlify-hashed-asset-headers

Conversation

@ashleyshaw

Copy link
Copy Markdown
Member

Summary

Address remaining CodeRabbit review feedback on Spec-001 governance documentation and simplify CI/CD governance by removing redundant locked-files-guard workflow.

Changes

CodeRabbit Review Fixes

  • README.md: Clarify BEM-only CSS architecture and Tailwind-for-Make-only approach
  • tasks.md Phase 6: Revise checkpoint to reflect Tailwind remains configured but not used in components
  • tasks.md T029: Document protected-files guard approval process integration

Workflow Refactoring

Related Issues

Relates to #346 (Spec-001 Phase 2-5), #428 [TEMPLATE-UPDATE-REQUEST]


🤖 Generated with Claude Code

ashleyshaw and others added 2 commits October 22, 2026 19:38
- Clarify BEM-only CSS architecture in README overview
- Document that Tailwind tooling is retained for Make but not used in components
- Update Phase 6 checkpoint to accurately reflect Tailwind status
- Note outstanding T046 Styling section requirement
- Document T029 protected files guard approval process integration

Addresses CodeRabbit review comments on:
  • README.md line 25: CSS architecture clarity
  • tasks.md line 378: Phase 6 Tailwind status
  • tasks.md line 268-270: T029 approval documentation

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Remove the Constitution Principle II enforcement workflow that blocks PRs
modifying protected files without approved change requests. This workflow
is redundant with the protected-files-guard.yml workflow and the manual
change-request approval process via issue #428.

Eliminates unnecessary CI complexity while maintaining governance through:
- Protected file restrictions via GitHub branch protection
- Manual change-request approval via [TEMPLATE-UPDATE-REQUEST] issues
- CODEOWNERS review requirements

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@ashleyshaw
ashleyshaw marked this pull request as ready for review October 22, 2026 12:44
@vercel

vercel Bot commented Oct 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
thisonetimeonacidcom Building Building Preview Oct 22, 2026 12:44pm UTC

@netlify

netlify Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for thisonetimeonacid ready!

Name Link
🔨 Latest commit 671a981
🔍 Latest deploy log https://app.netlify.com/projects/thisonetimeonacid/deploys/6ada051b695cc69c3d268923
😎 Deploy Preview https://deploy-preview-435--thisonetimeonacid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

Copy link
Copy Markdown

PR Template Routing 📋

Branch prefix: build

Suggested template: pr_default.md

Type: General PR


Canonical templates are managed in lightspeedwp/.github:

  • Review the suggested template to ensure your PR description covers the required sections
  • All PR templates route from the central .github repository

@ashleyshaw
ashleyshaw merged commit ea34c9f into develop Oct 22, 2026
17 of 22 checks passed
@github-actions

Copy link
Copy Markdown

Drift Detection ✅

✅ No drift detected. Configuration is canonical.

Canonical governance files are correctly centralized in lightspeedwp/.github.

@github-actions

Copy link
Copy Markdown

✅ Workflow Syntax Validation

All workflows in .github/workflows/ have been validated for YAML syntax.

Result: All workflows passed validation

@ashleyshaw
ashleyshaw deleted the build/netlify-hashed-asset-headers branch October 22, 2026 12:44
@mergify

mergify Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

👤 Human-authored PR — awaiting review and approval.

Checklist before merge:

  • All required CI checks pass
  • At least one approval from code owner
  • No unresolved change requests
  • Branch is up to date with base

@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
📥 Commits

Reviewing files that changed from the base of the PR and between 8d2aaf6 and 671a981.

📒 Files selected for processing: 3
  • .github/specs/001-repo-governance-layout-and-agentic-workflows/tasks.md
  • .github/workflows/locked-files-guard.yml
  • README.md
+----------------------------------------------------------+
| Not just a pretty face, but a pretty good code reviewer! |
+----------------------------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant