upcoming: [M3-7901] - Update navigation items for Placement Groups

[carrillo-erik]

Description 📝

This PR mainly just updates the UI for the PrimaryNav and TopMenu components.

Changes 🔄

• Move Placement Groups below Images
• Add Placement Groups to the Create menu on the TopMenu component.

Target release date 🗓️

04/15/2024

Preview 📷

Before	After

How to test 🧪

Prerequisites

• Have the Placement Group feature flag turned on.

Verification steps

• Verify the UI to reflect the changes described in the Description.
• Verify the interactions of the UI updates behave as expected.

As an Author I have considered 🤔

Check all that apply

• 👀 Doing a self review
• ❔ Our contribution guidelines
• 🤏 Splitting feature into small PRs
• ➕ Adding a changeset
• 🧪 Providing/Improving test coverage
• 🔐 Removing all sensitive information from the code and PR description
• 🚩 Using a feature flag to protect the release
• 👣 Providing comprehensive reproduction steps
• 📑 Providing or updating our documentation
• 🕛 Scheduling a pair reviewing session
• 📱 Providing mobile support
• ♿ Providing accessibility support

[github-actions]

Coverage Report: ✅
Base Coverage: 81.72%
Current Coverage: 81.72%

[mjac0bs]

I know there was past discussion about where Placement Groups should live in the primary nav and whether it should be in close proximity to Linodes. Since it's now moved down below Images, do you know what went into that UX decision? Just curious.

[abailly-akamai]

@mjac0bs UX decision: less prominence more important than entity relationship (at the moment, it's likely to change, as you know...)

[abailly-akamai]

@carrillo-erik can you check with UX/Copy (Susanna & Chris) about shortening this copy so we don't wrap and have two lines? It would be the only item with two lines, breaking the flow and giving it more prominence

[carrillo-erik]

I brought this up with them and the decision was made to change it to Control your Linodes' physical placement

[dwiley-akamai]

The PR description says the following are prereqs:

Have the placement-group customer tag on the user account used for testing.
Point to the dev environment using the Cloud Manager dev tools.

I don't think either are prereqs -- I was pointed at the prod environment without that tag and still saw the navigation items.

I think it's just based on the feature flag, except for the Create dropdown item, which gets displayed even with the feature flag off currently. Shouldn't the object for it in AddNewMenu.tsx have the hide property, controlled by the feature flag or isFeatureEnabled logic?

[carrillo-erik]

The PR description says the following are prereqs:

Have the placement-group customer tag on the user account used for testing.
Point to the dev environment using the Cloud Manager dev tools.

I don't think either are prereqs -- I was pointed at the prod environment without that tag and still saw the navigation items.

I think it's just based on the feature flag, except for the Create dropdown item, which gets displayed even with the feature flag off currently. Shouldn't the object for it in AddNewMenu.tsx have the hide property, controlled by the feature flag or isFeatureEnabled logic?

I will double check on this, to make sure I get the details correct. I believe that the menu items are controlled by the feature flag as you mentioned, however, the API endpoints require the customer tag and to point at the dev environment. I appreciate you pointing this out.