Skip to content

upcoming: [M3-7901] - Update navigation items for Placement Groups #10340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carrillo-erik merged 4 commits into from
Apr 4, 2024
Merged

upcoming: [M3-7901] - Update navigation items for Placement Groups #10340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cfd83dc
upcoming: [M3-7901] - Update navigation items for Placement Groups
carrillo-erik Apr 2, 2024
69cf9fb
Add hide property to placement group in AddNewMenu component
carrillo-erik Apr 3, 2024
6e236bf
Add changeset
carrillo-erik Apr 3, 2024
eb2d477
Update PG description in AddNewMenu
carrillo-erik Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-10340-upcoming-features-1712145875071.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Upcoming Features
---

Update navigation and add new menu items for Placement Groups ([#10340](https://github.com/linode/manager/pull/10340))
16 changes: 8 additions & 8 deletions packages/manager/src/components/PrimaryNav/PrimaryNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,14 +200,6 @@ export const PrimaryNav = (props: PrimaryNavProps) => {
href: '/linodes',
icon: <Linode />,
},
{
betaChipClassName: 'beta-chip-placement-groups',
display: 'Placement Groups',
hide: !flags.placementGroups?.enabled,
href: '/placement-groups',
icon: <PlacementGroups />,
isBeta: flags.placementGroups?.beta,
},
{
display: 'Volumes',
href: '/volumes',
Expand Down Expand Up @@ -250,6 +242,14 @@ export const PrimaryNav = (props: PrimaryNavProps) => {
href: '/images',
icon: <Image />,
},
{
betaChipClassName: 'beta-chip-placement-groups',
display: 'Placement Groups',
hide: !flags.placementGroups?.enabled,
href: '/placement-groups',
icon: <PlacementGroups />,
isBeta: flags.placementGroups?.beta,
},
],
[
{
Expand Down
8 changes: 8 additions & 0 deletions packages/manager/src/features/TopMenu/AddNewMenu/AddNewMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import LinodeIcon from 'src/assets/icons/entityIcons/linode.svg';
import LoadBalancerIcon from 'src/assets/icons/entityIcons/loadbalancer.svg';
import NodebalancerIcon from 'src/assets/icons/entityIcons/nodebalancer.svg';
import OneClickIcon from 'src/assets/icons/entityIcons/oneclick.svg';
import PlacementGroupsIcon from 'src/assets/icons/entityIcons/placement-groups.svg';
import VolumeIcon from 'src/assets/icons/entityIcons/volume.svg';
import VPCIcon from 'src/assets/icons/entityIcons/vpc.svg';
import { Button } from 'src/components/Button/Button';
Expand Down Expand Up @@ -110,6 +111,13 @@ export const AddNewMenu = () => {
icon: FirewallIcon,
link: '/firewalls/create',
},
{
description: "Control your Linodes' physical placement",
entity: 'Placement Groups',
hide: !flags.placementGroups?.enabled,
icon: PlacementGroupsIcon,
link: '/placement-groups/create',
},

@abailly-akamai abailly-akamai Apr 2, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carrillo-erik can you check with UX/Copy (Susanna & Chris) about shortening this copy so we don't wrap and have two lines? It would be the only item with two lines, breaking the flow and giving it more prominence

Screenshot 2024-04-02 at 12 39 04

@carrillo-erik carrillo-erik Apr 3, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I brought this up with them and the decision was made to change it to Control your Linodes' physical placement

{
description: 'Manage your DNS records',
entity: 'Domain',
Expand Down