fix: [UIE-9111] - DBaaS - Database landing page shows error state after plans column is sorted.

[smans-akamai]

Description 📝

This pull request fixes in issue in the DBaaS Landing page where the error state is displayed shortly after "Plan" column is sorted.

Changes 🔄

List any change(s) relevant to the reviewer.

• Sort Cell for "Plan" column has been updated to provide type which changes what we provide to orderBy for X-Filter in the database instances request and should work with both variations of the call (new and legacy)
• The text displayed for this column header will continue to be "Plan". This is only an update to what what we provide to the backend call for the database list.

Scope 🚢

Upon production release, changes in this PR will be visible to:

• All customers
• Some customers (e.g. in Beta or Limited Availability)
• No customers / Not applicable

Target release date 🗓️

8/26/2025

Preview 📷

Before	After

How to test 🧪

Prerequisites

(How to setup test environment)

• This has to be tested in an environment with the actual backend calls
• Have access to the Databases tab and landing page
• Have 1 more databases created so you can view the table

Reproduction steps

(How to reproduce the issue, if applicable)

Note: You can differentiate between the legacy and new database instances calls via the platform field in X-Filter.

• ie. rdbms-legacy vs rdbms-default

• Access the Databases tab to view the landing page
• In the table, click the "Plan" column header cell to sort it, then wait until the legacy call for databases is made (See Screenshots)
• See that the database instances call fails with a bad request and check X-Filter to see that "orderBy": "plan" is provided.
• See that the error state for the table is displayed with the message Could not apply filter

Verification steps

(How to verify changes)

• Access the Databases tab to view the landing page
• In the table, click the "Plan" column header cell to sort it, then wait until the legacy call is made.
• View the calls and verify that X-Filter has "orderBy": "type" provided
• Verify that both variations of the call (new and legacy) are successful and you don't see the error state display.
• Verify that "Plan" is still shown as the text in the column header

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

• I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

• All tests and CI checks are passing
• TypeScript compilation succeeded without errors
• Code passes all linting rules

[corya-akamai]

Does this need to stay "plan"?

[smans-akamai]

@corya-akamai On line 126, you'll see Plan which is the text that gets displayed in the column header cell. I left that as is so we still see Plan in the UI.

The label property is what gets passed up and eventually used in x-filter. You can see the onClick for TableSortCell here where it gets used.
https://github.com/linode/manager/blob/develop/packages/manager/src/components/TableSortCell/TableSortCell.tsx#L46

[smans-akamai]

However I also see it used for the aria-label in TableSortCell here:
https://github.com/linode/manager/blob/develop/packages/manager/src/components/TableSortCell/TableSortCell.tsx#L69

@mjac0bs Though "type" and "plan" refer to the same field, does the aria-label need to mirror the actual text we're seeing in the UI?

If so, then I'll need to reach out to UX to see if we want to make this change to the actual text that gets displayed.

[mjac0bs]

As Sam said, it does need to be consistent with the actual filter on the backend and this statement in the PR description isn't correct/maybe was not removed as intended:

The label for this column will continue to be "Plan". This is only an update to what what we provide to the backend call for the database list.

As for the aria-label, I think you're fine - there are plenty of other spots that handle the Plan/Type column with the aria-text slightly differing. (you can see them by searching active={orderBy === 'type'}).

[mjac0bs]

As Sam said, it does need to be consistent with the actual filter on the backend and this statement in the PR description isn't correct/maybe was not removed as intended:

The label for this column will continue to be "Plan". This is only an update to what what we provide to the backend call for the database list.

As for the aria-label, I think you're fine - there are plenty of other spots that handle the Plan/Type column with the aria-text slightly differing. (you can see them by searching active={orderBy === 'type'}).

[smans-akamai]

@mjac0bs Just saw your comment and updated the description to just say that the column header text will continue to be plan.
The text displayed for this column header will continue to be "Plan". This is only an update to what what we provide to the backend call for the database list.

Thanks for the quick response!

[linode-gh-bot]

Cloud Manager UI test results

🎉 730 passing tests on test run #2 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
0 Failing	730 Passing	4 Skipped	119m 18s