Skip to content

fix: [UIE-9111] - DBaaS - Database landing page shows error state after plans column is sorted. #12729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smans-akamai merged 3 commits into from
Aug 20, 2025
Merged

fix: [UIE-9111] - DBaaS - Database landing page shows error state after plans column is sorted. #12729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09d4967
fix: [UIE-9111] - DBaaS - Database landing page shows error state aft…
smans-akamai Aug 19, 2025
dd142c5
Adding changeset
smans-akamai Aug 19, 2025
f89fe8f
Fixing casing in changeset
smans-akamai Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-12729-fixed-1755635540451.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Fixed
---

DBaaS Landing page shows filter error state after sorting by "Plan" column in table ([#12729](https://github.com/linode/manager/pull/12729))
4 changes: 2 additions & 2 deletions packages/manager/src/features/Databases/DatabaseLanding/DatabaseLandingTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,10 @@ const DatabaseLandingTable = ({
</TableSortCell>
{isNewDatabase && (
<TableSortCell
active={orderBy === 'plan'}
active={orderBy === 'type'}
direction={order}
handleClick={handleOrderChange}
label="plan"
label="type"

@corya-akamai corya-akamai Aug 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to stay "plan"?

@smans-akamai smans-akamai Aug 19, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corya-akamai On line 126, you'll see Plan which is the text that gets displayed in the column header cell. I left that as is so we still see Plan in the UI.

The label property is what gets passed up and eventually used in x-filter. You can see the onClick for TableSortCell here where it gets used.
https://github.com/linode/manager/blob/develop/packages/manager/src/components/TableSortCell/TableSortCell.tsx#L46

@smans-akamai smans-akamai Aug 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However I also see it used for the aria-label in TableSortCell here:
https://github.com/linode/manager/blob/develop/packages/manager/src/components/TableSortCell/TableSortCell.tsx#L69

@mjac0bs Though "type" and "plan" refer to the same field, does the aria-label need to mirror the actual text we're seeing in the UI?

If so, then I'll need to reach out to UX to see if we want to make this change to the actual text that gets displayed.

@mjac0bs mjac0bs Aug 19, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Sam said, it does need to be consistent with the actual filter on the backend and this statement in the PR description isn't correct/maybe was not removed as intended:

The label for this column will continue to be "Plan". This is only an update to what what we provide to the backend call for the database list.

As for the aria-label, I think you're fine - there are plenty of other spots that handle the Plan/Type column with the aria-text slightly differing. (you can see them by searching active={orderBy === 'type'}).

>
Plan
</TableSortCell>
Expand Down