tests [M3-9610]: VM host maintenance banner in linode landing and details pages - #12753
Merged
jdamore-linode merged 23 commits intoSep 5, 2025
Merged
Conversation
dmcintyr-akamai
marked this pull request as ready for review
August 28, 2025 16:01
dmcintyr-akamai
requested review from
bill-akamai,
dwiley-akamai and
jdamore-linode
and removed request for
a team
August 28, 2025 16:01
bill-akamai
reviewed
Aug 28, 2025
7 tasks
Contributor
Author
|
do not merge till after #12763 is merged |
7 tasks
dwiley-akamai
approved these changes
Sep 3, 2025
dwiley-akamai
left a comment
dwiley-akamai
left a comment
Contributor
There was a problem hiding this comment.
vm-host-maintenance-linode.spec.ts passes locally ✅
Can we get a changeset added?
Cloud Manager UI test results🎉 745 passing tests on test run #21 ↗︎
|
This was referenced Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Test the presence and absence of the vm host maintenance banner in the linode landing and details pages.
Changes 🔄
Verify that the proper banner is present when mocking account/maintenance. Suppress platform maintenance notification banners by mocking no data returned from account/notifications. Added data-testid for banners to make it easier to differentiate between different types of notice-banners.
In the landing page, the MaintenanceBannerV2 ([data-qa-maintenance-banner-v2="true"]) is present. In the linode details page, the LinodeMaintenanceBanner ([data-qa-maintenance-banner="true"]) is present.
How to test 🧪
pnpm run cy:run -s cypress/e2e/core/linodes/vm-host-maintenance-linode.spec.ts
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅