Skip to content

fix: [M3-10527] - Maintenance banner showing redundant links - #12763

Merged
jaalah-akamai merged 10 commits into
linode:developfrom
jaalah-akamai:M3-10527
Sep 4, 2025
Merged

fix: [M3-10527] - Maintenance banner showing redundant links#12763
jaalah-akamai merged 10 commits into
linode:developfrom
jaalah-akamai:M3-10527

Conversation

@jaalah-akamai

@jaalah-akamai jaalah-akamai commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

Description 📝

Fix maintenance banner navigation links showing redundant "Account Maintenance" links when users are already on the maintenance page. This was due to recent route changes for the /administration/ section work done.

Changes 🔄

  • Removed pathname prop dependency from both maintenance banner components
  • Used useLocation hook directly inside the components for cleaner, more self-contained code
  • Updated unit tests to use the new initialRoute approach instead of prop passing

Scope 🚢

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️

N/A

Preview 📷

Before After
Screenshot 2025-08-25 at 10 00 32 AM Screenshot 2025-08-25 at 10 00 19 AM

How to test 🧪

Prerequisites

Reproduction steps

  • Go to /maintenance and observe redundant links

Verification steps

  • Go to /maintenance and observe they've been removed
  • Go to any other page and observe they should appear
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@jaalah-akamai
jaalah-akamai marked this pull request as ready for review August 25, 2025 14:35
@jaalah-akamai
jaalah-akamai requested a review from a team as a code owner August 25, 2025 14:35
@jaalah-akamai
jaalah-akamai requested review from bnussman-akamai, cpathipa and harsh-akamai and removed request for a team August 25, 2025 14:35

@bnussman-akamai bnussman-akamai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🧼

@cpathipa cpathipa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaalah Thank you for fixing the Maintenance banner redundant links.

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Aug 26, 2025
@cpathipa cpathipa added the Approved Multiple approvals and ready to merge! label Aug 26, 2025
@jaalah-akamai
jaalah-akamai requested a review from a team as a code owner August 28, 2025 20:22
@jaalah-akamai
jaalah-akamai requested review from dmcintyr-akamai and removed request for a team August 28, 2025 20:22
@dmcintyr-akamai

Copy link
Copy Markdown
Contributor

this pr may break my #12753, and my pr might break your tests, so i will wait to merge mine.

@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🎉 740 passing tests on test run #8 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing740 Passing6 Skipped42m 20s

@jaalah-akamai
jaalah-akamai merged commit 4da657e into linode:develop Sep 4, 2025
35 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge!

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants