fix: [UIE-9500] - oAuth issue with IAM OAuthCallback by abailly-akamai · Pull Request #13037 · linode/manager

abailly-akamai · 2025-10-30T13:25:52Z

Description 📝

When signing in with an OAuthCallback that includes a route using checkIAMEnabled, auth fails because of race condition with the profile check.

Changes 🔄

use route context for profile in checkIAMEnabled
implement ongoing fix to userAccountPermission fixes (see: feat: [UIE-9393] - IAM Parent/Child: delegate permissions for child account #13033)
improve loading pattern on iam/roles on first load

Scope 🚢

Upon production release, changes in this PR will be visible to:

All customers
Some customers (e.g. in Beta or Limited Availability)
No customers / Not applicable

Preview 📷

Before	After
Screen.Recording.2025-10-30.at.14.36.46.mov	Screen.Recording.2025-10-30.at.14.33.41.mov

How to test 🧪

Prerequisites

Have an IAM enabled account - any environment

Reproduction steps

While already authenticated, navigate to http://localhost:3000/iam/roles
logout
once on the login screen, paste http://localhost:3000/iam/roles in the URL bar
proceed to authenticate
⛔ notice you will be redirected to the login process

Verification steps

While already authenticated, navigate to http://localhost:3000/iam/roles
logout
once on the login screen, paste http://localhost:3000/iam/roles in the URL bar
proceed to authenticate
✅ confirm no redirect from /iam/roles and properly authenticated in cloud manager

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All tests and CI checks are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

abailly-akamai · 2025-10-30T13:44:13Z

+      permissionMap[permission] =
+        (unrestricted || usersPermissionMap[permission]) ?? false;
+    }
+  });


@aaleksee-akamai - these are exactly your changes from #13033 because i wanted to make sure to test these changes with the proper checks in place.

aaleksee-akamai · 2025-11-04T10:36:50Z

-      queryOptions(profileQueries.profile())
-    );
-
-    if (profile.restricted) {


in that case maybe we need to remove/update the comment below?

aaleksee-akamai

Confirm the steps, looks good, thanks for the fix!

mpolotsk-akamai

Verified the steps, everything works great. Thanks for the fix!

…es route (linode#13034) * UIE-9456 & UIE-9457 * test * Added changeset: Typo + expose search filters on /iam/roles route

* feat: [UIE-9481] - IAM: add perm check for the drawer * Added changeset: IAM: add a permission check for delete nodebalancer drawer

…ode#13042) * feat: add empty state to Default Roles/Entities table * Added changeset: IAM: Empty state for the Default Roles and Default Entities Access tabs * update text * add unit tests * review fix * unit test fix

* fix: [UIE-9478] - IAM: disable tag edit * Added changeset: IAM: tags editing was enabled for restricted users * fix: [UIE-9478] - add tooltip, disable manage tags in Volume action menu * style fix

…8.0, UI version 0.23.0

… for < 1 hour (linode#13045) * fix: [M3-9498] - Update linode/clone endpoint and label calculations for < 1 hour * Add changelogs --------- Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>

…inode#13047) * try/cath child user query * consistent handling * types * Added changeset: IAM Child Account - user not found error handling

…hen user has no permissions (linode#13049) * fix: [UIE-9477] - IAM: Disable delete and detach popups for Volumes if no permissions * Added changeset: IAM: restricted users could access delete and detach popups without permissions

…lans (linode#13054) * upcoming: [UIE-9434] - Create feature flag for generational compute plans * Added changeset: Feature flag for Generational Compute plans

…Streams Landing (linode#13008)

… list table based on status (linode#13052) * refactor: [DI-27807] - Change status of edit & delete button in alert list table based on status * Added comment * Added changeset * refactor: [DI-27807] - Updated test cases

…ure flag (linode#13051) * Add firewall rs & pl feature flag * Added changeset: Feature flag for Firewall Rulesets & Prefixlists

…#13050) * UIE-9342 * UIE-9341 * feat: [UIE-9341, UIE-9342, UIE-9521] - IAM: fix perm for vpc * Added changeset: IAM: fix permissiom's check for vpc for assigning/unassigning linodes * filter linodes * e2e deferred getLinodes call --------- Co-authored-by: Alban Bailly <abailly@akamai.com>

…ssControlDrawer (linode#13044) ## Description 📝 Refactor Database Manage Networking drawer to use React Hook Form instead of Formik ## Changes 🔄 - There should be no visual external changes other than IP validation on blur instead of after clicking Update Access Controls ## How to test 🧪 ### Prerequisites (How to setup test environment) - Have the Database VPC feature flag enabled ### Verification steps (How to verify changes) - [ ] Test adding/editing IPs in the Database landing page via Manage Access Controls action dropdown - [ ] Test adding/editing IPs in the Database details page via the Networking tab - [ ] There should be no regressions compared to prod, error messages should display

… PrimaryNav (linode#13056) * attempt to rule out any race condition * comments * code and fixes * cleanup * Added changeset: Race condition with Preferences overrides in PrimaryNav

…ccount (linode#13033) * feat: [UIE-9393] - IAM Parent/Child: delegate permissions for child account * changesets * remove the unrestricted check for query * fix conflict * e2e gating * lint fix * better approach to fixing e2e * Mock IAM to be disabled in Account Switching test --------- Co-authored-by: Alban Bailly <abailly@akamai.com> Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com> Co-authored-by: Joe D'Amore <jdamore@akamai.com>

* feat: [UIE-9534] - IAM: add tooltips * Added changeset: IAM: add tooltips for disabled buttons for nodebalancers, remove notification banner * update text * remove tooltip

* change:[UIE-9541] Add MSW crud support for types API * Added changeset: Add MSW crud support for types API * Added changeset: Add MSW crud support for types API

linode-gh-bot · 2025-11-07T16:22:00Z

Cloud Manager UI test results

🔺 4 failing tests on test run #5 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`4 Failing`	`857 Passing`	`11 Skipped`	`49m 45s`

Details

Failing Tests
	Spec	Test
❌	`update-stackscripts.spec.ts`	Cloud Manager Cypress Tests→Update stackscripts » updates a StackScript
❌	`create-database.spec.ts`	Cloud Manager Cypress Tests→create a database cluster, mocked data » creates a g6-dedicated-2 MySQL v5.x 3-node cluster
❌	`create-database.spec.ts`	Cloud Manager Cypress Tests→create a database cluster, mocked data » creates a g6-nanode-1 PostgreSQL v13.x 3-node cluster
❌	`create-stackscripts.spec.ts`	Cloud Manager Cypress Tests→Create stackscripts » creates a StackScript and deploys a Linode with it

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/stackscripts/update-stackscripts.spec.ts,cypress/e2e/core/databases/create-database.spec.ts,cypress/e2e/core/stackscripts/create-stackscripts.spec.ts"

initial commit

263a8f6

abailly-akamai self-assigned this Oct 30, 2025

abailly-akamai added the IAM (Identity & Access Management) label Oct 30, 2025

github-project-automation Bot added this to Cloud Manager Oct 30, 2025

github-project-automation Bot moved this to Review in Cloud Manager Oct 30, 2025

abailly-akamai requested review from a team, aaleksee-akamai and mpolotsk-akamai and removed request for a team October 30, 2025 13:41

abailly-akamai marked this pull request as ready for review October 30, 2025 13:42

abailly-akamai requested a review from a team as a code owner October 30, 2025 13:42

Added changeset: Address oAuth issue with IAM OAuthCallback

01c8ec4

abailly-akamai commented Oct 30, 2025

View reviewed changes

Merge branch 'develop' into UIE-9500

84edb0e

aaleksee-akamai reviewed Nov 4, 2025

View reviewed changes

Comment thread packages/manager/src/features/IAM/hooks/useIsIAMEnabled.ts

aaleksee-akamai approved these changes Nov 4, 2025

View reviewed changes

mpolotsk-akamai approved these changes Nov 4, 2025

View reviewed changes

github-project-automation Bot moved this from Review to Approved in Cloud Manager Nov 4, 2025

dwiley-akamai approved these changes Nov 6, 2025

View reviewed changes

abailly-akamai and others added 10 commits November 7, 2025 16:21

fix: [UIE-9456 & UIE-9457] - Typo + expose search filters on /iam/rol…

e857f33

…es route (linode#13034) * UIE-9456 & UIE-9457 * test * Added changeset: Typo + expose search filters on /iam/roles route

feat: [UIE-9481] - IAM: add perm check for the drawer (linode#13043)

29ca572

* feat: [UIE-9481] - IAM: add perm check for the drawer * Added changeset: IAM: add a permission check for delete nodebalancer drawer

fix: [UIE-9478] - IAM: disable tag edit (linode#13046)

72d0fca

* fix: [UIE-9478] - IAM: disable tag edit * Added changeset: IAM: tags editing was enabled for restricted users * fix: [UIE-9478] - add tooltip, disable manage tags in Volume action menu * style fix

Cloud version 1.154.0, API v4 version 0.152.0, Validation version 0.7…

d94f216

…8.0, UI version 0.23.0

Cloud version 1.154.0, API v4 version 0.152.0, Validation version 0.7…

8ec1d54

…8.0, UI version 0.23.0

fix: [M3-10698] - Update linode/clone endpoint and label calculations…

cc6bd3f

… for < 1 hour (linode#13045) * fix: [M3-9498] - Update linode/clone endpoint and label calculations for < 1 hour * Add changelogs --------- Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com>

fix: [UIE-9520] - IAM Child Account - user not found error handling (l…

f2c0a3a

…inode#13047) * try/cath child user query * consistent handling * types * Added changeset: IAM Child Account - user not found error handling

upcoming: [UIE-9434] - Create feature flag for generational compute p…

7b7c410

…lans (linode#13054) * upcoming: [UIE-9434] - Create feature flag for generational compute plans * Added changeset: Feature flag for Generational Compute plans

mduda-akamai and others added 9 commits November 7, 2025 16:21

test: [DPS-34825] Add cypress tests for Create/Edit Stream forms and …

d86192b

…Streams Landing (linode#13008)

upcoming: [UIE-9368] - Create a firewall Rulesets & Preflixlists feat…

f671ee0

…ure flag (linode#13051) * Add firewall rs & pl feature flag * Added changeset: Feature flag for Firewall Rulesets & Prefixlists

[UIE-9533] -Hopeful fix: Race condition with Preferences overrides in…

e29e6bc

… PrimaryNav (linode#13056) * attempt to rule out any race condition * comments * code and fixes * cleanup * Added changeset: Race condition with Preferences overrides in PrimaryNav

feat: [UIE-9534] - IAM: fix perm for nodebalancer (linode#13058)

ea3bbf6

* feat: [UIE-9534] - IAM: add tooltips * Added changeset: IAM: add tooltips for disabled buttons for nodebalancers, remove notification banner * update text * remove tooltip

change:[UIE-9541] Add MSW crud support for types API (linode#13067)

9eb2a40

* change:[UIE-9541] Add MSW crud support for types API * Added changeset: Add MSW crud support for types API * Added changeset: Add MSW crud support for types API

abailly-akamai requested review from a team as code owners November 7, 2025 15:22

abailly-akamai requested review from cpathipa and dmcintyr-akamai and removed request for a team November 7, 2025 15:22

Merge branch 'develop' into UIE-9500

f9a1b16

abailly-akamai merged commit caabbdf into linode:develop Nov 7, 2025
34 of 35 checks passed

github-project-automation Bot moved this from Approved to Merged in Cloud Manager Nov 7, 2025

This was referenced Nov 13, 2025

Release v1.155.0 - release → staging #13085

Merged

Release v1.155.0 - staging → master #13101

Merged

abailly-akamai mentioned this pull request Nov 20, 2025

fix: [UIE-9661] - oAuth callback improvements #13105

Merged

7 tasks

Navigation Menu

Uh oh!

fix: [UIE-9500] - oAuth issue with IAM OAuthCallback - #13037

fix: [UIE-9500] - oAuth issue with IAM OAuthCallback#13037
abailly-akamai merged 23 commits into
linode:developfrom
abailly-akamai:UIE-9500

abailly-akamai commented Oct 30, 2025 •

edited

Loading

Uh oh!

abailly-akamai Oct 30, 2025

Uh oh!

aaleksee-akamai Nov 4, 2025

Uh oh!

Uh oh!

aaleksee-akamai left a comment

Uh oh!

mpolotsk-akamai left a comment

Uh oh!

linode-gh-bot commented Nov 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Uh oh!

Conversation

abailly-akamai commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Changes 🔄

Scope 🚢

Preview 📷

How to test 🧪

Prerequisites

Reproduction steps

Verification steps

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

Uh oh!

abailly-akamai Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

aaleksee-akamai Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aaleksee-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

mpolotsk-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

linode-gh-bot commented Nov 7, 2025

Cloud Manager UI test results

🔺 4 failing tests on test run #5 ↗︎

Details

Troubleshooting

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

abailly-akamai commented Oct 30, 2025 •

edited

Loading