feat: [UIE-9341, UIE-9342, UIE-9521] - IAM: fix perm for vpcs by aaleksee-akamai · Pull Request #13050 · linode/manager

aaleksee-akamai · 2025-11-03T16:59:30Z

Description 📝

This PR fixes the permission's check for vpcs

Changes 🔄

List any change(s) relevant to the reviewer.

Remove update_vpc permission check to assign/unassign linodes
Update tests
Cleanup

Scope 🚢

Upon production release, changes in this PR will be visible to:

All customers
Some customers (e.g. in Beta or Limited Availability)
No customers / Not applicable

Target release date 🗓️

11/18

How to test 🧪

Prerequisites

(How to setup test environment)

use iam account with vpc_viewer and linode_admin roles.

Reproduction steps

(How to reproduce the issue, if applicable)
1.

Go to /vpcs/[vpcId] route
Expand subnet row
Click the action menu of the Linode with the linode_admin role
Click Assign/Unassign Linode option

Go to /vpcs/[vpcId] route
Click the action menu for subnet

Verification steps

(How to verify changes)

The menu actions for assign/unassign linodes are enabled
Linodes are filtered by permission in the drawer

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All tests and CI checks are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

…assigning linodes

abailly-akamai

Confirmed removing update_vpc still allows restricted users to assign linodes to a subnet ✅

mpolotsk-akamai

All works as expected, thanks!

kwojtowiakamai · 2025-11-05T12:58:13Z

In the Linodes selector in the Unassign Linodes Drawer I'm still seeing Linodes without delete_linode_config_profile_interface (delete_linode).

aaleksee-akamai · 2025-11-05T14:01:13Z

@kwojtowiakamai , thanks! I've pushed the changes, could you please check again?

my roles:

linodes to unassign:

aaleksee-akamai · 2025-11-05T14:04:00Z

-
-    const { data: permissions } = usePermissions('vpc', ['update_vpc'], vpcId);
-    // TODO: change to 'delete_linode_config_profile_interface' once it's available
-    const { data: filteredLinodes, isLoading: isLoadingFilteredLinodes } =


the issue that we didn't see filtered linodes by permission on the autocomplete because we didn't use filteredLinodes instead it was findAssignedLinodes

kwojtowiakamai

Now it works correctly. Thanks @aaleksee-akamai!

aaleksee-akamai · 2025-11-05T14:19:30Z

@abailly-akamai , @mpolotsk-akamai , I’ve pushed some changes after your approval. Would you like to take another look, or should I go ahead and merge the PR? (was approved by @kwojtowiakamai )

abailly-akamai · 2025-11-06T12:13:07Z

      .should('be.visible')
      .click();

+    cy.wait(['@getLinodes']);


@aaleksee-akamai because of deferring the getLinodes call to when the drawer is open we have to adjust the test accordingly. All good here 👍

linode-gh-bot · 2025-11-06T13:03:55Z

Cloud Manager UI test results

🔺 4 failing tests on test run #5 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`4 Failing`	`849 Passing`	`11 Skipped`	`45m 13s`

Details

Failing Tests
	Spec	Test
❌	`create-stackscripts.spec.ts`	Cloud Manager Cypress Tests→Create stackscripts » creates a StackScript and deploys a Linode with it
❌	`update-stackscripts.spec.ts`	Cloud Manager Cypress Tests→Update stackscripts » updates a StackScript
❌	`timerange-verification.spec.ts`	Cloud Manager Cypress Tests→Integration tests for verifying Cloudpulse custom and preset configurations » should implement and validate custom date/time picker for a specific date and time range
❌	`clone-linode.spec.ts`	Cloud Manager Cypress Tests→clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/stackscripts/create-stackscripts.spec.ts,cypress/e2e/core/stackscripts/update-stackscripts.spec.ts,cypress/e2e/core/cloudpulse/timerange-verification.spec.ts,cypress/e2e/core/linodes/clone-linode.spec.ts"

…#13050) * UIE-9342 * UIE-9341 * feat: [UIE-9341, UIE-9342, UIE-9521] - IAM: fix perm for vpc * Added changeset: IAM: fix permissiom's check for vpc for assigning/unassigning linodes * filter linodes * e2e deferred getLinodes call --------- Co-authored-by: Alban Bailly <abailly@akamai.com>

* initial commit * Added changeset: Address oAuth issue with IAM OAuthCallback * fix: [UIE-9456 & UIE-9457] - Typo + expose search filters on /iam/roles route (#13034) * UIE-9456 & UIE-9457 * test * Added changeset: Typo + expose search filters on /iam/roles route * feat: [UIE-9481] - IAM: add perm check for the drawer (#13043) * feat: [UIE-9481] - IAM: add perm check for the drawer * Added changeset: IAM: add a permission check for delete nodebalancer drawer * feat: [UIE-9503] - add empty state to Default Roles/Entities tab (#13042) * feat: add empty state to Default Roles/Entities table * Added changeset: IAM: Empty state for the Default Roles and Default Entities Access tabs * update text * add unit tests * review fix * unit test fix * fix: [UIE-9478] - IAM: disable tag edit (#13046) * fix: [UIE-9478] - IAM: disable tag edit * Added changeset: IAM: tags editing was enabled for restricted users * fix: [UIE-9478] - add tooltip, disable manage tags in Volume action menu * style fix * Cloud version 1.154.0, API v4 version 0.152.0, Validation version 0.78.0, UI version 0.23.0 * Cloud version 1.154.0, API v4 version 0.152.0, Validation version 0.78.0, UI version 0.23.0 * fix: [M3-10698] - Update linode/clone endpoint and label calculations for < 1 hour (#13045) * fix: [M3-9498] - Update linode/clone endpoint and label calculations for < 1 hour * Add changelogs --------- Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> * fix: [UIE-9520] - IAM Child Account - user not found error handling (#13047) * try/cath child user query * consistent handling * types * Added changeset: IAM Child Account - user not found error handling * fix: [UIE-9477] - IAM: disable delete and detach popups for Volumes when user has no permissions (#13049) * fix: [UIE-9477] - IAM: Disable delete and detach popups for Volumes if no permissions * Added changeset: IAM: restricted users could access delete and detach popups without permissions * upcoming: [UIE-9434] - Create feature flag for generational compute plans (#13054) * upcoming: [UIE-9434] - Create feature flag for generational compute plans * Added changeset: Feature flag for Generational Compute plans * test: [DPS-34825] Add cypress tests for Create/Edit Stream forms and Streams Landing (#13008) * refactor: [DI-27807] - Change status of edit & delete button in alert list table based on status (#13052) * refactor: [DI-27807] - Change status of edit & delete button in alert list table based on status * Added comment * Added changeset * refactor: [DI-27807] - Updated test cases * upcoming: [UIE-9368] - Create a firewall Rulesets & Preflixlists feature flag (#13051) * Add firewall rs & pl feature flag * Added changeset: Feature flag for Firewall Rulesets & Prefixlists * feat: [UIE-9341, UIE-9342, UIE-9521] - IAM: fix perm for vpcs (#13050) * UIE-9342 * UIE-9341 * feat: [UIE-9341, UIE-9342, UIE-9521] - IAM: fix perm for vpc * Added changeset: IAM: fix permissiom's check for vpc for assigning/unassigning linodes * filter linodes * e2e deferred getLinodes call --------- Co-authored-by: Alban Bailly <abailly@akamai.com> * refactor: [UIE-9325] - Replace Formik with React Hook Form in AddAccessControlDrawer (#13044) ## Description 📝 Refactor Database Manage Networking drawer to use React Hook Form instead of Formik ## Changes 🔄 - There should be no visual external changes other than IP validation on blur instead of after clicking Update Access Controls ## How to test 🧪 ### Prerequisites (How to setup test environment) - Have the Database VPC feature flag enabled ### Verification steps (How to verify changes) - [ ] Test adding/editing IPs in the Database landing page via Manage Access Controls action dropdown - [ ] Test adding/editing IPs in the Database details page via the Networking tab - [ ] There should be no regressions compared to prod, error messages should display * [UIE-9533] -Hopeful fix: Race condition with Preferences overrides in PrimaryNav (#13056) * attempt to rule out any race condition * comments * code and fixes * cleanup * Added changeset: Race condition with Preferences overrides in PrimaryNav * feat: [UIE-9393] - IAM Parent/Child: delegate permissions for child account (#13033) * feat: [UIE-9393] - IAM Parent/Child: delegate permissions for child account * changesets * remove the unrestricted check for query * fix conflict * e2e gating * lint fix * better approach to fixing e2e * Mock IAM to be disabled in Account Switching test --------- Co-authored-by: Alban Bailly <abailly@akamai.com> Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com> Co-authored-by: Joe D'Amore <jdamore@akamai.com> * feat: [UIE-9534] - IAM: fix perm for nodebalancer (#13058) * feat: [UIE-9534] - IAM: add tooltips * Added changeset: IAM: add tooltips for disabled buttons for nodebalancers, remove notification banner * update text * remove tooltip * change:[UIE-9541] Add MSW crud support for types API (#13067) * change:[UIE-9541] Add MSW crud support for types API * Added changeset: Add MSW crud support for types API * Added changeset: Add MSW crud support for types API --------- Co-authored-by: aaleksee-akamai <aaleksee@akamai.com> Co-authored-by: mpolotsk-akamai <157619599+mpolotsk-akamai@users.noreply.github.com> Co-authored-by: Dajahi Wiley <dwiley@linode.com> Co-authored-by: Jaalah Ramos <125309814+jaalah-akamai@users.noreply.github.com> Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> Co-authored-by: grevanak-akamai <145482092+grevanak-akamai@users.noreply.github.com> Co-authored-by: mduda-akamai <mduda@akamai.com> Co-authored-by: Nikhil Agrawal <165884194+nikhagra-akamai@users.noreply.github.com> Co-authored-by: Purvesh Makode <pmakode@akamai.com> Co-authored-by: Hana Xu <115299789+hana-akamai@users.noreply.github.com> Co-authored-by: Joe D'Amore <jdamore@akamai.com>

aaleksee-akamai added 3 commits November 3, 2025 14:49

UIE-9342

f852163

UIE-9341

97c2f21

feat: [UIE-9341, UIE-9342, UIE-9521] - IAM: fix perm for vpc

fbf60fe

aaleksee-akamai self-assigned this Nov 3, 2025

aaleksee-akamai requested a review from a team as a code owner November 3, 2025 16:59

aaleksee-akamai added VPC Relating to VPC project IAM (Identity & Access Management) labels Nov 3, 2025

github-project-automation Bot moved this to Review in Cloud Manager Nov 3, 2025

github-project-automation Bot added this to Cloud Manager Nov 3, 2025

aaleksee-akamai requested review from abailly-akamai, kwojtowiakamai and mpolotsk-akamai November 3, 2025 16:59

Added changeset: IAM: fix permissiom's check for vpc for assigning/un…

f8375c4

…assigning linodes

abailly-akamai approved these changes Nov 4, 2025

View reviewed changes

aaleksee-akamai commented Nov 4, 2025

View reviewed changes

Comment thread packages/manager/src/features/VPCs/VPCDetail/SubnetAssignLinodesDrawer.tsx

mpolotsk-akamai approved these changes Nov 4, 2025

View reviewed changes

github-project-automation Bot moved this from Review to Approved in Cloud Manager Nov 4, 2025

mpolotsk-akamai reviewed Nov 5, 2025

View reviewed changes

Comment thread packages/manager/src/features/VPCs/VPCDetail/SubnetAssignLinodesDrawer.tsx

filter linodes

f0aaafe

aaleksee-akamai commented Nov 5, 2025

View reviewed changes

kwojtowiakamai approved these changes Nov 5, 2025

View reviewed changes

aaleksee-akamai and others added 2 commits November 5, 2025 17:34

Merge branch 'develop' into UIE-9341-iam-vpc-perm-fix

7e76469

e2e deferred getLinodes call

b529b42

abailly-akamai requested a review from a team as a code owner November 6, 2025 12:11

abailly-akamai requested review from jdamore-linode and removed request for a team November 6, 2025 12:11

abailly-akamai reviewed Nov 6, 2025

View reviewed changes

aaleksee-akamai merged commit 6d4337d into linode:develop Nov 6, 2025
58 of 60 checks passed

github-project-automation Bot moved this from Approved to Merged in Cloud Manager Nov 6, 2025

This was referenced Nov 13, 2025

Release v1.155.0 - release → staging #13085

Merged

Release v1.155.0 - staging → master #13101

Merged

Navigation Menu

Uh oh!

feat: [UIE-9341, UIE-9342, UIE-9521] - IAM: fix perm for vpcs - #13050

feat: [UIE-9341, UIE-9342, UIE-9521] - IAM: fix perm for vpcs#13050
aaleksee-akamai merged 7 commits into
linode:developfrom
aaleksee-akamai:UIE-9341-iam-vpc-perm-fix

aaleksee-akamai commented Nov 3, 2025

Uh oh!

abailly-akamai left a comment

Uh oh!

Uh oh!

mpolotsk-akamai left a comment

Uh oh!

kwojtowiakamai commented Nov 5, 2025

Uh oh!

Uh oh!

aaleksee-akamai commented Nov 5, 2025

Uh oh!

aaleksee-akamai Nov 5, 2025

Uh oh!

kwojtowiakamai left a comment

Uh oh!

aaleksee-akamai commented Nov 5, 2025

Uh oh!

abailly-akamai Nov 6, 2025

Uh oh!

linode-gh-bot commented Nov 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

aaleksee-akamai commented Nov 3, 2025

Description 📝

Changes 🔄

Scope 🚢

Target release date 🗓️

How to test 🧪

Prerequisites

Reproduction steps

Verification steps

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

Uh oh!

abailly-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mpolotsk-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

kwojtowiakamai commented Nov 5, 2025

Uh oh!

Uh oh!

aaleksee-akamai commented Nov 5, 2025

Uh oh!

aaleksee-akamai Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

kwojtowiakamai left a comment

Choose a reason for hiding this comment

Uh oh!

aaleksee-akamai commented Nov 5, 2025

Uh oh!

abailly-akamai Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

linode-gh-bot commented Nov 6, 2025

Cloud Manager UI test results

🔺 4 failing tests on test run #5 ↗︎

Details

Troubleshooting

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants