Use ReactDOM webpack external - #586
Merged
Merged
Conversation
Codecov ReportBase: 15.80% // Head: 15.80% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #586 +/- ##
=======================================
Coverage 15.80% 15.80%
=======================================
Files 15 15
Lines 4201 4201
=======================================
Hits 664 664
Misses 3494 3494
Partials 43 43 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
catalintomai
approved these changes
Sep 21, 2022
hanzei
approved these changes
Sep 21, 2022
hanzei
added
the
4: Reviews Complete
DHaussermann
approved these changes
Sep 28, 2022
DHaussermann
left a comment
DHaussermann
left a comment
There was a problem hiding this comment.
Tested and passed
Exploratory testing done with the issue creation. The crash is no longer reproducible.
LGTM!
mickmister
added a commit
that referenced
this pull request
Oct 1, 2022
mickmister
added a commit
that referenced
this pull request
Oct 31, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-47046