Skip to content

Release 2.1.3 - #589

Merged
mickmister merged 4 commits into
release-2.1.3from
release-bump-2.1.3
Oct 31, 2022
Merged

Release 2.1.3#589
mickmister merged 4 commits into
release-2.1.3from
release-bump-2.1.3

Conversation

@mickmister

@mickmister mickmister commented Oct 1, 2022

Copy link
Copy Markdown
Contributor

@mickmister
mickmister requested a review from hanzei as a code owner October 1, 2022 12:29
@mickmister mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Oct 1, 2022
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Base: 15.51% // Head: 15.51% // No change to project coverage 👍

Coverage data is based on head (cd64636) compared to base (d13f5a5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff               @@
##           release-2.1.3     #589   +/-   ##
==============================================
  Coverage          15.51%   15.51%           
==============================================
  Files                 15       15           
  Lines               4151     4151           
==============================================
  Hits                 644      644           
  Misses              3465     3465           
  Partials              42       42           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Oct 3, 2022
@hanzei

hanzei commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

Do we really need a patch release? Can we stick with #583?

@mickmister

Copy link
Copy Markdown
Contributor Author

@hanzei The idea was to get this fix on community sooner, but I'm up for using the existing release cc @DHaussermann

@hanzei

hanzei commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

Do we need a fix on Community soon, given that mattermost/mattermost-webapp#11232 was merged?

@DHaussermann

Copy link
Copy Markdown

@mickmister Do we still want to proceed with this release given the react changes in the last few days?

@hanzei hanzei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the linter fixes

@mickmister
mickmister requested a review from hanzei October 31, 2022 12:05
@mickmister

Copy link
Copy Markdown
Contributor Author

@hanzei Merging since the linting fixes here are all ioutil -> io and errors.Errorf -> errors.New

@mickmister
mickmister merged commit 1be093c into release-2.1.3 Oct 31, 2022
@mickmister
mickmister deleted the release-bump-2.1.3 branch October 31, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3: QA Review Requires review by a QA tester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants