Release 2.1.8 - #720
Merged
Merged
Release 2.1.8#720
Conversation
…ed" event (#718) * [MI-3808] Fix issue: Subscription notification not working for pull request "reopened" event. * [MI-3808] Added test case for new template * [MI-3808] Review fix
avas27JTG
approved these changes
Dec 12, 2023
hanzei
approved these changes
Dec 12, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-2.1 #720 +/- ##
==============================================
Coverage ? 15.42%
==============================================
Files ? 15
Lines ? 5206
Branches ? 0
==============================================
Hits ? 803
Misses ? 4361
Partials ? 42 ☔ View full report in Codecov by Sentry. |
hanzei
requested changes
Dec 12, 2023
hanzei
left a comment
hanzei
left a comment
Contributor
There was a problem hiding this comment.
Are we sure that the notification issue @amyblais run into (https://community.mattermost.com/core/pl/eoye7unqrigjj8uitkgbr7bgow) isn't caused by the changes to the webhook?
hanzei
approved these changes
Dec 12, 2023
Contributor
Author
|
I've confirmed the reopen feature works correctly:
|
mickmister
added
4: Reviews Complete
|
Tested and approved, LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary