[GH-717] Implement subscription notification for pull request "reopened" event - #718
Merged
Conversation
…equest "reopened" event.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #718 +/- ##
==========================================
+ Coverage 15.49% 15.79% +0.30%
==========================================
Files 15 15
Lines 5737 5767 +30
==========================================
+ Hits 889 911 +22
- Misses 4806 4814 +8
Partials 42 42 ☔ View full report in Codecov by Sentry. |
hanzei
added
2: Dev Review
mickmister
changed the title
mickmister
approved these changes
Dec 4, 2023
mickmister
left a comment
mickmister
left a comment
Contributor
There was a problem hiding this comment.
LGTM, one non-blocking suggestion to clean up the existing code a bit with a switch statement
Merged
avas27JTG
approved these changes
Dec 4, 2023
Author
|
@mickmister FIxed the review comments mentioned by you |
mickmister
approved these changes
Dec 4, 2023
hanzei
approved these changes
Dec 4, 2023
AayushChaudhary0001
approved these changes
Dec 5, 2023
AayushChaudhary0001
left a comment
AayushChaudhary0001
left a comment
There was a problem hiding this comment.
Tested and approved
Working fine for reopened pull requests, LGTM.
hanzei
added
4: Reviews Complete
4 tasks
mickmister
pushed a commit
that referenced
this pull request
Dec 12, 2023
…ed" event (#718) * [MI-3808] Fix issue: Subscription notification not working for pull request "reopened" event. * [MI-3808] Added test case for new template * [MI-3808] Review fix
Merged
mickmister
added a commit
that referenced
this pull request
Dec 13, 2023
* [GH-717] Implement subscription notification for pull request "reopened" event (#718) * [MI-3808] Fix issue: Subscription notification not working for pull request "reopened" event. * [MI-3808] Added test case for new template * [MI-3808] Review fix * bump version to 2.1.8 --------- Co-authored-by: Raghav Aggarwal <raghav.aggarwal@brightscout.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshot:
What to test?
Steps to reproduce:
Expected behavior:
Environment:
MM version: v9.2.2
Node version: 14.18.0
Go version: 1.20.11
Ticket Link
Fixes #717