Repository navigation
Resolve the active defer usage set of a selection once per request - #188
Open
michaelstaib wants to merge 22 commits into
Open
michaelstaib wants to merge 22 commits into
michaelstaib wants to merge 22 commits into
Conversation
… object does not hold its whole selection set (#117) * [Execution] Verify the selection row before ResultElement.TryGetProperty answers from the selection set * Shorten the arrange comments of the result property lookup tests
…shared field is deferred
…enabled inner defer
…er and add an opt-in overlap check
… of deferred result streams
…lap and cover the other-length and mismatched-kind rejections
…s into mst/execution-defer-disabled-shared-field
…overlap into mst/execution-defer-usage-sets
… of a defer usage
… result snapshots
…/execution-defer-request-sets
…e set table tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues the work to execute a field shared by sibling deferred fragments once. There is no behavior change and no change to what is sent.
This branch merges #187 (interned defer usage sets) because the table is built on the interned sets.
Per-request defer usage set table:
@defer(if:)values. A disabled usage folds into its nearest enabled parent, duplicates are removed, and a usage nested below another usage of the set is dropped.Callers:
Stacked on #184.
Tests:
DeferUsageSetTableTestscover the static, dropped, folded and pruned cases, per-request interning, and sets compiled after the table was created. Two allocation tests check that a list under a disabled or alternating@deferdoes not allocate per object. Execution.Tests pass on net10.0, the defer and stream tests pass on net8.0, and the cursor pagination and stream page connection suites pass unchanged.