.NET: Stabilize Foundry recovery tests - #7817
Conversation
There was a problem hiding this comment.
Pull request overview
Synchronizes the Foundry recovery test with persisted checkpoint state instead of live HTTP output.
Changes:
- Polls the persisted response file for expected output.
- Retries file-read failures and improves timeout diagnostics.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): 03e9ab871403
Model: gpt-5.6-sol
Overview
This test-only change replaces synchronization against live HTTP output with polling of the durable response envelope before stopping the first host. Exact ordered-output checks, bounded polling, post-shutdown persistence assertions, and end-to-end recovery assertions constrain the behavior well. No Critical, High, or Medium defect was established.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Updated [Microsoft.Agents.AI](https://github.com/microsoft/agent-framework) from 1.19.0 to 1.20.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Agents.AI's releases](https://github.com/microsoft/agent-framework/releases)._ ## 1.20.0 ## What's Changed * .NET: Bump AWSSDK.Extensions.Bedrock.MEAI from 4.0.6.10 to 4.0.101.8 by @dependabot[bot] in microsoft/agent-framework#7829 * .NET: Stabilize Foundry recovery tests by @rogerbarreto in microsoft/agent-framework#7817 * .NET: fix: preserve Responses logprobs field by @he-yufeng in microsoft/agent-framework#5860 * .NET: Honor cancellation for Foundry-hosted workflow responses by @rogerbarreto with @Copilot in microsoft/agent-framework#7842 * .NET: Use Responses API for hosted web search in AG-UI by @rogerbarreto with @Copilot in microsoft/agent-framework#7843 * .NET: Bump Aspire.Hosting from 13.1.0 to 13.5.2 by @dependabot[bot] in microsoft/agent-framework#7826 * .NET: Suppress false positive Zip Slip alert by @SergeyMenshykh in microsoft/agent-framework#7858 * .NET: added Mem0Sharp integration for in-memory storage in agent samples. by @jihadkhawaja in microsoft/agent-framework#7792 * .NET: Annotate DevUI aggregator static-analysis false positives by @SergeyMenshykh in microsoft/agent-framework#7864 * .NET: Rename CommunityToolkit.VectorData.CosmosNoSql to AzureCosmosDB by @adamsitnik in microsoft/agent-framework#7878 * .NET: chore: upgrades aspnet openapi dependency by @baywet in microsoft/agent-framework#7870 * .NET: Simplify A2A function tool samples by @SergeyMenshykh in microsoft/agent-framework#7861 * .NET: Bump Azure.AI.AgentServer.Invocations from 1.0.0-beta.5 to 1.0.0-beta.6 by @dependabot[bot] in microsoft/agent-framework#7886 * .NET: docs: updates the contributing information for CFS users by @baywet in microsoft/agent-framework#7869 * Bump CommunityToolkit.VectorData.InMemory from 1.0.0 to 1.0.1 by @dependabot[bot] in microsoft/agent-framework#7888 * .NET: Remove retired OpenAI Assistants integration tests by @rogerbarreto in microsoft/agent-framework#7896 * .NET: Simplify A2A client-server sample by @SergeyMenshykh in microsoft/agent-framework#7891 * Bump Dapr.AI.Microsoft.Extensions from 1.18.4 to 1.18.5 by @dependabot[bot] in microsoft/agent-framework#7889 * .NET: docs/workflow fileinput sample dotnet by @baywet in microsoft/agent-framework#7913 * .NET: Add timeout for wait-for-first-completion by @westey-m in microsoft/agent-framework#7911 * .NET: Fix duplicate Foundry AgentHost port binding by @rogerbarreto in microsoft/agent-framework#7932 * .NET: tests: removes dependency on fluent assersion because of licensing concerns by @baywet in microsoft/agent-framework#7938 * .NET: docs(decisions): resolve duplicate ADR sequence numbers (0016, 0021, 0024) by @jluocsa in microsoft/agent-framework#6046 * .NET: Bump Azure.Core from 1.61.0 to 1.62.0 by @dependabot[bot] in microsoft/agent-framework#7954 * .NET: Improve Cosmos DB Emulator startup reliability by @TheovanKraay in microsoft/agent-framework#3932 * .NET: add public API analyzers by @baywet in microsoft/agent-framework#7935 * .NET: Update version for 1.20.0 release by @SergeyMenshykh in microsoft/agent-framework#7972 ## New Contributors * @madanmishra1223 made their first contribution in microsoft/agent-framework#7705 * @YashvantHange made their first contribution in microsoft/agent-framework#7850 * @jihadkhawaja made their first contribution in microsoft/agent-framework#7792 * @adamsitnik made their first contribution in microsoft/agent-framework#7878 * @baywet made their first contribution in microsoft/agent-framework#7870 * @Namraa310806 made their first contribution in microsoft/agent-framework#7901 * @Sweetteabittersugar made their first contribution in microsoft/agent-framework#7903 * @shoemoney made their first contribution in microsoft/agent-framework#7837 * @jluocsa made their first contribution in microsoft/agent-framework#6046 **Full Changelog**: microsoft/agent-framework@dotnet-1.19.0...dotnet-1.20.0 Commits viewable in [compare view](microsoft/agent-framework@dotnet-1.19.0...dotnet-1.20.0). </details> Updated [Microsoft.Agents.AI.OpenAI](https://github.com/microsoft/agent-framework) from 1.19.0 to 1.20.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Agents.AI.OpenAI's releases](https://github.com/microsoft/agent-framework/releases)._ ## 1.20.0 ## What's Changed * .NET: Bump AWSSDK.Extensions.Bedrock.MEAI from 4.0.6.10 to 4.0.101.8 by @dependabot[bot] in microsoft/agent-framework#7829 * .NET: Stabilize Foundry recovery tests by @rogerbarreto in microsoft/agent-framework#7817 * .NET: fix: preserve Responses logprobs field by @he-yufeng in microsoft/agent-framework#5860 * .NET: Honor cancellation for Foundry-hosted workflow responses by @rogerbarreto with @Copilot in microsoft/agent-framework#7842 * .NET: Use Responses API for hosted web search in AG-UI by @rogerbarreto with @Copilot in microsoft/agent-framework#7843 * .NET: Bump Aspire.Hosting from 13.1.0 to 13.5.2 by @dependabot[bot] in microsoft/agent-framework#7826 * .NET: Suppress false positive Zip Slip alert by @SergeyMenshykh in microsoft/agent-framework#7858 * .NET: added Mem0Sharp integration for in-memory storage in agent samples. by @jihadkhawaja in microsoft/agent-framework#7792 * .NET: Annotate DevUI aggregator static-analysis false positives by @SergeyMenshykh in microsoft/agent-framework#7864 * .NET: Rename CommunityToolkit.VectorData.CosmosNoSql to AzureCosmosDB by @adamsitnik in microsoft/agent-framework#7878 * .NET: chore: upgrades aspnet openapi dependency by @baywet in microsoft/agent-framework#7870 * .NET: Simplify A2A function tool samples by @SergeyMenshykh in microsoft/agent-framework#7861 * .NET: Bump Azure.AI.AgentServer.Invocations from 1.0.0-beta.5 to 1.0.0-beta.6 by @dependabot[bot] in microsoft/agent-framework#7886 * .NET: docs: updates the contributing information for CFS users by @baywet in microsoft/agent-framework#7869 * Bump CommunityToolkit.VectorData.InMemory from 1.0.0 to 1.0.1 by @dependabot[bot] in microsoft/agent-framework#7888 * .NET: Remove retired OpenAI Assistants integration tests by @rogerbarreto in microsoft/agent-framework#7896 * .NET: Simplify A2A client-server sample by @SergeyMenshykh in microsoft/agent-framework#7891 * Bump Dapr.AI.Microsoft.Extensions from 1.18.4 to 1.18.5 by @dependabot[bot] in microsoft/agent-framework#7889 * .NET: docs/workflow fileinput sample dotnet by @baywet in microsoft/agent-framework#7913 * .NET: Add timeout for wait-for-first-completion by @westey-m in microsoft/agent-framework#7911 * .NET: Fix duplicate Foundry AgentHost port binding by @rogerbarreto in microsoft/agent-framework#7932 * .NET: tests: removes dependency on fluent assersion because of licensing concerns by @baywet in microsoft/agent-framework#7938 * .NET: docs(decisions): resolve duplicate ADR sequence numbers (0016, 0021, 0024) by @jluocsa in microsoft/agent-framework#6046 * .NET: Bump Azure.Core from 1.61.0 to 1.62.0 by @dependabot[bot] in microsoft/agent-framework#7954 * .NET: Improve Cosmos DB Emulator startup reliability by @TheovanKraay in microsoft/agent-framework#3932 * .NET: add public API analyzers by @baywet in microsoft/agent-framework#7935 * .NET: Update version for 1.20.0 release by @SergeyMenshykh in microsoft/agent-framework#7972 ## New Contributors * @madanmishra1223 made their first contribution in microsoft/agent-framework#7705 * @YashvantHange made their first contribution in microsoft/agent-framework#7850 * @jihadkhawaja made their first contribution in microsoft/agent-framework#7792 * @adamsitnik made their first contribution in microsoft/agent-framework#7878 * @baywet made their first contribution in microsoft/agent-framework#7870 * @Namraa310806 made their first contribution in microsoft/agent-framework#7901 * @Sweetteabittersugar made their first contribution in microsoft/agent-framework#7903 * @shoemoney made their first contribution in microsoft/agent-framework#7837 * @jluocsa made their first contribution in microsoft/agent-framework#6046 **Full Changelog**: microsoft/agent-framework@dotnet-1.19.0...dotnet-1.20.0 Commits viewable in [compare view](microsoft/agent-framework@dotnet-1.19.0...dotnet-1.20.0). </details> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Motivation & Context
Two Foundry recovery tests could observe state before the platform finished the durable operation they intended to verify.
The local two lifetime unit test stopped the host after the live HTTP response exposed new output, but before AgentServer had saved the matching checkpoint. The live integration test ended the process immediately after the workflow input stage, which could race the first durable recovery boundary and leave a completed response containing only workflow action items. During process replacement, response polling can also return HTTP 409
session_updatingand explicitly ask the caller to retry.Description & Review Guide
Related Issue
Fixes #7816
Contribution Checklist
breaking changelabel (or add "[BREAKING]" to the title prefix, before or after any language prefix). A workflow keeps the label and title prefix in sync automatically.