Skip to content

feat: add support for custom bundle root - #529

Merged
Tommy Nguyen (tido64) merged 3 commits into
trunkfrom
tido/bundle-root
Sep 28, 2021
Merged

feat: add support for custom bundle root#529
Tommy Nguyen (tido64) merged 3 commits into
trunkfrom
tido/bundle-root

Conversation

@tido64

Copy link
Copy Markdown
Member

Description

Adds support for custom bundle root.

Resolves #525.

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

  1. When bundleRoot is unset, test app should use index and main as bundle root.
  2. When bundleRoot is set, test app should only use the set value as bundle root.

Comment thread windows/ReactTestApp/ReactInstance.h
@tido64 Tommy Nguyen (tido64) mentioned this pull request Sep 27, 2021
31 tasks
Base automatically changed from tido/auto-populate to trunk September 27, 2021 12:42
Comment thread android/app/src/main/java/com/microsoft/reacttestapp/TestApp.kt
@tido64
Tommy Nguyen (tido64) merged commit 711f9f8 into trunk Sep 28, 2021
@tido64
Tommy Nguyen (tido64) deleted the tido/bundle-root branch September 28, 2021 13:53
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 0.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: Windows This affects Windows released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow custom bundle roots

2 participants