Skip to content

Breaking changes in 1.0 - #496

Merged
Tommy Nguyen (tido64) merged 5 commits into
trunkfrom
tido/1.0
Jan 26, 2022
Merged

Breaking changes in 1.0#496
Tommy Nguyen (tido64) merged 5 commits into
trunkfrom
tido/1.0

Conversation

@tido64

@tido64 Tommy Nguyen (tido64) commented Sep 16, 2021

Copy link
Copy Markdown
Member

Description

This PR contains breaking changes and will bump the version number to 1.0:

  • Drop support for react-native 0.60 and 0.61
  • Android:
    • Remove workaround for trove4j
    • Bump minimum Android SDK version to 23
    • Bump Android Gradle Plugin to v7
      • JDK 11 is now required to run Gradle (details)
    • Bump Gradle to v7
    • Use buildToolsVersion set by Gradle
  • iOS/macOS:
    • Bump C++ standard to C++17

Blocked by:

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

CI should be green.

BREAKING CHANGE: react-native 0.60 and 0.61 are no longer supported.
Deprecated methods have also been removed.
BREAKING CHANGE: `android/force-resolve-trove4j.gradle` has been
removed.

`org.jetbrains.trove4j:trove4j` has been uploaded to Maven Central:
https://search.maven.org/artifact/org.jetbrains.trove4j/trove4j/20160824/jar
@tido64

Copy link
Copy Markdown
Member Author

Araz Abishov (@arazabishov), Lorenzo Sciandra (@kelset), Sam Mathias Weggersen (@sweggersen), Tom Underhill (@tom-un): Please review this whenever you have time. Thanks ❤️

@kelset Lorenzo Sciandra (kelset) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@tido64
Tommy Nguyen (tido64) merged commit a6f8601 into trunk Jan 26, 2022
@tido64
Tommy Nguyen (tido64) deleted the tido/1.0 branch January 26, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants