fix: add support for react-native 0.67

[Tommy Nguyen (tido64)]

Description

Add support for react-native 0.67

Discussion: reactwg/react-native-releases#1

Platforms affected

• Android
• iOS
• macOS
• Windows

Test plan

1. Set react-native version: npm run set-react-version 0.67
2. Run yarn
3. Ensure that the test apps build and run
   • Android
   • iOS (Hermes)
   • iOS (JSC)
   • Windows

Platform	Home	App
Android
iOS (Hermes)
iOS (JSC)
Windows	n/a

[Tommy Nguyen (tido64)]

Android build fails:

Error: Command failed: ./gradlew installDebug -PreactNativeDevServerPort=8081
w: Runtime JAR files in the classpath should have the same version. These files were found in the classpath:
    /~/.gradle/caches/transforms-3/5124617d1ddf91cc93fc6a31dff02f7e/transformed/jetified-kotlin-stdlib-jdk8-1.4.10.jar (version 1.4)
    /~/.gradle/caches/transforms-3/4c60554dec6a1e41e228dda600ed4226/transformed/jetified-kotlin-stdlib-jdk7-1.5.31.jar (version 1.5)
    /~/.gradle/caches/transforms-3/b50f79cfa342cda80725cbbd9a11dc6c/transformed/jetified-kotlin-reflect-1.5.31.jar (version 1.5)
    /~/.gradle/caches/transforms-3/46bb811c6535b7abbf989788fb375eb0/transformed/jetified-kotlin-stdlib-1.5.31.jar (version 1.5)
    /~/.gradle/caches/transforms-3/6969468c8c2205847081e929b5586f42/transformed/jetified-kotlin-stdlib-common-1.5.31.jar (version 1.5)
w: Some runtime JAR files in the classpath have an incompatible version. Consider removing them from the classpath
e: warnings found and -Werror specified

[Araz Abishov (arazabishov)]

Tommy Nguyen (@tido64) react-native depends on 1.4.x, while RNTA on 1.5.x. The stdlib-jdk8 mismatch is introduced because RNTA is not opinionated on which version to use. A quick fix would be to add a dev on stdlib-jdk8 to RNTA:

diff --git a/android/dependencies.gradle b/android/dependencies.gradle
index 0987003..d5e416d 100644
--- a/android/dependencies.gradle
+++ b/android/dependencies.gradle
@@ -31,11 +31,12 @@ ext {
         junit                      : "junit:junit:4.13.2",
         kotlinReflect              : "org.jetbrains.kotlin:kotlin-reflect:1.5.31",
         kotlinStdlibJdk7           : "org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.5.31",
+        kotlinStdlibJdk8           : "org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.31",
         materialComponents         : "com.google.android.material:material:1.4.0",
         moshiKotlin                : "com.squareup.moshi:moshi-kotlin:1.12.0",
         moshiKotlinCodegen         : "com.squareup.moshi:moshi-kotlin-codegen:1.12.0",
     ]
 
     androidPluginVersion = "4.2.2"
     kotlinVersion = versionOf(libraries.kotlinStdlibJdk7)
 }

diff --git a/android/app/build.gradle b/android/app/build.gradle
index 7580451..57c9d96 100644
--- a/android/app/build.gradle
+++ b/android/app/build.gradle
@@ -67,6 +67,11 @@ android {
         ndkVersion ANDROID_NDK_VERSION
     }

     // TODO: Remove this block when minSdkVersion >= 24. See
     // https://stackoverflow.com/q/53402639 for details.
     compileOptions {
@@ -128,6 +133,7 @@ dependencies {
     }
 
     implementation libraries.kotlinStdlibJdk7
+    implementation libraries.kotlinStdlibJdk8
     implementation libraries.kotlinReflect
     implementation libraries.androidAppCompat
     implementation libraries.androidCoreKotlinExtensions

[Tommy Nguyen (tido64)]

Araz Abishov (@arazabishov) Thanks, I'll make the appropriate changes. One question: Is removing androidPluginVersion necessary? We use in several places:

react-native-test-app/android/build.gradle

Line 12 in 5a74110

classpath "com.android.tools.build:gradle:$androidPluginVersion"

react-native-test-app/android/react-native-build.gradle

Line 11 in 5a74110

classpath "com.android.tools.build:gradle:$androidPluginVersion"

react-native-test-app/example/android/build.gradle

Line 11 in 5a74110

classpath "com.android.tools.build:gradle:$androidPluginVersion"

[Araz Abishov (arazabishov)]

Tommy Nguyen (@tido64) nope, we need to keep it. That's just an unwanted bit of diff.

[Tommy Nguyen (tido64)]

react-native 0.67.0-rc.4:

Android	iOS

[Lorenzo Sciandra (kelset)]

TIL I learned you can use - for a range 🤣

[Tommy Nguyen (tido64)]

The string was getting really long so I played around with https://semver.npmjs.com/ to see if there's anything I can do to fix it. Then I saw the boxes at the bottom…