Skip to content

Review comments are missing in description view on GH Enterprise - #909

Closed
Peng Lyu (rebornix) wants to merge 1 commit into
masterfrom
rebornix/fix-graphqlcheck-for-timeline
Closed

Peng Lyu (rebornix) wants to merge 1 commit into
masterfrom
rebornix/fix-graphqlcheck-for-timeline

Conversation

@rebornix

Copy link
Copy Markdown
Contributor

No description provided.

@rebornix Peng Lyu (rebornix) changed the title Fix #908. Review comments are missing in description view on GH Enterprise Feb 1, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this doesn't do the right thing before #910, since supportsGraphQl was an unbound method, so destructuring it wouldn't work as expected.

I think after #910 it's no longer needed.

@rebornix

Copy link
Copy Markdown
Contributor Author

Ashi Krishnan (@queerviolet) that's right, I was about to push a new commit to fix that but since we have #910 we can close it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants