Repository navigation
build: include electron types in node modules cache - #332489
Merged
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Ladislau Szomoru (@lszomoru)Matched files:
|
Robo (deepak1556)
enabled auto-merge (squash)
August 25, 2026 06:35
Contributor
There was a problem hiding this comment.
Pull request overview
Updates node_modules caching to preserve generated Electron typings and invalidate stale caches when cache-list logic changes.
Changes:
- Adds Electron typings to cache archives.
- Includes cache-list script contents in the cache key.
Show a summary per file
| File | Description |
|---|---|
build/azure-pipelines/common/listNodeModules.ts |
Adds Electron typings to cached files. |
build/azure-pipelines/common/computeNodeModulesCacheKey.ts |
Invalidates caches when file-list logic changes. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
Robo (deepak1556)
marked this pull request as draft
August 25, 2026 06:41
auto-merge was automatically disabled
August 25, 2026 06:41
Pull request was converted to draft
Robo (deepak1556)
force-pushed
the
robo/fix_ci
branch
from
August 25, 2026 06:45
9a1ca17 to
a275b89
Compare
Robo (deepak1556)
marked this pull request as ready for review
August 25, 2026 06:46
Joaquín Ruales (jruales)
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/microsoft/vscode-engineering/issues/3697
Followup to #331833