Repository navigation
chore: bump electron@42.9.3 - #331833
Merged
Merged
chore: bump electron@42.9.3#331833
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates VS Code’s Electron runtime from 42.8.1 to 42.9.3 to address reported blank-window issues.
Changes:
- Bumps Electron dependency metadata.
- Updates component governance and artifact checksums.
- Updates the native module build target.
Show a summary per file
| File | Description |
|---|---|
package.json |
Bumps Electron dependency. |
package-lock.json |
Updates locked package metadata. |
cgmanifest.json |
Updates governance metadata. |
build/checksums/electron.txt |
Updates Electron artifact checksums. |
.npmrc |
Updates the Electron build target. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 4/5 changed files
- Comments generated: 1
- Review effort level: Balanced
Mohammad javad Dianat (dianatofficial)
left a comment
Mohammad javad Dianat (dianatofficial)
left a comment
There was a problem hiding this comment.
Solid PR. Tests cover the important paths.
|
can we change this to electron@42.10.0 to fix #330846 |
Robo (deepak1556)
force-pushed
the
robo/update_electron
branch
from
August 25, 2026 03:51
9f49d33 to
63d7dd4
Compare
Robo (deepak1556)
marked this pull request as ready for review
August 25, 2026 04:15
Collaborator
Author
|
Alex Schwartz (@alexsch01) update to 42.10.0 will happen this week once our custom builds are available. |
Dependency was only needed for types, binary download happens elsewhere. With the 7-day quarantine the dependency adds unnecessary delay on runtime update.
Locking to node 24.12.4 instead of 24.x to avoid quarantine delay. Can be bumped again in followup.
Robo (deepak1556)
force-pushed
the
robo/update_electron
branch
from
August 25, 2026 04:17
8788b56 to
ab665af
Compare
Dmitriy Vasyura (dmitrivMS)
previously approved these changes
Aug 25, 2026
Robo (deepak1556)
enabled auto-merge (squash)
August 25, 2026 04:58
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #261660
Fixes #329482
Refs https://releases.electronjs.org/release/compare/v42.8.1/v42.9.3